Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039699Openbravo ERPA. Platformpublic2018-11-27 10:122018-12-11 20:22
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039699: SortingFilteringGridConfiguration is failing when it should be skipped
DescriptionThe SortingFilteringGridConfiguration is failing when it should be skipped. This test is designed to be skipped when there exists grid configurations apart from the default ones.

In that case, instead of being skipped, the test is failing.
Steps To Reproduce1) Go to the [Grid Configuration at Window/Tab/Field level] window
2) Create a new record in the header, for any tab of core
3) Run the SortingFilteringGridConfiguration test. Note that it fails with the following error trace:

org.junit.internal.AssumptionViolatedException: Number of custom grid configs: got: <1>, expected: is <0>
    at org.junit.Assume.assumeThat(Assume.java:118)
    at org.openbravo.test.views.SortingFilteringGridConfiguration.shouldExecuteOnlyIfThereIsNoGridConfig(SortingFilteringGridConfiguration.java:67)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:538)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:760)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:460)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:206)

java.lang.NullPointerException
    at org.openbravo.test.views.SortingFilteringGridConfiguration.cleanUp(SortingFilteringGridConfiguration.java:84)
    ....
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038319 closed shuehner Openbravo ERP Skip grid config related junit tests if any module shipping grid configuration is installed - part3 
related to design defect 0039360 closed gorka_gil Retail Modules Terminal Log : Improve log client with cashier actions and processes start/end info 
related to defect 0039725 closed alostale Openbravo ERP ViewGeneration fails in retail CI 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-27 10:12caristuNew Issue
2018-11-27 10:12caristuAssigned To => platform
2018-11-27 10:12caristuModules => Core
2018-11-27 10:12caristuTriggers an Emergency Pack => No
2018-11-27 10:46caristuSummarySortingFilteringGridConfiguration is failing instead of being skipped => SortingFilteringGridConfiguration is failing when it should be skipped
2018-11-27 10:46caristuDescription Updatedbug_revision_view_page.php?rev_id=17976#r17976
2018-11-27 10:46caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17978#r17978
2018-11-27 10:46caristuAssigned Toplatform => caristu
2018-11-27 10:46caristuRelationship addedrelated to 0038319
2018-11-27 10:47caristuRelationship addedrelated to 0039360
2018-11-27 10:48caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17979#r17979
2018-11-27 11:05hgbotCheckin
2018-11-27 11:05hgbotNote Added: 0108121
2018-11-27 11:05hgbotStatusnew => resolved
2018-11-27 11:05hgbotResolutionopen => fixed
2018-11-27 11:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6e5c6474aebed7fbc4a63269d52a3b46c1720797 [^]
2018-11-27 11:05caristuReview Assigned To => alostale
2018-11-30 11:16alostaleNote Added: 0108179
2018-11-30 11:16alostaleStatusresolved => closed
2018-11-30 11:16alostaleFixed in Version => 3.0PR19Q1
2018-11-30 15:06alostaleRelationship addedrelated to 0039725
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108500

Notes
(0108121)
hgbot   
2018-11-27 11:05   
Repository: erp/devel/pi
Changeset: 6e5c6474aebed7fbc4a63269d52a3b46c1720797
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Nov 27 10:52:36 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6e5c6474aebed7fbc4a63269d52a3b46c1720797 [^]

Fixes issue 39699: Avoid NPE when test is skipped

  When the assumption done in the @BeforeClass method is not fullfilled, then initialization of the "coreWasInDevelopment" variable is not done. In that case, a NPE was being thrown later in the @AfterClass method.

  Now we are just simply avoiding that NPE in the @AfterClass method.

---
M src-test/src/org/openbravo/test/views/SortingFilteringGridConfiguration.java
---
(0108179)
alostale   
2018-11-30 11:16   
reviewed + tested
(0108500)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test