Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039691Retail ModulesWeb POSpublic2018-11-26 14:422019-04-15 16:18
Reportergorka_gil 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039691: Shared payment methods: race condition when saving the slave cashup
DescriptionWhen doing login into a slave of payment methods,
if go directly to the cashup it gives an error.

Looking into openbravo log can be seen that the cashup id is null, since the synchronization of the initial cachup done in the login still is not in the backend.

Looks like a race condition between the initial cashup and the runsynprocess to sync it to the backend.
Steps To ReproduceAfter add the terminal log project it can be reproduced in the shared payment tests, for example:
I31822_SPMQuotationSharedPayments (in the api method restoreSPMCashups)
Proposed SolutionEnsure that initcashup has finish before launch the runsyncprocess.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040617RR18Q4.3 closed gorka_gil Shared payment methods: race condition when saving the slave cashup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-26 14:42gorka_gilNew Issue
2018-11-26 14:42gorka_gilAssigned To => gorka_gil
2018-11-26 14:42gorka_gilOBNetwork customer => No
2018-11-26 14:42gorka_gilTriggers an Emergency Pack => No
2018-11-28 14:29hgbotCheckin
2018-11-28 14:29hgbotNote Added: 0108149
2018-11-30 14:58hgbotCheckin
2018-11-30 14:58hgbotNote Added: 0108193
2018-12-20 10:29hgbotCheckin
2018-12-20 10:29hgbotNote Added: 0108684
2018-12-20 10:29hgbotCheckin
2018-12-20 10:29hgbotNote Added: 0108685
2018-12-20 10:29hgbotStatusnew => resolved
2018-12-20 10:29hgbotResolutionopen => fixed
2018-12-20 10:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42c284b82acc6c8a8a3c847d83980838a499b8f2 [^]
2018-12-21 16:25marvintmReview Assigned To => marvintm
2018-12-21 16:25marvintmStatusresolved => closed
2018-12-21 16:25marvintmFixed in Version => RR19Q1
2019-04-15 16:17gorka_gilStatusclosed => new
2019-04-15 16:17gorka_gilResolutionfixed => open
2019-04-15 16:17gorka_gilFixed in VersionRR19Q1 =>
2019-04-15 16:17gorka_gilStatusnew => scheduled
2019-04-15 16:18gorka_gilStatusscheduled => resolved
2019-04-15 16:18gorka_gilResolutionopen => fixed
2019-04-15 16:18gorka_gilStatusresolved => closed
2019-04-15 16:18gorka_gilFixed in Version => RR19Q1

Notes
(0108149)
hgbot   
2018-11-28 14:29   
Repository: tools/automation/pi-mobile
Changeset: 390c13cdc1d050b7517114db795de239092cbea1
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Nov 28 13:56:44 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/390c13cdc1d050b7517114db795de239092cbea1 [^]

[TerminalLog] Related to issue 39360: Add Terminal Log project

Fix tests:
  - I30412_QuotationsAndPromotions.java
  - I33307_VerifyLoginUserWithTwoDistinctRoles.java

Disable some SharedPaymentMethods till issue 39691 is fixed.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30412_QuotationsAndPromotions.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I33307_VerifyLoginUserWithTwoDistinctRoles.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I31591_VerifySharePaymentsCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I35901_SPMVerifyErrorPopupInSlave.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMMulticurrencyPayInEURUSD.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMNeedToCloseMaster.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMQuotationSharedPayments.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMSaleAndReloadSharedPayments.java
---
(0108193)
hgbot   
2018-11-30 14:58   
Repository: tools/automation/pi-mobile
Changeset: 7ba0ebd347f3303ef0650d6bc52f279795008db4
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Nov 30 14:58:18 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7ba0ebd347f3303ef0650d6bc52f279795008db4 [^]

[TerminalLog] Related to issue 39360: Disable some SharedPaymentMethods tests till issue 39691 is fixed

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I31822_SPMQuotationSharedPayments.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithoutPriceIncludeTaxes.java
---
(0108684)
hgbot   
2018-12-20 10:29   
Repository: tools/automation/pi-mobile
Changeset: 0885732250090127a2c18bbc4ebc4318ac05ff5e
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Dec 18 13:32:21 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0885732250090127a2c18bbc4ebc4318ac05ff5e [^]

Related to issue 39691: Reenable shared payment method tests

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I31591_VerifySharePaymentsCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I31822_SPMQuotationSharedPayments.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I35901_SPMVerifyErrorPopupInSlave.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithoutPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMMulticurrencyPayInEURUSD.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMNeedToCloseMaster.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMQuotationSharedPayments.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMSaleAndReloadSharedPayments.java
---
(0108685)
hgbot   
2018-12-20 10:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 42c284b82acc6c8a8a3c847d83980838a499b8f2
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Dec 19 17:16:21 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42c284b82acc6c8a8a3c847d83980838a499b8f2 [^]

Fixed issue 39691: Fixed two problems with shared payment methods cashup synchronization:
- If terminal belonged to a hierarchy, initCashup and runsyncprocess were executed twice during login
- The synchronization of the cashup happened when the cashup hadn't yet been prepared to be synchronized

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---