Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039674Retail ModulesWeb POSpublic2018-11-22 11:182019-01-28 18:33
Reporterumartirena 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039674: One use coupons, if are tried to be used offline, they are not added to the ticket, and no message is returned giving any warn
DescriptionOne use coupons, if are tried to be used offline, they are not added to the ticket, and no message is returned giving any warn.

It should be added or an error message should appear explaining to the user the cause.
Steps To ReproduceLogin into https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^] [^] as "The White Valley Group" client.
Go to Discounts & Promotions window.
Search "Coupon 10" discount.
Add a new record in Coupon tab:
 * Coupon Code: COUPON20
 * Expire after 1 use: Selected.

Login into Web POS: https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS1001 [^] [^]

Search Wilderness wash 100 ml product.
Change price to 150.
Go offline
Open Coupon Code menu entry.
Search by COUPON20 coupon.
The coupon is not added and no message is returned explaining what has happened.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-22 11:18umartirenaNew Issue
2018-11-22 11:18umartirenaAssigned To => Retail
2018-11-22 11:18umartirenaTriggers an Emergency Pack => No
2018-11-22 12:37umartirenaResolution time => 1544655600
2018-11-23 05:08rqueraltaAssigned ToRetail => rqueralta
2018-11-23 05:08rqueraltaStatusnew => scheduled
2018-11-27 23:01hgbotCheckin
2018-11-27 23:01hgbotNote Added: 0108138
2018-11-27 23:01hgbotStatusscheduled => resolved
2018-11-27 23:01hgbotResolutionopen => fixed
2018-11-27 23:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f7c03d32673282c26f72e1b98f9de140e1234574 [^]
2018-11-30 17:00hgbotCheckin
2018-11-30 17:00hgbotNote Added: 0108196
2018-12-04 15:17marvintmReview Assigned To => marvintm
2018-12-04 15:17marvintmStatusresolved => closed
2018-12-04 15:17marvintmFixed in Version => RR19Q1
2018-12-05 09:05umartirenaNote Added: 0108263
2018-12-05 14:59hgbotCheckin
2018-12-05 14:59hgbotNote Added: 0108283
2019-01-28 18:33hgbotCheckin
2019-01-28 18:33hgbotNote Added: 0109286

Notes
(0108138)
hgbot   
2018-11-27 23:01   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: f7c03d32673282c26f72e1b98f9de140e1234574
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Nov 27 16:52:13 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f7c03d32673282c26f72e1b98f9de140e1234574 [^]

Fixed issue 39674: One use coupons, if are tried to be used offline, they are
not added to the ticket, and no message is returned giving any warn

- If POS aplication is offline a message is shown

---
M web/org.openbravo.retail.discounts.coupons/js/couponcode-popup.js
---
(0108196)
hgbot   
2018-11-30 17:00   
Repository: tools/automation/pi-mobile
Changeset: 0d184942e94668e67b4ccd6242e43dfa19432ea4
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Nov 28 16:07:56 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0d184942e94668e67b4ccd6242e43dfa19432ea4 [^]

Related to issue 39674: added automated test

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/I39674_VerifyMessageWhenUsingCouponInOfflineMode.java
---
(0108263)
umartirena   
2018-12-05 09:05   
The message returned it is not clear for me. It should inform the user that the operation is not permitted while being offline.
(0108283)
hgbot   
2018-12-05 14:59   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: 148ef853cb3c7a0ed0a50fdee8143cacb105363a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Dec 05 14:59:29 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/148ef853cb3c7a0ed0a50fdee8143cacb105363a [^]

Related to issue 39674. Clarified error message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0109286)
hgbot   
2019-01-28 18:33   
Repository: tools/automation/pi-mobile
Changeset: 4e2cf8bbd619e9a1d51d91db2353b8968e02e125
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Jan 23 11:11:49 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4e2cf8bbd619e9a1d51d91db2353b8968e02e125 [^]

Related to issue 39674: test has been refactored due to it no longer creates its
own sampledata

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/I39674_VerifyMessageWhenUsingCouponInOfflineMode.java
---