Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039660Openbravo ERPA. Platformpublic2018-11-21 11:582018-12-11 20:22
ReporterLeyre 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-02-23
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4a1f3df29564b6dd12259981f941d0d5d74bebab [^]
Triggers an Emergency PackNo
Summary0039660: Error deactivating an Organization
DescriptionYou can not consult information about an Organization that is deactivated
Steps To Reproduce1. Log in to the Backoffice -> Openbravo/openbravo

https://livebuilds.openbravo.com/retail_mp_3.0RR18Q3.2/security/Login [^]

Role = The White Valley Group Admin - The White Valley Group

2. Deactivate an Organization, for example White Valley Spain S.A

3. End Session and log in again with the same user.

4. Check that the information of this Organization can not be consulted.

* This happens for example in the "Financial Account" window. You can not filter by White Valley Spain Organization.
Proposed SolutionThis worked correctly in the 18Q1 version.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00396613.0PR18Q4 closed caristu Error deactivating an Organization 
depends on backport 00396623.0PR18Q3.3 closed caristu Error deactivating an Organization 
caused by feature request 0037980 closed alostale Improve organization cache in session 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-21 11:58LeyreNew Issue
2018-11-21 11:58LeyreAssigned To => platform
2018-11-21 11:58LeyreModules => Core
2018-11-21 11:58LeyreRegression date => 2018-12-12
2018-11-21 11:58LeyreTriggers an Emergency Pack => No
2018-11-21 12:04LeyreProposed Solution updated
2018-11-21 12:52caristuReview Assigned To => alostale
2018-11-21 12:52caristuRegression level => Production - Confirmed Stable
2018-11-21 12:52caristuRegression date2018-12-12 => 2018-02-23
2018-11-21 12:52caristuRegression introduced in release => 3.0PR18Q2
2018-11-21 12:52caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4a1f3df29564b6dd12259981f941d0d5d74bebab [^]
2018-11-21 12:52caristuAssigned Toplatform => caristu
2018-11-21 12:52caristuStatusnew => scheduled
2018-11-21 12:53caristuRelationship addedcaused by 0037980
2018-11-21 16:18hgbotCheckin
2018-11-21 16:18hgbotNote Added: 0108040
2018-11-21 16:18hgbotStatusscheduled => resolved
2018-11-21 16:18hgbotResolutionopen => fixed
2018-11-21 16:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5ad6a51b19f3fd143e26ec993b2a07ec3cda8d5b [^]
2018-11-23 13:36alostaleNote Added: 0108081
2018-11-23 13:36alostaleStatusresolved => closed
2018-11-23 13:36alostaleFixed in Version => 3.0PR19Q1
2018-11-26 19:36hgbotCheckin
2018-11-26 19:36hgbotNote Added: 0108112
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108490
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108499

Notes
(0108040)
hgbot   
2018-11-21 16:18   
Repository: erp/devel/pi
Changeset: 5ad6a51b19f3fd143e26ec993b2a07ec3cda8d5b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 21 12:59:10 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5ad6a51b19f3fd143e26ec993b2a07ec3cda8d5b [^]

fixes bug 39660: Standard DS isn't returning information of deactivated orgs

  Before this changeset[1] access to inactive organization was being given because getOrganizationStructureProvider().getNaturalTree(o)) does not filter by active organizations.

  Now that method is not being invoked when having direct access to "0" but the getOrganizations() method which indeed filters by active organizations.

  In order to be consistent, now the getOrganizations() method does no longer filter by active.

---
M src/org/openbravo/dal/core/OBContext.java
---
(0108081)
alostale   
2018-11-23 13:36   
reviewed + tested
(0108112)
hgbot   
2018-11-26 19:36   
Repository: erp/devel/pi
Changeset: cf5f7b83f80e49e7b9d805f3b504f2217d674c20
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 26 19:31:15 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cf5f7b83f80e49e7b9d805f3b504f2217d674c20 [^]

related to issue 39660: add test case

---
M src-test/src/org/openbravo/test/dal/OBContextTest.java
---
(0108490)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test
(0108499)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test