Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0039659 | Openbravo ERP | A. Platform | public | 2018-11-20 18:06 | 2018-12-11 20:22 |
|
| Reporter | caristu | |
| Assigned To | caristu | |
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR19Q1 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0039659: Cluster Service Leader Registrator should be able to recover properly after restarting the database |
| Description | The Cluster Service Leader Registrator thread is not recovering nicely after restarting the database. |
| Steps To Reproduce | 1) Configure Openbravo.properties to enable the ClusterServiceManager: cluster=true
2) Start Openbravo
3) Stop the database (without stopping Tomcat). The following warning will appear in the log after a few seconds:
[Cluster Service Leader Registrator] WARN org.openbravo.cluster.ClusterServiceManager - Node <nodeid> could not complete register/update
5) Restart the database. Note that the error continues
6) Check that the last ping is not being updated: select updated from ad_cluster_service;
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-11-20 18:06 | caristu | New Issue | |
| 2018-11-20 18:06 | caristu | Assigned To | => platform |
| 2018-11-20 18:06 | caristu | OBNetwork customer | => No |
| 2018-11-20 18:06 | caristu | Modules | => Core |
| 2018-11-20 18:06 | caristu | Triggers an Emergency Pack | => No |
| 2018-11-20 18:06 | caristu | Assigned To | platform => caristu |
| 2018-11-20 18:07 | caristu | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=17943#r17943 |
| 2018-11-20 18:07 | caristu | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=17944#r17944 |
| 2018-11-20 18:07 | caristu | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=17945#r17945 |
| 2018-11-21 10:33 | hgbot | Checkin | |
| 2018-11-21 10:33 | hgbot | Note Added: 0108028 | |
| 2018-11-21 10:33 | hgbot | Status | new => resolved |
| 2018-11-21 10:33 | hgbot | Resolution | open => fixed |
| 2018-11-21 10:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/65f68c63d325eeac390d2e93c0d2940e26412d30 [^] |
| 2018-11-21 11:28 | hgbot | Checkin | |
| 2018-11-21 11:28 | hgbot | Note Added: 0108030 | |
| 2018-11-21 11:28 | caristu | Review Assigned To | => alostale |
| 2018-11-23 13:46 | alostale | Note Added: 0108084 | |
| 2018-11-23 13:46 | alostale | Status | resolved => closed |
| 2018-11-23 13:46 | alostale | Fixed in Version | => 3.0PR19Q1 |
| 2018-12-11 20:22 | hudsonbot | Checkin | |
| 2018-12-11 20:22 | hudsonbot | Note Added: 0108488 | |
| 2018-12-11 20:22 | hudsonbot | Checkin | |
| 2018-12-11 20:22 | hudsonbot | Note Added: 0108489 | |
|
Notes |
|
|
(0108028)
|
|
hgbot
|
|
2018-11-21 10:33
|
|
Repository: erp/devel/pi
Changeset: 65f68c63d325eeac390d2e93c0d2940e26412d30
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 21 10:17:42 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/65f68c63d325eeac390d2e93c0d2940e26412d30 [^]
fixes bug 39659: ClusterServiceThread doesn't recover properly after DB restart
Moved OBDal.getInstance().commitAndClose(); to a finally block in order to ensure that the connection is returned properly to the pool even if there is an error during the registering/update of the cluster service leader.
Besides, in the finally block we are also forcing the cluster service to go to the database to check which node is the leader. Otherwise, in case of error it will be always checking against the ID of the leader that it keeps in cache.
---
M src/org/openbravo/cluster/ClusterServiceManager.java
---
|
|
|
|
(0108030)
|
|
hgbot
|
|
2018-11-21 11:28
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|