Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039658Retail ModulesWeb POSpublic2018-11-20 17:222018-12-04 12:12
ReporterLeyre 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket5943
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039658: The Web POS is blocked when it throws an exception in the balance.
DescriptionThe Web POS is blocked when it throws an exception in the balance.
Steps To ReproduceReview the code of the org.openbravo.retail.posterminal/js/model/order.js

if (p.get('obposScale') && !options.isVerifiedReturn) {
  ...
}

if there is an exception, the Web POS is blocked.
Proposed SolutionSee the attachment posterminal_scale.diff.

We test this in a client environment.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff posterminal_scale.diff (848) 2018-11-20 17:22
https://issues.openbravo.com/file_download.php?file_id=12376&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-11-20 17:22LeyreNew Issue
2018-11-20 17:22LeyreAssigned To => Retail
2018-11-20 17:22LeyreFile Added: posterminal_scale.diff
2018-11-20 17:22LeyreOBNetwork customer => OBPS
2018-11-20 17:22LeyreSupport ticket => 5943
2018-11-20 17:22LeyreResolution time => 1544482800
2018-11-20 17:22LeyreTriggers an Emergency Pack => No
2018-11-20 17:57rqueraltaAssigned ToRetail => rqueralta
2018-11-20 17:57rqueraltaStatusnew => scheduled
2018-11-28 14:57hgbotCheckin
2018-11-28 14:57hgbotNote Added: 0108152
2018-11-28 14:57hgbotStatusscheduled => resolved
2018-11-28 14:57hgbotResolutionopen => fixed
2018-11-28 14:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d5c292dabf8c3cd1c0187049816d252e81a37b8c [^]
2018-12-03 17:06migueldejuanaNote Added: 0108228
2018-12-03 17:06migueldejuanaStatusresolved => new
2018-12-03 17:06migueldejuanaResolutionfixed => open
2018-12-04 12:12migueldejuanaStatusnew => scheduled
2018-12-04 12:12migueldejuanaStatusscheduled => resolved
2018-12-04 12:12migueldejuanaResolutionopen => fixed
2018-12-04 12:12migueldejuanaReview Assigned To => migueldejuana
2018-12-04 12:12migueldejuanaNote Added: 0108247
2018-12-04 12:12migueldejuanaStatusresolved => closed

Notes
(0108152)
hgbot   
2018-11-28 14:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d5c292dabf8c3cd1c0187049816d252e81a37b8c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Nov 20 17:47:18 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d5c292dabf8c3cd1c0187049816d252e81a37b8c [^]

Fixed issue 39658: The Web POS is blocked when it throws an exception in the
balance

- Added call to callback funtion to avoid the Web POS blocked

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0108228)
migueldejuana   
2018-12-03 17:06   
There is no need no pass default values to callback function.

It should be enough with:

callback();

No need to call like this:

callback(false, null);
(0108247)
migueldejuana   
2018-12-04 12:12   
Tested and reviewed