Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039657Openbravo ERPA. Platformpublic2018-11-20 17:012018-12-14 09:40
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039657: Remove unneeded Logger getters/setters in ad_forms classes
DescriptionThere are a number of classes in ad_forms package that has public getter/setter methods that doesn't seem to be used. It would be nice to remove them to clean up the public API.

Full list of classes and method can be found here: https://docs.google.com/spreadsheets/d/1N23QlPbJlPBBwyKO57mvur6YVLKH7mE5ekJrQqE4jjo/edit?usp=sharing [^]
Steps To ReproduceSee above
Proposed SolutionCheck whether those methods are needed anywhere and remove them.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0039504 closed jarmendariz Upgrade Log4j to version 2 
related to defect 0039739 closed jarmendariz API Change: Remove logger getter and setter methods in ad_form classes 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-20 17:01jarmendarizNew Issue
2018-11-20 17:01jarmendarizAssigned To => platform
2018-11-20 17:01jarmendarizModules => Core
2018-11-20 17:01jarmendarizTriggers an Emergency Pack => No
2018-11-22 09:48alostaleRelationship addedblocks 0032688
2018-11-22 09:49alostaleSummaryAPI Change: Remove unneeded Logger getters/setters in ad_forms classes => Remove unneeded Logger getters/setters in ad_forms classes
2018-11-22 09:50alostaleRelationship addedrelated to 0039504
2018-11-30 14:33jarmendarizStatusnew => scheduled
2018-11-30 14:33jarmendarizAssigned Toplatform => jarmendariz
2018-12-04 10:07jarmendarizRelationship addedrelated to 0039739
2018-12-12 09:39hgbotCheckin
2018-12-12 09:39hgbotNote Added: 0108529
2018-12-12 09:39hgbotStatusscheduled => resolved
2018-12-12 09:39hgbotResolutionopen => fixed
2018-12-12 09:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/699e368e6274111a30837861da7acfb13bc5030e [^]
2018-12-12 09:40jarmendarizReview Assigned To => alostale
2018-12-12 13:59hudsonbotCheckin
2018-12-12 13:59hudsonbotNote Added: 0108549
2018-12-14 09:40alostaleNote Added: 0108601
2018-12-14 09:40alostaleStatusresolved => closed
2018-12-14 09:40alostaleFixed in Version => 3.0PR19Q1

Notes
(0108529)
hgbot   
2018-12-12 09:39   
Repository: erp/devel/pi
Changeset: 699e368e6274111a30837861da7acfb13bc5030e
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Dec 04 09:22:11 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/699e368e6274111a30837861da7acfb13bc5030e [^]

Fixed issue 39657: Removed unused logger getter/setter methods

Removed logger setter/getter methods as they are not used and not having them
avoids API breaks when the log framework changes. Also changed visibility of
logger as private and final.

---
M src/org/openbravo/erpCommon/ad_forms/DocAmortization.java
M src/org/openbravo/erpCommon/ad_forms/DocBank.java
M src/org/openbravo/erpCommon/ad_forms/DocCash.java
M src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java
M src/org/openbravo/erpCommon/ad_forms/DocCostAdjustmentTemplate.java
M src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
M src/org/openbravo/erpCommon/ad_forms/DocInOut.java
M src/org/openbravo/erpCommon/ad_forms/DocInternalConsumption.java
M src/org/openbravo/erpCommon/ad_forms/DocInventory.java
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
M src/org/openbravo/erpCommon/ad_forms/DocLCCost.java
M src/org/openbravo/erpCommon/ad_forms/DocLandedCost.java
M src/org/openbravo/erpCommon/ad_forms/DocLine_LCCost.java
M src/org/openbravo/erpCommon/ad_forms/DocLine_LandedCost.java
M src/org/openbravo/erpCommon/ad_forms/DocLine_Payment.java
M src/org/openbravo/erpCommon/ad_forms/DocMatchInv.java
M src/org/openbravo/erpCommon/ad_forms/DocMovement.java
M src/org/openbravo/erpCommon/ad_forms/DocOrder.java
M src/org/openbravo/erpCommon/ad_forms/DocPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocProduction.java
M src/org/openbravo/erpCommon/ad_forms/Translation.java
---
(0108549)
hudsonbot   
2018-12-12 13:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1a781af6612 [^]
Maturity status: Test
(0108601)
alostale   
2018-12-14 09:40   
reviewed