Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039647Retail ModulesWeb POSpublic2018-11-19 18:202018-12-07 11:59
Reporteranderaranguren 
Assigned Torqueralta 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date2017-02-20
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ef736becd65aa38498f8d692ae148f6f1a791b95 [^]
Triggers an Emergency PackNo
Summary0039647: It is not possible to edit the style of the modal-dialog popups because is overwritten with the default value
DescriptionIt is not possible to edit the style of the modal-dialog popups because is overwritten with the default value this.setStyle('display: initial');
Steps To ReproduceN/A
Proposed SolutionIn ob-commonbutons.js change the line:
 this.setStyle('display: initial');
for
 this.setStyle(this.getStyle() + '; display: initial;');
And in ob-utilitiesui.js change the line:
 popup.setStyle('display:initial');
for
 popup.setStyle(popup.getStyle() + '; display: initial;');
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-19 18:20anderarangurenNew Issue
2018-11-19 18:20anderarangurenAssigned To => Retail
2018-11-19 18:20anderarangurenRegression date => 2017-02-20
2018-11-19 18:20anderarangurenRegression introduced in release => RR17Q2
2018-11-19 18:20anderarangurenRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ef736becd65aa38498f8d692ae148f6f1a791b95 [^]
2018-11-19 18:20anderarangurenTriggers an Emergency Pack => No
2018-11-20 10:55egoitzResolution time => 1542927600
2018-11-20 11:16anderarangurenNote Added: 0108007
2018-11-20 11:16anderarangurenProposed Solution updated
2018-11-20 11:31jfrancesIssue Monitored: jfrances
2018-11-21 20:55rqueraltaAssigned ToRetail => rqueralta
2018-11-21 20:58rqueraltaStatusnew => scheduled
2018-11-23 12:32hgbotCheckin
2018-11-23 12:32hgbotNote Added: 0108076
2018-11-23 12:32hgbotStatusscheduled => resolved
2018-11-23 12:32hgbotResolutionopen => fixed
2018-11-23 12:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9290b7102356f9bb9eec73014c3b5f305a42224f [^]
2018-11-26 15:05jorge-garciaNote Added: 0108105
2018-11-26 15:05jorge-garciaStatusresolved => new
2018-11-26 15:05jorge-garciaResolutionfixed => open
2018-11-26 15:16jorge-garciaReview Assigned To => jorge-garcia
2018-11-28 13:05hgbotCheckin
2018-11-28 13:05hgbotNote Added: 0108145
2018-11-28 13:05hgbotStatusnew => resolved
2018-11-28 13:05hgbotResolutionopen => fixed
2018-11-28 13:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9290b7102356f9bb9eec73014c3b5f305a42224f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7c2359e9ae46d715556b0239bae72c8a3208535f [^]
2018-11-28 13:06hgbotCheckin
2018-11-28 13:06hgbotNote Added: 0108146
2018-12-04 13:58marvintmNote Added: 0108250
2018-12-04 13:58marvintmStatusresolved => new
2018-12-04 13:58marvintmResolutionfixed => open
2018-12-04 21:57hgbotCheckin
2018-12-04 21:57hgbotNote Added: 0108260
2018-12-04 21:57hgbotStatusnew => resolved
2018-12-04 21:57hgbotResolutionopen => fixed
2018-12-04 21:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7c2359e9ae46d715556b0239bae72c8a3208535f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f56218344703afcb8bb7811049e0dfe0b69239b3 [^]
2018-12-07 11:59marvintmStatusresolved => closed
2018-12-07 11:59marvintmFixed in Version => RR19Q1

Notes
(0108007)
anderaranguren   
2018-11-20 11:16   
Regression introduced through above commit and also through this one:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/880de1b8a8c0 [^]
(0108076)
hgbot   
2018-11-23 12:32   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9290b7102356f9bb9eec73014c3b5f305a42224f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Nov 21 15:09:55 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9290b7102356f9bb9eec73014c3b5f305a42224f [^]

Fixed issue 39647: It is not possible to edit the style of the
modal-dialog popups because is overwritten with the default value

- Avoided to be overwritten the modal-dialog popups style

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0108105)
jorge-garcia   
2018-11-26 15:05   
The solution applied is not working following these steps:

1) Login in webPOS
2) Execute this code in developers tools:
   "OB.UTIL.showConfirmation.display('Confirm', 'This is a confirmation popup with an orange background', null, {style: 'background-color: #EBA001'});"
3) An orange popup is shown
4) Execute this code in developers tools:
   "OB.UTIL.showLoading(true);"
5) The Loading view is showm
6) Execute this code in developers tools:
   "OB.UTIL.showLoading(false);"
7) The popup is shown again, but the background color is green (this is wrong)
(0108145)
hgbot   
2018-11-28 13:05   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7c2359e9ae46d715556b0239bae72c8a3208535f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Nov 26 12:24:27 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7c2359e9ae46d715556b0239bae72c8a3208535f [^]

Fixed issue 39647: It is not possible to edit the style of the
modal-dialog popups because is overwritten with the default value

- Avoided to be overwritten the modal-dialog popups style before hide popup

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0108146)
hgbot   
2018-11-28 13:06   
Repository: tools/automation/pi-mobile
Changeset: fbdafcd6f5528e9f41368111cd068e80ac39ed46
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Nov 27 10:49:35 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fbdafcd6f5528e9f41368111cd068e80ac39ed46 [^]

Related to issue 39647: It is not possible to edit the style of the
modal-dialog popups because is overwritten with the default value

- Changed script executed, to search a substring into style string.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35170_HideOpenedPopupOnShowLoading.java
---
(0108250)
marvintm   
2018-12-04 13:58   
After latest changes the showLoading calls that Jorge mentioned in his comments are not working correctly, the showLoading window including the scrim should appear over the popup, and the scrim part is not appearing correctly
(0108260)
hgbot   
2018-12-04 21:57   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f56218344703afcb8bb7811049e0dfe0b69239b3
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Dec 04 11:36:36 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f56218344703afcb8bb7811049e0dfe0b69239b3 [^]

Fixed issue 39647: It is not possible to edit the style of the
modal-dialog popups because is overwritten with the default value

- Avoided to be overwritten the modal-dialog popups style before hide popup

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---