Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039644Openbravo ERPA. Platformpublic2018-11-16 12:552018-12-21 13:21
ReporterJONHM 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039644: Add product p&e is not sorting the selected records when clearing filters
DescriptionAdd product p&e is not sorting the selected records when clearing filters. This can confuse the user if the p&e has lots of rows.
Steps To Reproduce- Open Product Characteristic window and create a new record. Then create a new [Line] for that product characteristic.
- Run 'Add product' p&e and filter by some row (ES/0004) and then select it.
- Clear filters (funnel icon)

The selected record is not placed on the top of the p&e
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033622 closed caristu Wrong behavior in Select Payment Pick/Execute Window when having >100 records selected 
depends on defect 0039819 closed platform API changes in DataSourceUtils.getSelectedRecordsFromCriteria 
has duplicate defect 0041816 closed Triage Finance Create lines fails for a purchase order when the environment has many records and the filter is used and later it is cleaned 
related to defect 0040381 closed alostale incorrect warn message logged by ReadOnlyDataSourceService for P&E  
related to defect 0043396 closed cberner In case selected record does not belong to the first page of records, it is removed when selecting a new record 
Attached Filespng Screenshot from 2018-11-16 12-52-18.png (144,605) 2018-11-16 12:55
https://issues.openbravo.com/file_download.php?file_id=12367&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-11-16 12:55JONHMNew Issue
2018-11-16 12:55JONHMAssigned To => platform
2018-11-16 12:55JONHMFile Added: Screenshot from 2018-11-16 12-52-18.png
2018-11-16 12:55JONHMModules => Core
2018-11-16 12:55JONHMResolution time => 1544137200
2018-11-16 12:55JONHMTriggers an Emergency Pack => No
2018-11-16 13:00PracticsIssue Monitored: Practics
2018-12-03 16:35alostaleRelationship addedrelated to 0033622
2018-12-04 12:25alostaleStatusnew => scheduled
2018-12-04 12:25alostaleAssigned Toplatform => alostale
2018-12-17 13:43alostaleRelationship addeddepends on 0039819
2018-12-17 13:44alostaleReview Assigned To => caristu
2018-12-17 13:46hgbotCheckin
2018-12-17 13:46hgbotNote Added: 0108638
2018-12-17 13:46hgbotStatusscheduled => resolved
2018-12-17 13:46hgbotResolutionopen => fixed
2018-12-17 13:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9bb00b5b71ad1b6f6e0951212f001a6a98a144a1 [^]
2018-12-17 20:39hudsonbotCheckin
2018-12-17 20:39hudsonbotNote Added: 0108656
2018-12-20 17:16hgbotCheckin
2018-12-20 17:16hgbotNote Added: 0108692
2018-12-20 21:30hudsonbotCheckin
2018-12-20 21:30hudsonbotNote Added: 0108709
2018-12-21 09:02hgbotCheckin
2018-12-21 09:02hgbotNote Added: 0108715
2018-12-21 09:41caristuNote Added: 0108716
2018-12-21 09:41caristuStatusresolved => closed
2018-12-21 09:41caristuFixed in Version => 3.0PR19Q1
2018-12-21 13:21hudsonbotCheckin
2018-12-21 13:21hudsonbotNote Added: 0108720
2019-03-22 10:05alostaleRelationship addedrelated to 0040381
2019-09-27 13:01SandrahuguetRelationship addedhas duplicate 0041816
2020-04-09 08:35alostaleRelationship addedrelated to 0043396

Notes
(0108638)
hgbot   
2018-12-17 13:46   
Repository: erp/devel/pi
Changeset: 9bb00b5b71ad1b6f6e0951212f001a6a98a144a1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Dec 14 15:22:51 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9bb00b5b71ad1b6f6e0951212f001a6a98a144a1 [^]

fixed bug 39644: P&E doesn't set selected records on top

  In P&E selected records in UI were not set on top of non selected ones.

  Now they are sorted in backend, also we ensure that the whole selection is
  returned in the page even if it didn't originally fit on it.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0108656)
hudsonbot   
2018-12-17 20:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/79c941a6a880 [^]
Maturity status: Test
(0108692)
hgbot   
2018-12-20 17:16   
Repository: erp/devel/pi
Changeset: 053a02c45e1f6a3cd3f6d74710ce8796e90eb47a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Dec 20 17:14:44 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/053a02c45e1f6a3cd3f6d74710ce8796e90eb47a [^]

related to bug 39644: Minor code improvements

  - Update copyright year
  - Remove unused parameter

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0108709)
hudsonbot   
2018-12-20 21:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/32784e66f6df [^]
Maturity status: Test
(0108715)
hgbot   
2018-12-21 09:02   
Repository: erp/devel/pi
Changeset: 6f808eb12d3dbf5e6c2bd7b4b2a5bae5bd4493e4
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Dec 21 09:01:36 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6f808eb12d3dbf5e6c2bd7b4b2a5bae5bd4493e4 [^]

related to bug 39644: code cleanup

  Removed redundant criteria parameter as it can be obtained from queryService.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0108716)
caristu   
2018-12-21 09:41   
Code reviewed + tested OK.
(0108720)
hudsonbot   
2018-12-21 13:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c99770195951 [^]
Maturity status: Test