Openbravo Issue Tracking System - Retail Modules
View Issue Details
0039635Retail ModulesWeb POSpublic2018-11-15 15:112019-01-18 14:17
adrianromero 
rqueralta 
urgentmajorhave not tried
closedfixed 
5
RR18Q3.2 
RR19Q2 
marvintm
No
0039635: Modifications of Best sellers at terminal type level do not trigger the incremental update criteria
With the module installed org.openbravo.retail.bestsellers, if a product is marked or unmarked as best seller at terminal type level, the change is not reflected if reloading a WEBPOS terminal. It is needed to delete the browser cache or do a fake modification of the product in the assortment or in the product master table.
* Install org.openbravo.retail.bestsellers
* Mark a product (For example Hiking boots) as best seller at assortment level but not at terminal type level.
* Clean the browser cache and login in VBS-1 terminal
* Observe the product Hiking boots is not loaded as best seller <- OK
* Mark the product as best seller at terminal type level
* Reload the terminal
* Observe the product is not loaded as bestseller <- WRONG

* As test. Go to the product in the assortment table modify the record, save, restore the record to the original values and save again
* Reload the terminal
* Observe the product is loaded as bestseller <- OK
If the product is marked / unmarked at terminal type level. Modify also the updated and updatedby fields at assortment level to force the incremental update criteria.

Apply attached mercurial export file
No tags attached.
diff issue39635.diff (7,041) 2018-11-15 15:19
https://issues.openbravo.com/file_download.php?file_id=12366&type=bug
Issue History
2018-11-15 15:11adrianromeroNew Issue
2018-11-15 15:11adrianromeroAssigned To => adrianromero
2018-11-15 15:11adrianromeroTriggers an Emergency Pack => No
2018-11-15 15:19adrianromeroFile Added: issue39635.diff
2018-11-15 15:19adrianromeroAssigned Toadrianromero => marvintm
2018-11-15 15:19adrianromeroProposed Solution updated
2018-11-15 15:36adrianromeroProposed Solution updated
2018-12-17 09:22rafarodaIssue Monitored: rafaroda
2018-12-20 12:56marvintmTarget VersionRR19Q1 =>
2019-01-11 08:37marvintmAssigned Tomarvintm => Retail
2019-01-12 13:42rqueraltaAssigned ToRetail => rqueralta
2019-01-14 21:36hgbotCheckin
2019-01-14 21:36hgbotNote Added: 0108953
2019-01-14 21:36hgbotStatusnew => resolved
2019-01-14 21:36hgbotResolutionopen => fixed
2019-01-14 21:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/6fbfc03dbdd4ac3ea2f3507b7452b1ada8ee3448 [^]
2019-01-14 21:36hgbotCheckin
2019-01-14 21:36hgbotNote Added: 0108954
2019-01-18 14:17marvintmReview Assigned To => marvintm
2019-01-18 14:17marvintmStatusresolved => closed
2019-01-18 14:17marvintmFixed in Version => RR19Q2

Notes
(0108953)
hgbot   
2019-01-14 21:36   
Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: 6fbfc03dbdd4ac3ea2f3507b7452b1ada8ee3448
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Nov 15 15:13:15 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/6fbfc03dbdd4ac3ea2f3507b7452b1ada8ee3448 [^]

Fixes issue 0039635: Modifications of Best sellers at terminal type level do not trigger the incremental update criteria
Update fields updated and updated by at assortment level if best seller record at terminaltype level is modified

---
M src/org/openbravo/retail/bestsellers/BestSellersByTerminalTypeDatasource.java
---
(0108954)
hgbot   
2019-01-14 21:36   
Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: f5c562482be375b131f2f077bc1c270fb01b2a6e
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Nov 15 15:15:03 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/f5c562482be375b131f2f077bc1c270fb01b2a6e [^]

Related to issue 0039635: Modifications of Best sellers at terminal type level do not trigger the incremental update criteria
Update best sellers at terminal type level to load the correct audit field values

---
M src-db/database/model/views/BEST_PRODUCT_TTYPE_VIEW.xml
---