Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039625Retail ModulesStoreServerpublic2018-11-14 11:072018-12-21 13:58
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039625: The WebPOS broadcast service calls success always only on first server irrespective of its state
DescriptionThe WebPOS has a special service type called broadcast [1]. This service type is used for example for logout or role change. The current behavior is that the success/failure callback are only called for the first server in the list. All servers are called, even the ones that are listed as offline.

This results in that if the first server fails but the rest succeed that the success is never called.

There are several different options possible. But for now the choice is to only allow call of success/fail on an online server
Steps To ReproduceInstall multi-server.
Login, do some things
Stop CS, go offline
Go to WebPOS change role
Proposed SolutionSee description
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039179 closed mtaal Changing the Role in a multiserver environment only changes the context in the Store 
Attached Filesdiff chg_role.diff (3,897) 2018-12-01 18:57
https://issues.openbravo.com/file_download.php?file_id=12399&type=bug
diff 39625.diff (1,414) 2018-12-02 16:49
https://issues.openbravo.com/file_download.php?file_id=12403&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-11-14 11:07mtaalNew Issue
2018-11-14 11:07mtaalAssigned To => mtaal
2018-11-14 11:07mtaalTriggers an Emergency Pack => No
2018-11-14 11:07mtaalRelationship addedrelated to 0039179
2018-12-01 18:57mtaalFile Added: chg_role.diff
2018-12-02 16:49mtaalFile Added: 39625.diff
2018-12-02 21:10mtaalNote Added: 0108219
2018-12-02 21:10mtaalReview Assigned To => migueldejuana
2018-12-02 21:11hgbotCheckin
2018-12-02 21:11hgbotNote Added: 0108220
2018-12-02 21:11hgbotStatusnew => resolved
2018-12-02 21:11hgbotResolutionopen => fixed
2018-12-02 21:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1bb3b394ebf3b1d18502d71b29406d2852e8f376 [^]
2018-12-03 16:46migueldejuanaNote Added: 0108226
2018-12-03 16:46migueldejuanaStatusresolved => closed
2018-12-20 22:30mtaalStatusclosed => new
2018-12-20 22:30mtaalResolutionfixed => open
2018-12-20 22:31hgbotCheckin
2018-12-20 22:31hgbotNote Added: 0108712
2018-12-20 22:31hgbotStatusnew => resolved
2018-12-20 22:31hgbotResolutionopen => fixed
2018-12-20 22:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1bb3b394ebf3b1d18502d71b29406d2852e8f376 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a8fdd97e58af067dc039ad7b5d2e9ec3a2eab35f [^]
2018-12-21 13:58migueldejuanaNote Added: 0108725
2018-12-21 13:58migueldejuanaStatusresolved => closed

Notes
(0108219)
mtaal   
2018-12-02 21:10   
The chosen solution approach is to only consider online server for success/fail callback.
(0108220)
hgbot   
2018-12-02 21:11   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1bb3b394ebf3b1d18502d71b29406d2852e8f376
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Dec 02 21:11:06 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1bb3b394ebf3b1d18502d71b29406d2852e8f376 [^]

Fixes issue 39625: The WebPOS broadcast service calls success always only on first server irrespective of its state
Only consider first online server for callback

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0108226)
migueldejuana   
2018-12-03 16:46   
Reviewed
(0108712)
hgbot   
2018-12-20 22:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a8fdd97e58af067dc039ad7b5d2e9ec3a2eab35f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Dec 20 22:30:57 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a8fdd97e58af067dc039ad7b5d2e9ec3a2eab35f [^]

Fixes issue 39625: The WebPOS broadcast service calls success always only on first server irrespective of its state
If there are no online servers then just select the first one for calling success/fail

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0108725)
migueldejuana   
2018-12-21 13:58   
Reviewed