Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0039621Openbravo ERPZ. Otherspublic2018-11-13 17:272018-11-16 13:12
caristu 
AugustoMauch 
highminoralways
closedfixed 
5
 
3.0PR18Q43.0PR18Q4 
caristu
Core
Production - Confirmed Stable
2018-02-02
3.0PR18Q2
https://code.openbravo.com/erp/devel/pi/rev/18388657f3c0f155490eeed4ab39b431492b2dc0 [^]
No
0039621: Display logic in Product window does not work properly while opening as a tab from another window
Display logic in Product window does not work properly while opening as a tab from another window
Login in the backend
Go to Windows, tabs adn fields window as System Admin
Select Product window and Price tab
Set display logic = @AD_Role_ID@='D615084948E046E3A439915008F464A6'
Login As 'F&B International Group Admin' and go to Product window
    See that Price tab is hidden
Go to sales order window, select a line and open the product on a tab
    See that Price tab is now shown
No tags attached.
blocks defect 0039405 closed AugustoMauch Display logic in Product window does not work properly while opening as a tab from another window 
Issue History
2018-11-13 17:27caristuNew Issue
2018-11-13 17:27caristuAssigned To => AugustoMauch
2018-11-13 17:27caristuModules => Core
2018-11-13 17:27caristuResolution time => 1540418400
2018-11-13 17:27caristuRegression level => Production - Confirmed Stable
2018-11-13 17:27caristuRegression date => 2018-02-02
2018-11-13 17:27caristuRegression introduced in release => 3.0PR18Q2
2018-11-13 17:27caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/18388657f3c0f155490eeed4ab39b431492b2dc0 [^]
2018-11-13 17:27caristuTriggers an Emergency Pack => No
2018-11-13 17:27caristuIssue generated from0039405
2018-11-13 17:28caristuRelationship addedblocks 0039405
2018-11-13 17:28caristuTypedefect => backport
2018-11-13 18:36hgbotCheckin
2018-11-13 18:36hgbotNote Added: 0107891
2018-11-13 18:36hgbotStatusnew => resolved
2018-11-13 18:36hgbotResolutionopen => fixed
2018-11-13 18:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/64c305a4665d750dbf4a308f87cd00c1af16884c [^]
2018-11-13 18:36AugustoMauchReview Assigned To => caristu
2018-11-16 13:12caristuNote Added: 0107950
2018-11-16 13:12caristuStatusresolved => closed
2018-11-16 13:12caristuFixed in Version => 3.0PR18Q4

Notes
(0107891)
hgbot   
2018-11-13 18:36   
Repository: erp/backports/3.0PR18Q4
Changeset: 64c305a4665d750dbf4a308f87cd00c1af16884c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Nov 13 18:08:42 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/64c305a4665d750dbf4a308f87cd00c1af16884c [^]

Fixes issue 39621: Tab display logic works when direct opening a header tab

Before this change, when a window was opened by clicking on a column title, the display logic of the
tabs of the window were not evaluated. This was done because if the tab opened was a subtab, that tab
should be visible, regardless of that tab's display logic.

But there is no need to enforce that logic when the tab opened is a header tab. This changeset evaluates
the display logics of the tabs if the tab opened directly is a header tab.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0107950)
caristu   
2018-11-16 13:12   
Code reviewed + tested OK.