Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039620Openbravo ERPZ. Otherspublic2018-11-13 17:252018-11-16 09:54
Reportercaristu 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q3.3Fixed in Version3.0PR18Q3.3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-02-02
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/18388657f3c0f155490eeed4ab39b431492b2dc0 [^]
Triggers an Emergency PackNo
Summary0039620: Display logic in Product window does not work properly while opening as a tab from another window
DescriptionDisplay logic in Product window does not work properly while opening as a tab from another window
Steps To ReproduceLogin in the backend
Go to Windows, tabs adn fields window as System Admin
Select Product window and Price tab
Set display logic = @AD_Role_ID@='D615084948E046E3A439915008F464A6'
Login As 'F&B International Group Admin' and go to Product window
    See that Price tab is hidden
Go to sales order window, select a line and open the product on a tab
    See that Price tab is now shown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039405 closed AugustoMauch Display logic in Product window does not work properly while opening as a tab from another window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-13 17:25caristuNew Issue
2018-11-13 17:25caristuAssigned To => AugustoMauch
2018-11-13 17:25caristuModules => Core
2018-11-13 17:25caristuResolution time => 1540418400
2018-11-13 17:25caristuRegression level => Production - Confirmed Stable
2018-11-13 17:25caristuRegression date => 2018-02-02
2018-11-13 17:25caristuRegression introduced in release => 3.0PR18Q2
2018-11-13 17:25caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/18388657f3c0f155490eeed4ab39b431492b2dc0 [^]
2018-11-13 17:25caristuTriggers an Emergency Pack => No
2018-11-13 17:25caristuIssue generated from0039405
2018-11-13 17:25caristuRelationship addedblocks 0039405
2018-11-13 17:26caristuTypedefect => backport
2018-11-14 09:22AugustoMauchReview Assigned To => caristu
2018-11-14 09:23hgbotCheckin
2018-11-14 09:23hgbotNote Added: 0107896
2018-11-14 09:23hgbotStatusnew => resolved
2018-11-14 09:23hgbotResolutionopen => fixed
2018-11-14 09:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q3.3/rev/ab71c6a062430606e417aaded43c81610e583a9d [^]
2018-11-16 09:54caristuNote Added: 0107944
2018-11-16 09:54caristuStatusresolved => closed
2018-11-16 09:54caristuFixed in Version => 3.0PR18Q3.3

Notes
(0107896)
hgbot   
2018-11-14 09:23   
Repository: erp/backports/3.0PR18Q3.3
Changeset: ab71c6a062430606e417aaded43c81610e583a9d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 14 09:22:19 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q3.3/rev/ab71c6a062430606e417aaded43c81610e583a9d [^]

Fixes issue 39620: Tab display logic works when direct opening a header tab

Before this change, when a window was opened by clicking on a column title, the display logic of the
tabs of the window were not evaluated. This was done because if the tab opened was a subtab, that tab
should be visible, regardless of that tab's display logic.

But there is no need to enforce that logic when the tab opened is a header tab. This changeset evaluates
the display logics of the tabs if the tab opened directly is a header tab.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0107944)
caristu   
2018-11-16 09:54   
Code reviewed + tested OK.