Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039595Openbravo ERP04. Warehouse managementpublic2018-11-06 16:312018-12-11 20:22
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039595: Purchase Invoice Line can be edited after the associated landed cost has been processed
DescriptionPurchase Invoice Line can be edited after the associated landed cost has been processed
Steps To ReproduceAs group admin role:
   Create a G/L Item
   Set it as Enable in Financial Invoices and add a Tax Category to it

   Create a Landed Cost Type:
      Landed Cost Distribution Algorithm: Distribution by Amount
      Account: previously created G/L Item

   Create a goods receipt, add a product and complete it
   Launch Costing Background Process and check it finishes successfully
   Create a purchase invoice for same business partner
   Add a financial line to it and select previously created G/L Item
   Complete it

   Create a Landed Cost
   Add a record in Cost tab and select previously created invoice
   Add a record in Receipt tab and select previously created goods receipt

   Return to Purchase Invoice
   Reactivate it

   Return to Landed Cost
   Process it

   Return to Purchase Invoice, leave the Account field empty, set the Financial Invoice Line to N and select a product in product selector
   Complete it
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-06 16:31ngarciaNew Issue
2018-11-06 16:31ngarciaAssigned To => Triage Finance
2018-11-06 16:31ngarciaModules => Core
2018-11-06 16:31ngarciaResolution time => 1543273200
2018-11-06 16:31ngarciaTriggers an Emergency Pack => No
2018-11-06 16:33ngarciaIssue Monitored: networkb
2018-11-07 18:04SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-11-09 16:31jfrancesIssue Monitored: jfrances
2018-11-20 12:40AtulOpenbravoStatusnew => scheduled
2018-11-21 09:15AtulOpenbravoNote Added: 0108026
2018-11-21 09:18AtulOpenbravoNote Edited: 0108026bug_revision_view_page.php?bugnote_id=0108026#r17947
2018-11-23 13:47hgbotCheckin
2018-11-23 13:47hgbotNote Added: 0108086
2018-11-23 13:47hgbotStatusscheduled => resolved
2018-11-23 13:47hgbotResolutionopen => fixed
2018-11-23 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f9ad951760ca64a5175191b6019ab9da5dc5974 [^]
2018-11-23 13:47hgbotCheckin
2018-11-23 13:47hgbotNote Added: 0108087
2018-11-23 13:51SandrahuguetReview Assigned To => Sandrahuguet
2018-11-23 13:51SandrahuguetNote Added: 0108088
2018-11-23 13:51SandrahuguetStatusresolved => closed
2018-11-23 13:51SandrahuguetFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108496
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108497

Notes
(0108026)
AtulOpenbravo   
2018-11-21 09:15   
(edited on: 2018-11-21 09:18)
01. Login as International Group admin role
02. Create a G/L Item, set it as Enable in Financial Invoices and add a Tax Category to it
03. Create a Landed Cost Type:
      Landed Cost Distribution Algorithm: Distribution by Amount
      Account: previously created G/L Item
04. Create a goods receipt, add a product and complete it
05. Launch Costing Background Process and check it finishes successfully
06. Create a purchase invoice for same business partner
07. Add a financial line to it and select previously created G/L Item, complete it
08. Create a Landed Cost
    Add a record in Cost tab and select previously created invoice
    Add a record in Receipt tab and select previously created goods receipt
09. Return to Purchase Invoice, reactivate it.
10. Try to edit line.
11. Realize that message is shown as below:-
   Error
   Saving failed. The invoice line of a re-activated invoice that is linked to a Landed Cost cannot be modified.

Note: Description, Line No, List Price could be edited.
(0108086)
hgbot   
2018-11-23 13:47   
Repository: erp/devel/pi
Changeset: 5f9ad951760ca64a5175191b6019ab9da5dc5974
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Nov 20 18:22:31 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5f9ad951760ca64a5175191b6019ab9da5dc5974 [^]

Fixes Issue 39595: Purchase Invoice Line can be edited after
the associated landed cost has been processed

** Before editing invoice line check whether it is linked
with landed cost - cost tab record.
** Description, Line No, List Price editing is possible.
** Check is done only for Purchase Invoice Lines.
** Earlier check of m_inoutline link is also applicable for
Purchase Invoice line hence it is included in the condition
Issotrx = 'N'.

---
M src-db/database/model/triggers/C_INVOICELINE_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0108087)
hgbot   
2018-11-23 13:47   
Repository: erp/devel/pi
Changeset: 641c5b66d58076f5ee20777f3ed8e54d6b41b785
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Nov 23 11:45:53 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/641c5b66d58076f5ee20777f3ed8e54d6b41b785 [^]

related to issue 39595 code review changes

---
M src-db/database/model/triggers/C_INVOICELINE_TRG.xml
---
(0108088)
Sandrahuguet   
2018-11-23 13:51   
Code review + testing OK
(0108496)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test
(0108497)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test