Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039586Retail ModulesWeb POSpublic2018-10-22 12:362018-11-19 15:58
Reporteranderaranguren 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionRR18Q4Fixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039586: It is not possible to apply a manual promotion/discount to a negative line
DescriptionIt is not possible to apply a manual promotion/discount to a negative line
Steps To Reproduce1) Log in the WebPOS
2) Add a gps handheld and see that a discount is applied to the line
3) Go to menu and click on return this ticket.
4) The discount dissapears
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039495 closed jorge-garcia It is not possible to apply a manual promotion/discount to a negative line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-11-05 19:04marvintmTypedefect => backport
2018-11-05 19:04marvintmTarget Version => RR18Q4
2018-11-19 15:42hgbotCheckin
2018-11-19 15:42hgbotNote Added: 0107986
2018-11-19 15:43hgbotCheckin
2018-11-19 15:43hgbotNote Added: 0107987
2018-11-19 15:43hgbotCheckin
2018-11-19 15:43hgbotNote Added: 0107988
2018-11-19 15:43hgbotStatusscheduled => resolved
2018-11-19 15:43hgbotResolutionopen => fixed
2018-11-19 15:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fe8ab59ffca2688550e2a9dfbe294339a5acb446 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q4/org.openbravo.retail.discounts/rev/0a293d94518c94dc05ee64e0a783b54e6c7895b8 [^]
2018-11-19 15:58marvintmReview Assigned To => marvintm
2018-11-19 15:58marvintmStatusresolved => closed
2018-11-19 15:58marvintmFixed in Version => RR18Q4

Notes
(0107986)
hgbot   
2018-11-19 15:42   
Repository: retail/backports/3.0RR18Q4/org.openbravo.retail.sampledata
Changeset: 7d99f5387f73072886d9d51495c513b992edb3a2
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 19 15:30:26 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4/org.openbravo.retail.sampledata/rev/7d99f5387f73072886d9d51495c513b992edb3a2 [^]

Related to issue 39586: It is not possible to apply a manual promotion/discount
to a negative line

Add sampledata due to new column definition.

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0107987)
hgbot   
2018-11-19 15:43   
Repository: retail/backports/3.0RR18Q4/org.openbravo.retail.posterminal
Changeset: 097f3c246c5daa82f7ccef42bfdc556878a95221
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 19 15:27:35 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4/org.openbravo.retail.posterminal/rev/097f3c246c5daa82f7ccef42bfdc556878a95221 [^]

Related to issue 39586: It is not possible to apply a manual promotion/discount
to a negative line

Change message to indicate current promotion could not be applied to negative
lines.

Use new flag definition to allow or to deny apply a manual promotion to a
negative line.

Save flag value in promotion applied.

If the user change the quantity of the line using Return Line button or Return
this receipt, even if the manual promotion is marked to be applied in negative
lines, the discount disappears.

The problem now is fixed for both cases.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107988)
hgbot   
2018-11-19 15:43   
Repository: retail/backports/3.0RR18Q4/org.openbravo.retail.discounts
Changeset: 0a293d94518c94dc05ee64e0a783b54e6c7895b8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 19 15:25:08 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4/org.openbravo.retail.discounts/rev/0a293d94518c94dc05ee64e0a783b54e6c7895b8 [^]

Fixed issue 39586: It is not possible to apply a manual promotion/discount
to a negative line

This commit includes:
  * Definition of a new column in m_offer table
  * A new field in discounts and promotions to allow to apply manual promotions
    to negative lines.
  * Change manual percentage calculation to work with negative lines.

---
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---