Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039519Openbravo ERPA. Platformpublic2018-10-24 10:212018-12-11 20:22
Reporterdmiguelez 
Assigned Tojarmendariz 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2018-10-18
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/43a7e93a946d76de69bb30b066d41a6647508b30 [^]
Triggers an Emergency PackNo
Summary0039519: Not possible to book a Resource Reservation
DescriptionNot possible to book a Resource Reservation, it fails with the error message 'InvalidCSRFToken'
Steps To ReproduceWith Resource and Reservation Management module installed

Log in as F&B Admin

Set up

Go to Resource Category Window and create a new record with:
- Organization: *
- Name: Test Resource Category

Go to Reservation Calendar and create a new record with:
- Organization: F&B España
- Name: Test Reservation Calendar
- Time Reservation Unit: Hourly

Go to Resource Window and create a new record with:
- Organization: F&B España
- SearchK Key: TR
- Name: Test Resource
- Resource Type: Generic
- Resource Category: Test Resource Category
- Reservation Calendar: Test Reservation Calendar
- Product Category: Alcoholic
- Bookable Online: Checked
- Bookable by All Users: Checked

Go to the Workspace
Add a Widget named Resource Reservation
In the Widget select F&B España as the Organization and click on Book a Resource
Set Business Partner 'Alimentos y Supermercados' and Resource 'Test Resource'
Click on Book and Confirm

An error is shown 'InvalidCSRFToken'
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0039123 closed jarmendariz Add CSRF Token support 
Attached Filespng Screenshot from 2018-10-24 10-17-33.png (170,303) 2018-10-24 10:21
https://issues.openbravo.com/file_download.php?file_id=12307&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-10-24 10:21dmiguelezNew Issue
2018-10-24 10:21dmiguelezAssigned To => platform
2018-10-24 10:21dmiguelezFile Added: Screenshot from 2018-10-24 10-17-33.png
2018-10-24 10:21dmiguelezModules => Core
2018-10-24 10:21dmiguelezRegression level => Pre packaging ( pi )
2018-10-24 10:21dmiguelezRegression date => 2018-10-18
2018-10-24 10:21dmiguelezRegression introduced in release => pi
2018-10-24 10:21dmiguelezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/43a7e93a946d76de69bb30b066d41a6647508b30 [^]
2018-10-24 10:21dmiguelezTriggers an Emergency Pack => No
2018-10-24 10:26jarmendarizRelationship addedrelated to 0039123
2018-10-24 12:45jarmendarizStatusnew => scheduled
2018-10-24 12:45jarmendarizAssigned Toplatform => jarmendariz
2018-10-25 12:38hgbotCheckin
2018-10-25 12:38hgbotNote Added: 0107583
2018-10-25 12:38hgbotStatusscheduled => resolved
2018-10-25 12:38hgbotResolutionopen => fixed
2018-10-25 12:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/47a3436da5965ac00f69913fe31ce0508969788b [^]
2018-10-25 12:39jarmendarizReview Assigned To => caristu
2018-11-08 19:08caristuNote Added: 0107811
2018-11-08 19:08caristuStatusresolved => closed
2018-11-08 19:08caristuFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108443
2019-03-26 12:25caristuRelationship deletedrelated to 0039123
2019-03-26 12:25caristuRelationship addedcaused by 0039123

Notes
(0107583)
hgbot   
2018-10-25 12:38   
Repository: erp/devel/pi
Changeset: 47a3436da5965ac00f69913fe31ce0508969788b
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Oct 24 12:50:10 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/47a3436da5965ac00f69913fe31ce0508969788b [^]

Fixed issue 39519: Not possible to book a Resource Reservation.

Removed setCsrfToken and initialized the DS with the OB.User.csrfToken value
directly. This prevents forcing the one who instantiates the DS to set the
token manually.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/calendar/ob-calendar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view-datasource.js
M modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
---
(0107811)
caristu   
2018-11-08 19:08   
Code reviewed + tested OK.
(0108443)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test