Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039516Openbravo ERPA. Platformpublic2018-10-23 16:302018-12-11 20:22
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039516: PG 10: false local changes positive after restoring PG 9.3 dump
DescriptionHaving a PostgreSQL 10 or 11 database created from a dump obtained from 9.3, updata.database incorrectly detects local changes in DB structure.

Workarround: execute 1st update with -Dforce=true parameter.
Steps To Reproduce1. Install Openbravo (at least 18Q1) in PostgreSQL 9.3 (ie. Openbravo Appliance 14.04)
2. Do a pg_dump
3. Restore that pg_dump in a PostgreSQL 10 or 11
4. Run ant update.database
  -> ERROR: local changes detected
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00395203.0PR18Q4 closed alostale PG 10: false local changes positive after restoring PG 9.3 dump 
depends on backport 00395213.0PR18Q3.2 closed alostale PG 10: false local changes positive after restoring PG 9.3 dump 
depends on backport 00395223.0PR18Q2.3 closed alostale PG 10: false local changes positive after restoring PG 9.3 dump 
blocks feature request 0036911 closed alostale support PostgreSQL 10 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-10-23 16:30alostaleNew Issue
2018-10-23 16:30alostaleAssigned To => platform
2018-10-23 16:30alostaleModules => Core
2018-10-23 16:30alostaleTriggers an Emergency Pack => No
2018-10-23 16:32alostaleAssigned Toplatform => alostale
2018-10-24 10:19alostaleRelationship addedblocks 0036911
2018-10-24 10:21alostaleReview Assigned To => caristu
2018-10-24 10:22alostaleStatusnew => scheduled
2018-10-24 10:31hgbotCheckin
2018-10-24 10:31hgbotNote Added: 0107544
2018-10-24 10:31hgbotStatusscheduled => resolved
2018-10-24 10:31hgbotResolutionopen => fixed
2018-10-24 10:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f5adc2a709a639f4aa1717ba3aed94e6273061f0 [^]
2018-10-24 10:32alostaleNote Added: 0107545
2018-10-29 11:24caristuNote Added: 0107635
2018-10-29 11:24caristuStatusresolved => closed
2018-10-29 11:24caristuFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108440

Notes
(0107544)
hgbot   
2018-10-24 10:31   
Repository: erp/devel/pi
Changeset: f5adc2a709a639f4aa1717ba3aed94e6273061f0
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Oct 24 10:31:04 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f5adc2a709a639f4aa1717ba3aed94e6273061f0 [^]

fixed bug 39516: false local changes positive restoring PG 9.3 dump on PG 10

  After restoring in PG 10 a DB dump taken in PG 9.3, first update.database run
  incorrectly detects local changes.

  This was caused by many new functions added in PG 10 to trigram extension, those
  functions were unnecessarily included in the model checksum used to check if
  there are local changes.

  Now those functions are excluded: as dbsm only supports plsql functions, we now
  filter out all the ones implemented by binary code, which is how typically
  extension functions are implemented.

---
M src-db/database/model/prescript-PostgreSql.sql
---
(0107545)
alostale   
2018-10-24 10:32   
Note: this fix to take effect needs to be applied in old DB and execute update.database there at least once before taking the dump.
(0107635)
caristu   
2018-10-29 11:24   
Reviewed
(0108440)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test