Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039480ModulesSAP Connectorpublic2018-10-18 13:152018-10-26 08:51
Reportersamuel_nicuesa 
Assigned Toaferraz 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0039480: System does not allow the same SAP Code to be used in a different client
DescriptionWe are trying to create a new Client (one for each country) and have been configuring organizations, pos terminals etc., While configuring Payment Methods, noticed that the system does not allow the same SAP Code to be used in a different client.
Steps To Reproduce[BO]
Client 1
Configure a SAP Code in one payment method

Client 2
Configure the same SAP Code in the payment method
Proposed SolutionSee the attached file
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0039452 acknowledged Triage Platform Base SAP connector doesn't support multi-client architecture. 
Attached Filesdiff PossibleFixTrg.diff (495) 2018-10-18 13:15
https://issues.openbravo.com/file_download.php?file_id=12288&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-10-18 13:15samuel_nicuesaNew Issue
2018-10-18 13:15samuel_nicuesaAssigned To => platform
2018-10-18 13:15samuel_nicuesaFile Added: PossibleFixTrg.diff
2018-10-18 13:15samuel_nicuesaResolution time => 1541631600
2018-10-18 13:15samuel_nicuesaAssigned Toplatform => Triage Finance
2018-10-18 14:31rafarodaIssue Monitored: rafaroda
2018-10-18 14:32rafarodaRelationship addedrelated to 0039452
2018-10-19 11:48psanjuanStatusnew => scheduled
2018-10-22 11:43aferrazAssigned ToTriage Finance => aferraz
2018-10-22 11:45hgbotCheckin
2018-10-22 11:45hgbotNote Added: 0107472
2018-10-22 11:45hgbotStatusscheduled => resolved
2018-10-22 11:45hgbotResolutionopen => fixed
2018-10-22 11:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/9c29c354f211dea33f7bf625f411770338ad5183 [^]
2018-10-22 11:45aferrazReview Assigned To => aferraz
2018-10-22 11:45aferrazNote Added: 0107473
2018-10-22 11:45aferrazStatusresolved => closed
2018-10-23 20:40aferrazStatusclosed => new
2018-10-23 20:40aferrazResolutionfixed => open
2018-10-23 20:41hgbotCheckin
2018-10-23 20:41hgbotNote Added: 0107531
2018-10-23 20:42aferrazNote Added: 0107532
2018-10-24 09:38aferrazNote Edited: 0107532bug_revision_view_page.php?bugnote_id=0107532#r17827
2018-10-24 09:40hgbotCheckin
2018-10-24 09:40hgbotNote Added: 0107541
2018-10-24 09:40hgbotStatusnew => resolved
2018-10-24 09:40hgbotResolutionopen => fixed
2018-10-24 09:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/9c29c354f211dea33f7bf625f411770338ad5183 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/0d5e840bef2d797070c3207122bf38a1498033b4 [^]
2018-10-24 09:46dmiguelezReview Assigned Toaferraz => dmiguelez
2018-10-24 09:46dmiguelezNote Added: 0107542
2018-10-24 09:46dmiguelezStatusresolved => closed
2018-10-26 08:51hgbotCheckin
2018-10-26 08:51hgbotNote Added: 0107609

Notes
(0107472)
hgbot   
2018-10-22 11:45   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: 9c29c354f211dea33f7bf625f411770338ad5183
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Oct 22 11:44:52 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/9c29c354f211dea33f7bf625f411770338ad5183 [^]

Fixes issue 39480: Allow using the same PM SAP code in different clients

---
M src-db/database/model/modifiedTables/FIN_PAYMENTMETHOD.xml
---
(0107473)
aferraz   
2018-10-22 11:45   
Attached fix reviewed.
(0107531)
hgbot   
2018-10-23 20:41   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: 5761e7f9cd0bd362d5dcb6feae06c3ba463d8bcd
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Oct 23 20:41:27 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/5761e7f9cd0bd362d5dcb6feae06c3ba463d8bcd [^]

Related to issue 39480: Backed out changeset 9c29c354f211

---
M src-db/database/model/modifiedTables/FIN_PAYMENTMETHOD.xml
---
(0107532)
aferraz   
2018-10-23 20:42   
(edited on: 2018-10-24 09:38)
Reopened as fix is not working properly in Oracle:

CREATE TABLE p1 (c1 varchar2(32), c2 varchar2(32))
ALTER TABLE p1 ADD CONSTRAINT p1_nulls UNIQUE (c1)
INSERT INTO p1 VALUES (null, '123')
INSERT INTO p1 VALUES (null, '123')
INSERT INTO p1 VALUES (null, '123') --> It does not fail

ALTER TABLE p1 DROP CONSTRAINT p1_nulls
DELETE FROM p1

ALTER TABLE p1 ADD CONSTRAINT p1_nulls UNIQUE (c1,c2)
INSERT INTO p1 VALUES (null, '123')
INSERT INTO p1 VALUES (null, '123') --> It fails

INSERT INTO p1 VALUES (null, null)
INSERT INTO p1 VALUES (null, null)
INSERT INTO p1 VALUES (null, null) --> It does not fail
(0107541)
hgbot   
2018-10-24 09:40   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: 0d5e840bef2d797070c3207122bf38a1498033b4
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Oct 24 09:36:14 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/0d5e840bef2d797070c3207122bf38a1498033b4 [^]

Fixes issue 39480: Remove EM_SAPOBMP_SAPCODE_UNQ constraint

---
M src-db/database/model/modifiedTables/FIN_PAYMENTMETHOD.xml
---
(0107542)
dmiguelez   
2018-10-24 09:46   
Code Review + Testing Ok
(0107609)
hgbot   
2018-10-26 08:51   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: 449ec27eb8698e0eb4125d4764703774b1fae204
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Oct 26 08:42:08 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/449ec27eb8698e0eb4125d4764703774b1fae204 [^]

Related to issue 39480: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---