Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039469Openbravo ERP04. Warehouse managementpublic2018-10-17 13:492018-10-29 12:27
Reporterngarcia 
Assigned ToTriage Omni WMS 
PriorityurgentSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039469: Orphan lines do not currently support instance attributes
DescriptionOrphan lines do not currently support instance attributes

Currently, it is not possible to select an already available attribute set value in product selector, so when the value is manually included in the Attribute Set Value field it will have a different identifier. In sales flow (Return From Customer), you will be able to receive the product but it will be considered different from the already available one. In purchase flow (Return To Vendor), you will not able to ship the product if you don't allow negative stock on your bins
Steps To ReproduceAs group admin role:
   Set RM Allow Orphan Line preference to Y
   Log out and log in

   Create a new product
   Set Lot Attribute set to it
   Add a purchase price list it

   Create a Goods Receipt
   Add previously created product
   Set 1 in Attribute Set Value field
   Add a movement quantity and complete

   Create a Return to Vendor header
   Insert Orphan Line
   Select previously create product
   Add 1 in Attribute Set Value field (as the product with attribute set value cannot be selected in Product selector, it will be a new attribute set instance and there will not be stock of it)
   Book it
 
   Create a Return To Vendor Shipment header and select Pick/Edit Lines
   Select previously created line and you will get the following error:

      "There isn't enough available stock for RM order No: 1000002"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039468 new Triage Omni WMS Documentation about how orphan lines with attributes in Returns work should be improved 
related to defect 00281973.0PR15Q2 closed AtulOpenbravo It is not possible to handle attributes (Lot) inserting orphan lines 
related to defect 0039530 closed markmm82 No stock error for Orphan lines in Return to Vendor Shipment if it includes instance attributes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-10-17 13:49ngarciaNew Issue
2018-10-17 13:49ngarciaAssigned To => Triage Finance
2018-10-17 13:49ngarciaModules => Core
2018-10-17 13:49ngarciaTriggers an Emergency Pack => No
2018-10-17 13:49ngarciaIssue Monitored: networkb
2018-10-17 13:50ngarciaRelationship addedrelated to 0039468
2018-10-17 13:51ngarciaRelationship addedrelated to 0028197
2018-10-22 17:12dmiguelezNote Added: 0107498
2018-10-24 12:29dmiguelezNote Edited: 0107498bug_revision_view_page.php?bugnote_id=0107498#r17829
2018-10-24 12:33dmiguelezNote Edited: 0107498bug_revision_view_page.php?bugnote_id=0107498#r17830
2018-10-24 12:33dmiguelezNote Edited: 0107498bug_revision_view_page.php?bugnote_id=0107498#r17831
2018-10-24 12:42dmiguelezNote Added: 0107552
2018-10-24 12:42dmiguelezTypedesign defect => defect
2018-10-24 12:52ngarciaResolution time => 1542150000
2018-10-24 13:04ngarciaResolution time1542150000 =>
2018-10-24 13:04ngarciaTypedefect => design defect
2018-10-24 13:09ngarciaIssue cloned0039530
2018-10-24 13:09ngarciaRelationship addedrelated to 0039530
2018-10-24 13:11ngarciaNote Deleted: 0107552
2018-10-24 13:17ngarciaDescription Updatedbug_revision_view_page.php?rev_id=17833#r17833
2018-10-29 12:27martinsdanIssue Monitored: martinsdan

Notes
(0107498)
dmiguelez   
2018-10-22 17:12   
(edited on: 2018-10-24 12:33)
There is a design defect with Attributes and Orphan Lines

The actual functionality works for Return From Customers (when the Warehouse receives the material), but it does not work for Return To Vendors (when the Warehouse issues the goods)

Right now, it is using and old attribute selector. That is the reason why a new attribute set instance is created every time and also is the reason why the process is defined as a 'Report and Process' instead of a 'Process Definition'

The solution for the Return to Vendors would be to create a new Stock selector (similar to what has been done in AWO for the Attribute Swap project) This would allow to select the attribute of a particular stock.

The development would be:
* Create a new Process Definition that replaces the Report And Process
* Create a Stock selector for this Product Definition that would allow to select an existing Attribute
* Refactor the Code behind the actual process to split functional logic from input and output (follow MVC conventions)
* Adapt functional logic to support new Process Definition as well as old Report And Process
* Add Automated Tests (they should be running successfully as soon as the refactor is done)