Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039467Retail ModulesWeb POSpublic2018-10-17 13:292018-12-11 16:50
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039467: [RR18Q4][Web POS Save Removed Tickets] After deleting a receipt, "Done" button is clickable. If it's clicked, application breaks
DescriptionWith "Web POS Save Removed Tickets" set us "Y", after deleting a receipt, it is possible clicking Done button. If it is clicked the application will get stuck.
That DONE button must not appear in this flow.
Steps To Reproduce0-Configure "Web POS Save Removed Tickets" preference as Y.
1-Login POS as vallblanca.
2-Create a receipt and add many products to that receipt.
3-Click Total Amount button. Without completing that receipt, click "Trash" button and remove that receipt. Realise that, at the right of the screen, Done button will be briefly shown. It is clickable. If it is clicked, the application will get stuck.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Broken.png (130,080) 2018-10-17 13:29
https://issues.openbravo.com/file_download.php?file_id=12278&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-10-17 13:29lorenzofidalgoNew Issue
2018-10-17 13:29lorenzofidalgoAssigned To => Retail
2018-10-17 13:29lorenzofidalgoFile Added: Broken.png
2018-10-17 13:29lorenzofidalgoTriggers an Emergency Pack => No
2018-10-17 13:30lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=17773#r17773
2018-11-19 11:34ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-11-19 11:34ranjith_qualiantech_comStatusnew => scheduled
2018-11-23 05:32hgbotCheckin
2018-11-23 05:32hgbotNote Added: 0108064
2018-11-23 05:32hgbotStatusscheduled => resolved
2018-11-23 05:32hgbotResolutionopen => fixed
2018-11-23 05:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a803308685c561e13c2f671a66ac114cb64f2308 [^]
2018-12-04 17:24migueldejuanaNote Added: 0108254
2018-12-04 17:24migueldejuanaStatusresolved => new
2018-12-04 17:24migueldejuanaResolutionfixed => open
2018-12-05 11:49ranjith_qualiantech_comStatusnew => scheduled
2018-12-05 11:49hgbotCheckin
2018-12-05 11:49hgbotNote Added: 0108276
2018-12-05 11:49hgbotStatusscheduled => resolved
2018-12-05 11:49hgbotResolutionopen => fixed
2018-12-05 11:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a803308685c561e13c2f671a66ac114cb64f2308 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5cdf2ac8e1822129ea2e343a3d039b527d0b9e70 [^]
2018-12-05 17:14migueldejuanaNote Added: 0108297
2018-12-05 17:14migueldejuanaStatusresolved => new
2018-12-05 17:14migueldejuanaResolutionfixed => open
2018-12-06 10:07ranjith_qualiantech_comStatusnew => scheduled
2018-12-06 11:24hgbotCheckin
2018-12-06 11:24hgbotNote Added: 0108313
2018-12-06 11:24hgbotStatusscheduled => resolved
2018-12-06 11:24hgbotResolutionopen => fixed
2018-12-06 11:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5cdf2ac8e1822129ea2e343a3d039b527d0b9e70 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/103766bcddda2827e18b09ff6bf4f4ded522726f [^]
2018-12-11 16:50migueldejuanaReview Assigned To => migueldejuana
2018-12-11 16:50migueldejuanaNote Added: 0108403
2018-12-11 16:50migueldejuanaStatusresolved => closed

Notes
(0108064)
hgbot   
2018-11-23 05:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a803308685c561e13c2f671a66ac114cb64f2308
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Nov 23 10:01:45 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a803308685c561e13c2f671a66ac114cb64f2308 [^]

Fixed issue 39467 : Toolbar Delete button should be disabled while removing receipt

* Multi Click should be prevented for Toolbar Delete button if it is disabled

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0108254)
migueldejuana   
2018-12-04 17:24   
We should show scrim till the next order(or new order) is loaded. We should not be able to press Done button.
(0108276)
hgbot   
2018-12-05 11:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5cdf2ac8e1822129ea2e343a3d039b527d0b9e70
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Dec 05 16:19:08 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5cdf2ac8e1822129ea2e343a3d039b527d0b9e70 [^]

Fixed issue 39467 : Scrim should be shown while deleting the receipt

* Scrim should be shown while deleting the receipt will prevent user action on POS

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0108297)
migueldejuana   
2018-12-05 17:14   
The scrim is hidden by the confirmation popup. We should show the scrim after we press Yes in the popup (OB.UI.btnModalApplyDelete).

We need to find the place to hide the scrim, the line added in the last commit is not working. At some point we set the Tab from PAYMENT tab to SCAN, maybe this could be the place.
(0108313)
hgbot   
2018-12-06 11:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 103766bcddda2827e18b09ff6bf4f4ded522726f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 06 15:53:51 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/103766bcddda2827e18b09ff6bf4f4ded522726f [^]

Fixed issue 39467 : Before removing receipt, Scrim should be shown to prevent user actions

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0108403)
migueldejuana   
2018-12-11 16:50   
Tested and reviewed