Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039401Retail ModulesCopy Retail Storepublic2018-10-04 13:042018-10-19 11:58
Reporterucarrion 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date2018-10-03
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039401: Copy Store process is duplicating POS Terminal payment method categories
DescriptionCopy Store process is duplicating POS Terminal payment method categories
Steps To Reproduce+Do Copy Retail Store process
+Check that POS Terminal payment methods are being duplicated
Proposed SolutionSee patch attached
Additional Information
TagsNo tags attached.
Relationships
Attached Files? copyStoreFix.export (2,564) 2018-10-04 13:19
https://issues.openbravo.com/file_download.php?file_id=12238&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-10-04 13:04ucarrionNew Issue
2018-10-04 13:04ucarrionAssigned To => Retail
2018-10-04 13:04ucarrionOBNetwork customer => Yes
2018-10-04 13:04ucarrionResolution time => 1539986400
2018-10-04 13:04ucarrionRegression date => 2018-10-03
2018-10-04 13:04ucarrionTriggers an Emergency Pack => No
2018-10-04 13:19guillermogilFile Added: copyStoreFix.export
2018-10-04 13:19guillermogilProposed Solution updated
2018-10-04 19:54rqueraltaAssigned ToRetail => rqueralta
2018-10-04 19:55rqueraltaStatusnew => scheduled
2018-10-08 20:47hgbotCheckin
2018-10-08 20:47hgbotNote Added: 0107221
2018-10-08 20:47hgbotStatusscheduled => resolved
2018-10-08 20:47hgbotResolutionopen => fixed
2018-10-08 20:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/666117af6d9b2afade9701c091b403ebbcd63ad4 [^]
2018-10-19 11:58marvintmReview Assigned To => marvintm
2018-10-19 11:58marvintmStatusresolved => closed
2018-10-19 11:58marvintmFixed in Version => RR19Q1

Notes
(0107221)
hgbot   
2018-10-08 20:47   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 666117af6d9b2afade9701c091b403ebbcd63ad4
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Oct 04 13:04:28 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/666117af6d9b2afade9701c091b403ebbcd63ad4 [^]

Fixed issue 39401: PaymentMethodCategories will no longer be duplicated.
Before, the payment method category referenced by a payment method was always cloned. This is not correct, the payment method category should be handled like the rest of the referenced objects in the retail configuration, so that if they are still visible in the new organization (or by the new terminal in case of copy terminal process), then the new object should reference the original payment method category, but if the payment method category is not visible, then it should be cloned but only once, and then the rest should reference the cloned object. This functionality is already implemented in the getObjectInTree method, so we can just use that one to achieve it.

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---