Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039397Retail ModulesWeb POSpublic2018-10-03 11:592018-10-29 11:06
Reporteranderaranguren 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket4924
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039397: Wrong behaviour of the cashup when doing a reverse payment of an order and paying it again
DescriptionWrong behaviour of the cashup when doing a reverse payment of an order and paying it again
Steps To Reproducesteps
Login Web POS
Add a product to the order. Avalanche Transceiver
Pay the order
Load the order
Reverse the payment
Pay partially with cash and the rest with card
Go to the Backend to POS Terminal window, Cash Up History and see that the payment has been added twice: 301.00 instead of 150.50
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng cashUpHistory.png (150,448) 2018-10-03 11:59
https://issues.openbravo.com/file_download.php?file_id=12230&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-10-03 11:59anderarangurenNew Issue
2018-10-03 11:59anderarangurenAssigned To => Retail
2018-10-03 11:59anderarangurenFile Added: cashUpHistory.png
2018-10-03 11:59anderarangurenOBNetwork customer => Yes
2018-10-03 11:59anderarangurenSupport ticket => 4924
2018-10-03 11:59anderarangurenResolution time => 1540332000
2018-10-03 11:59anderarangurenTriggers an Emergency Pack => No
2018-10-03 13:57ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-10-03 13:57ranjith_qualiantech_comStatusnew => scheduled
2018-10-06 07:42hgbotCheckin
2018-10-06 07:42hgbotNote Added: 0107200
2018-10-06 07:42hgbotStatusscheduled => resolved
2018-10-06 07:42hgbotResolutionopen => fixed
2018-10-06 07:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f28cb7541103b409d1b22bf416b24982311417fd [^]
2018-10-06 07:43hgbotCheckin
2018-10-06 07:43hgbotNote Added: 0107201
2018-10-16 18:02marvintmNote Added: 0107346
2018-10-16 18:02marvintmStatusresolved => new
2018-10-16 18:02marvintmResolutionfixed => open
2018-10-17 08:13ranjith_qualiantech_comStatusnew => scheduled
2018-10-26 12:44hgbotCheckin
2018-10-26 12:44hgbotNote Added: 0107620
2018-10-26 12:44hgbotStatusscheduled => resolved
2018-10-26 12:44hgbotResolutionopen => fixed
2018-10-26 12:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f28cb7541103b409d1b22bf416b24982311417fd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f9e76004c999e980fd7da73330cca1a6eea72341 [^]
2018-10-26 12:45hgbotCheckin
2018-10-26 12:45hgbotNote Added: 0107621
2018-10-29 11:06marvintmReview Assigned To => marvintm
2018-10-29 11:06marvintmStatusresolved => closed
2018-10-29 11:06marvintmFixed in Version => RR19Q1

Notes
(0107200)
hgbot   
2018-10-06 07:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f28cb7541103b409d1b22bf416b24982311417fd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Oct 06 11:12:33 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f28cb7541103b409d1b22bf416b24982311417fd [^]

Fixed issue 39397 : Payment method Cashup should not be updated for Reverse payment

* Cashup should not be updated if receipt is not editable and and not a layaway
* Refactored variables in updateCashUpInfo

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0107201)
hgbot   
2018-10-06 07:43   
Repository: tools/automation/pi-mobile
Changeset: 5a4a9627070b56bc0fa07e2fe740395c04ae47d0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Oct 06 11:12:45 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5a4a9627070b56bc0fa07e2fe740395c04ae47d0 [^]

Verifies issue 39397 : Added Automated Test 'I39397_VerifyCashupAmtOnReversePayment'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I39397_VerifyCashupAmtOnReversePayment.java
---
(0107346)
marvintm   
2018-10-16 18:02   
Fix is currently checking "isEditable", but this flag could be set for many reasons, and it should not be used for this check. Instead, 'isPaid' should be used, as this flag indicates that the receipt was loaded from the backend.
(0107620)
hgbot   
2018-10-26 12:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f9e76004c999e980fd7da73330cca1a6eea72341
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 26 16:14:27 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f9e76004c999e980fd7da73330cca1a6eea72341 [^]

Fixed issue 39397 : Cashup should not be updated if receipt is fully paid

* Reverted Payment method cashup changes from previos changeset

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0107621)
hgbot   
2018-10-26 12:45   
Repository: tools/automation/pi-mobile
Changeset: ed2fd77772f2840237037acfc1e6b9fa5fdad281
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 26 16:15:05 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ed2fd77772f2840237037acfc1e6b9fa5fdad281 [^]

Verifies issue 39397 : Modified Test 'I39397_VerifyCashupAmtOnReversePayment'

* Modified Test 'I35565_CashUpVerifyDeposit', to get the cashup id after ticket completed.
  Because cashup id will be generated in rebuildCashupfromServer before completing the ticket
* Modified Test 'CashupPartialRounding', Test was created due to wrong commit

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I35565_CashUpVerifyDeposit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I39397_VerifyCashupAmtOnReversePayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multichange/CashupPartialRounding.java
---