Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039390Retail ModulesCash uppublic2018-08-27 13:562018-10-18 13:04
ReporterLeyre 
Assigned Togorka_gil 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q2.4Fixed in VersionRR18Q2.4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039390: Incorrect grouping by ad_user_id in SQL of insert invoice headers in cash-up process
DescriptionThere is a difference in the grouping of insert invoice headers and insert invoice lines during the cash-up process.
Steps To ReproduceOrderGroupingProcessor_data.xsql:

The SQL of insert invoice header( grouping orders and no grouping orders), it is grouped by ad_user_id, unlike the SQL of insert invoice lines.

It may be caused by https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4effbcf40012566124172b75b2fc0a9c5ed6a893 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039191 closed gorka_gil Incorrect grouping by ad_user_id in SQL of insert invoice headers in cash-up process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-10-02 13:28marvintmTypedefect => backport
2018-10-02 13:28marvintmTarget Version => RR18Q2.4
2018-10-16 13:56gorka_gilNote Added: 0107335
2018-10-16 13:59gorka_gilFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6887f3de710760293d267067bc0039daa2669299 [^] => https://code.openbravo.com/retail/backports/3.0RR18Q2.4/org.openbravo.retail.posterminal/rev/49068666f0d01cddefc97e52047e41f1cc461920 [^]
2018-10-16 14:00gorka_gilStatusscheduled => resolved
2018-10-16 14:00gorka_gilResolutionopen => fixed
2018-10-18 13:04marvintmStatusresolved => closed
2018-10-18 13:04marvintmFixed in Version => RR18Q2.4

Notes
(0107335)
gorka_gil   
2018-10-16 13:56   
Repository: retail/backports/3.0RR18Q2.4/org.openbravo.retail.posterminal
Changeset: 49068666f0d01cddefc97e52047e41f1cc461920
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Sep 03 13:29:05 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.4/org.openbravo.retail.posterminal/rev/49068666f0d01cddefc97e52047e41f1cc461920 [^]

Fixes issue 39190 : fix the grouping for invoices generated in cashup process

Add ad_user_id to the grouping in missing sqls.

Add condition that ad_user of the invoice and the order is the same.

If ad_user null, used coalesce to set to '1', for compare since nulls can not be compared.
Note: Used '1' instead '', because oracle consired '' like a null and con not be compared neither.

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---