Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0039373Openbravo ERPB. User interfacepublic2018-09-28 11:222018-12-11 20:22
neil_smith 
AugustoMauch 
immediatemajoralways
closedfixed 
5
 
3.0PR19Q1 
caristu
Mozilla Firefox
User Interface Application
No
0039373: Quantities replaced by line number (only displayed in window, not in database)
When editing a record with a line number (orderline, inoviceline, inoutline), if the quantity is updated and click on the header (without changing field), the line numer is displayed in the updated quantity.
1. Go to the sales order window, double click on a sale order to go into form view
2. Double click on a sale order line to go in form view
3. Update the quantity on the sale order line and stay on field (no tab or clicking on another field)
4. Click in the sale order header

It saves the quantity and displays the line numer in the updated quantity.

If you change field (tab or click else where) or are not in form view on the header when you click on it, it does not do this.

If you refresh the data, it displays the quantity with what you entered, the information in the database is correct.

The problem is if you go back to the line and change something else and save, the wrong quantity is saved in the database!!!

For me, it does not work on the orders, shipments and invoices (sales and purchases). I didn't try other windows where there is a line number...

It has the same comportment in creation if the last field you enter is the quantity, don't change fields and click on the header (always in form view).

This is a big issue as the quantity can be saved wrong in certain conditions!
No tags attached.
depends on backport 00394123.0PR18Q4 closed AugustoMauch Quantities replaced by line numer (only displayed in window, not in database) 
depends on backport 00394133.0PR18Q3.2 closed AugustoMauch Quantities replaced by line numer (only displayed in window, not in database) 
depends on backport 00394143.0PR18Q2.3 closed AugustoMauch Quantities replaced by line numer (only displayed in window, not in database) 
Issue History
2018-09-28 11:22neil_smithNew Issue
2018-09-28 11:22neil_smithAssigned To => platform
2018-09-28 11:22neil_smithModules => User Interface Application
2018-09-28 11:22neil_smithTriggers an Emergency Pack => No
2018-09-28 11:31neil_smithNote Added: 0107064
2018-09-28 11:56alostaleNote Added: 0107067
2018-09-28 11:56alostaleStatusnew => feedback
2018-09-28 14:10neil_smithNote Added: 0107074
2018-10-01 10:03alostaleNote Added: 0107084
2018-10-03 08:03neil_smithNote Added: 0107127
2018-10-03 14:13neil_smithNote Added: 0107140
2018-10-05 08:15alostaleWeb browser => Mozilla Firefox
2018-10-05 08:15alostaleNote Added: 0107166
2018-10-05 08:15alostaleSeveritycritical => major
2018-10-05 08:15alostaleOS30 =>
2018-10-05 08:15alostaleOS VersionOpenbravo Appliance 14.04 =>
2018-10-05 08:15alostaleversion3.0PR17Q2.4 =>
2018-10-05 08:16alostaleWeb browserMozilla Firefox => Mozilla Firefox
2018-10-05 08:16alostaleOS0 => 5
2018-10-05 09:49alostaleStatusfeedback => new
2018-10-05 09:49alostaleStatusnew => acknowledged
2018-10-05 11:05neil_smithNote Added: 0107174
2018-10-05 11:36AugustoMauchStatusacknowledged => scheduled
2018-10-05 11:36AugustoMauchAssigned Toplatform => AugustoMauch
2018-10-05 11:36AugustoMauchWeb browserMozilla Firefox => Mozilla Firefox
2018-10-05 11:36AugustoMauchSummaryQuantities replaced by line numer (only displayed in window, not in database) => Quantities replaced by line number (only displayed in window, not in database)
2018-10-08 13:03hgbotCheckin
2018-10-08 13:03hgbotNote Added: 0107211
2018-10-08 13:03hgbotStatusscheduled => resolved
2018-10-08 13:03hgbotResolutionopen => fixed
2018-10-08 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/874862309622981d2104f74b4352cd8c9373c1eb [^]
2018-10-08 14:56AugustoMauchReview Assigned To => caristu
2018-10-08 14:56AugustoMauchWeb browserMozilla Firefox => Mozilla Firefox
2018-10-16 10:54caristuNote Added: 0107321
2018-10-16 10:54caristuStatusresolved => closed
2018-10-16 10:54caristuFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108422

Notes
(0107064)
neil_smith   
2018-09-28 11:31   
I hoticed that it takes the 1st field in the window and displays it in the quantity field.
With the orders, the line number is the first field, so it uses that one.
(0107067)
alostale   
2018-09-28 11:56   
I couldn't reproduce it nor in current developement branch nor in 17Q2.4.

Can you reproduce it here [1] (credentials: Openbravo/openbravo) which is a 172.4? If so it would be very helpful if you add more details to the steps to reproduce it and, if possible, to record a screencast reproducing it.

[1] https://livebuilds.openbravo.com/retail_mp_3.0RR17Q2.4 [^]
(0107074)
neil_smith   
2018-09-28 14:10   
I don't have access to the sales or purchase windows with that user
(0107084)
alostale   
2018-10-01 10:03   
Change role to Group Admin (it defaults to System Admin)
(0107127)
neil_smith   
2018-10-03 08:03   
I managed to reproduce it with the link you gave me, by following exactly the same steps as described...
I will upload a screencast later on.
(0107140)
neil_smith   
2018-10-03 14:13   
I can't upload the screencast as a joint file, so here is the link to get it from our cloud
https://cloud.d-factos.ch/s/Y33oibWrGwRF9kA [^]
You can download the file from there

Thanks for your time
Regards
(0107166)
alostale   
2018-10-05 08:15   
I can reproduce it in Firefox but I can't in Chrome.
(0107174)
neil_smith   
2018-10-05 11:05   
Same here, can't reproduce in Chrome.
We only use Firefox.
(0107211)
hgbot   
2018-10-08 13:03   
Repository: erp/devel/pi
Changeset: 874862309622981d2104f74b4352cd8c9373c1eb
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Oct 05 11:41:53 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/874862309622981d2104f74b4352cd8c9373c1eb [^]

Fixes issue 39373: Prevents unintended formitem value change if focus changes

There was a problem in this redraw function [1]. It did the following:
1) Get the value of the focused item (this.getFocusItem().getValue())
2) Redraw the form (this.Super('redraw', arguments);)
3) Restore the value of the focused item if the value changed during the redraw (this.getFocusItem().setElementValue(focusItemValue);)

The problem was that under some circumstances the focusedItem itself changed during the redraw, so the form items returned by this.getFocusItem()
in steps 1) and 3) are different, and the value from one form item was copied into another form item.

This problem has been fixed by storing in a variable the focused form item before the step 1), and the use that reference in the rest of the
function instead of reinvoking this.getFocusItem()

[1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js#l2157 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0107321)
caristu   
2018-10-16 10:54   
Code reviewed + tested OK.
(0108422)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test