Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039352Retail ModulesWeb POSpublic2018-09-25 17:482018-12-13 17:58
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket4459
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039352: Error using at the same time Cancel & Replace and Save Removed Ticket functionalities
DescriptionWhen Save Removed Ticket functionality is enabled, a receipt is created using Cancel and replace functionality, and a line is removed in the ticket, the ticket is stuck in Error While Importing window
Steps To Reproduce[BO]
. enable Web POS Save Removed Tickets functionality

[POS]
. create new ticket T1
. add new product P1
. complete ticket -> ticket is synced in BO
. load ticket T1 with Open Receipt functionality
. click in Cancel and Replace option -> new ticket is created T1-1
. add new product P2
. delete product P2
. delete ticket T1-1

[BO]
. go to Error While Importing window -> ticket T1-1 is in this window with error:
org.openbravo.base.exception.OBException: Error in OrderLoader: null
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:534)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:200)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:154)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:86)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:53)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:59)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:367)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:288)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:465)
    ... 12 more

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0039801RR18Q4.1 closed ranjith_qualiantech_com Error using at the same time Cancel & Replace and Save Removed Ticket functionalities 
depends on backport 0039802RR18Q3.4 closed ranjith_qualiantech_com Error using at the same time Cancel & Replace and Save Removed Ticket functionalities 
Attached Filespatch issue 39352 source posterminal.patch (2,514) 2018-10-01 08:00
https://issues.openbravo.com/file_download.php?file_id=12199&type=bug
patch issue 39352 test.patch (5,840) 2018-10-01 08:00
https://issues.openbravo.com/file_download.php?file_id=12200&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-09-25 17:48malsasuaNew Issue
2018-09-25 17:48malsasuaAssigned To => Retail
2018-09-25 17:48malsasuaOBNetwork customer => Yes
2018-09-25 17:48malsasuaSupport ticket => 4459
2018-09-25 17:48malsasuaResolution time => 1539813600
2018-09-25 17:48malsasuaTriggers an Emergency Pack => No
2018-09-26 10:21ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-09-26 10:22ranjith_qualiantech_comStatusnew => scheduled
2018-10-01 08:00ranjith_qualiantech_comFile Added: issue 39352 source posterminal.patch
2018-10-01 08:00ranjith_qualiantech_comFile Added: issue 39352 test.patch
2018-10-05 13:05hgbotCheckin
2018-10-05 13:05hgbotNote Added: 0107177
2018-10-05 13:05hgbotStatusscheduled => resolved
2018-10-05 13:05hgbotResolutionopen => fixed
2018-10-05 13:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e81317f98de8f93ade73734f15864d98e11473f [^]
2018-10-05 13:05hgbotCheckin
2018-10-05 13:05hgbotNote Added: 0107178
2018-10-16 13:59marvintmReview Assigned To => marvintm
2018-10-16 13:59marvintmStatusresolved => closed
2018-10-16 13:59marvintmFixed in Version => RR19Q1
2018-12-13 17:57marvintmStatusclosed => new
2018-12-13 17:57marvintmResolutionfixed => open
2018-12-13 17:57marvintmFixed in VersionRR19Q1 =>
2018-12-13 17:58marvintmStatusnew => scheduled
2018-12-13 17:58marvintmStatusscheduled => resolved
2018-12-13 17:58marvintmFixed in Version => RR19Q1
2018-12-13 17:58marvintmResolutionopen => fixed
2018-12-13 17:58marvintmStatusresolved => closed

Notes
(0107177)
hgbot   
2018-10-05 13:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e81317f98de8f93ade73734f15864d98e11473f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 05 16:35:21 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e81317f98de8f93ade73734f15864d98e11473f [^]

Fixed issue 39352 : Cashup ID should be updated for Cancelled Order from json data instead of cashup info

* JSON data should not be updated while savng record in OrderLoader
* JSON data Orderlines should not be updated with deletedLines
  because if any error occurs jsondata will be saved to db which have duplicate records of deletedLine in lines data.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0107178)
hgbot   
2018-10-05 13:05   
Repository: tools/automation/pi-mobile
Changeset: 18dc51c17de31d84c9345680d2182331760aa3bf
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 05 16:35:11 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/18dc51c17de31d84c9345680d2182331760aa3bf [^]

Verifies issue 39352 : Added Automated Test 'I39352_VerifyCancelReplaceWithSaveRemovePref'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I39352_VerifyCancelReplaceWithSaveRemovePref.java
---