Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039337Retail ModulesWeb POSpublic2018-06-29 09:252018-10-19 11:55
Reportermarvintm 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q3.2Fixed in VersionRR18Q3.2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039337: Ticket completion should be executed fully inside the same database transaction
DescriptionAfter related issue https://issues.openbravo.com/view.php?id=38676 [^] some changes have been done to try to execute the whole ticket synchronization process in the same database transaction. However, there is one part which is still missing: the hook execution and the last save for the ticket which sets it to hasbeenpaid='Y' should also be part of the same database transaction, and currently they are not.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038862 closed migueldejuana Ticket completion should be executed fully inside the same database transaction 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-21 11:57marvintmTypedefect => backport
2018-09-21 11:57marvintmTarget Version => RR18Q3.2
2018-10-04 11:53hgbotCheckin
2018-10-04 11:53hgbotNote Added: 0107154
2018-10-04 11:54hgbotStatusscheduled => resolved
2018-10-04 11:54hgbotResolutionopen => fixed
2018-10-04 11:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3ae464ccea7b7727300427f943a50fdd8c3c091 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal/rev/7c8432ffa8f36008850227738e63c468f3e33b6b [^]
2018-10-19 09:57marvintmReview Assigned To => marvintm
2018-10-19 09:57marvintmStatusresolved => closed
2018-10-19 09:57marvintmFixed in Version => RR18Q3.2

Notes
(0107154)
hgbot   
2018-10-04 11:53   
Repository: retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal
Changeset: 7c8432ffa8f36008850227738e63c468f3e33b6b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 04 11:52:33 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal/rev/7c8432ffa8f36008850227738e63c468f3e33b6b [^]

Fixed issue 0039337: Ticket completion should be executed fully inside the same database transaction

- Send transaction to OBPOS_PreSyncReceipt hook to be able to use it
- Add a new hook better to avoid wrong implementations from other modules

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---