Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039335Openbravo ERP02. Master data managementpublic2018-09-21 10:422018-12-11 20:22
Reporterjoniturralde93 
Assigned Tononofrancisco 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039335: It is possible to chose an account which does not belong to the General Ledger (G/L Item window)
DescriptionG/L Item window, Accounting tab:

It is possible to create a record with a General Ledger, select his accounts and then switch the General Ledger, resulting in a wrong combination of General Ledger and accounts. It can be saved like that. Happens both in form and new row.
Steps To Reproduce1. Log into live builds, G/L Item window and select Organization: '*'
2. Create a new record in the Accounting tab and select General Ledger: 'F&B España, S.A. US/A/Euro'
3. Select both Glitem debit acct and Glitem credit acct: '10000 - Capital social'
4. Now, without saving before, change General Ledger to 'F&B International Group US/A/US Dollar', and then save the record. You shouldn't be allowed to do that, since that account doesn't belong to that General Ledger.
5. Open the record in form view and click on the Glitem debit acct link to open it in another tab. It is shown at the top of the window that '10000 - Capital social' belongs to 'F&B España, S.A. US/A/Euro'
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-21 10:42joniturralde93New Issue
2018-09-21 10:42joniturralde93Assigned To => Triage Finance
2018-09-21 10:42joniturralde93Modules => Core
2018-09-21 10:42joniturralde93Resolution time => 1539295200
2018-09-21 10:42joniturralde93Triggers an Emergency Pack => No
2018-09-27 12:07SandrahuguetAssigned ToTriage Finance => nonofrancisco
2018-09-28 08:54vmromanosStatusnew => scheduled
2018-09-28 18:55nonofranciscoNote Added: 0107077
2018-10-03 12:20hgbotCheckin
2018-10-03 12:20hgbotNote Added: 0107132
2018-10-03 12:20hgbotStatusscheduled => resolved
2018-10-03 12:20hgbotResolutionopen => fixed
2018-10-03 12:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5170d62ca42fad2a12f746e24e7c292875e638c8 [^]
2018-10-03 12:21SandrahuguetReview Assigned To => Sandrahuguet
2018-10-03 12:21SandrahuguetNote Added: 0107133
2018-10-03 12:21SandrahuguetStatusresolved => closed
2018-10-03 12:21SandrahuguetFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108416

Notes
(0107077)
nonofrancisco   
2018-09-28 18:55   
Test Plan

Log as F&B International Group Admin
Open G/L Item window and select Organization: '*'
Create a new record in the Accounting tab and select General Ledger: 'F&B España, S.A. US/A/Euro'
Select both Glitem debit acct and Glitem credit acct: '10000 - Capital social'
Now, without saving before, change General Ledger to 'F&B International Group US/A/US Dollar'.
Notice the G/L Item credit and debit amount fields are reset. Opening the selectors in those fields shows accounts that belongs to 'F&B International Group US/A/US Dollar' General Ledger
(0107132)
hgbot   
2018-10-03 12:20   
Repository: erp/devel/pi
Changeset: 5170d62ca42fad2a12f746e24e7c292875e638c8
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 03 10:21:31 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5170d62ca42fad2a12f746e24e7c292875e638c8 [^]

Fixes issue 39335: Wrong combination of General Ledger and accounts

* A new Event Observer was created to check, on save, if Debit and Credit
  accounts belongs to the selected Accounting Schema.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/event/GLItemAccountsEventHandler.java
---
(0107133)
Sandrahuguet   
2018-10-03 12:21   
Code review + testing OK
(0108416)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test