Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039333Openbravo ERP02. Master data managementpublic2018-09-20 20:252018-09-25 14:16
Reportermarkmm82 
Assigned Tomarkmm82 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039333: When an order line related to discount is created it uses the system date as ordered date instead of the header's ordered date
DescriptionWhen an order line related to discount is created it uses the system date as the ordered date instead of the header's ordered date.
Steps To ReproduceAs Group Admin:
  Create a new sales order with an order date before than today, for example
  18/09/2018 if today is 20/09/2018.
  Add a new line to it with any product.
  Be sure it is a basic discount applying to the order.
  Book the order and set it is as immediately invoiced.
  Notice that a new line is created related to the discount.

  Create a new sales invoice for the same bp than the created order.
  Execute the Create Lines From Order process.
  Notice that the two lines related to the created order are there.
  The line related to the product is showing as the Order date the same than it order (for example 18/09/2018)
  The line related to the discount is showing Today (for example 20/09/2018) as the Order date. It is wrong, it should be the same than its order (for example 18/09/2018).

   Verify that the same problem happens if the order date is aftr the current date.
Proposed SolutionThe ordered date to the lines related to discounts should be the same than the order.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-20 20:25markmm82New Issue
2018-09-20 20:25markmm82Assigned To => markmm82
2018-09-20 20:25markmm82Modules => Core
2018-09-20 20:25markmm82Triggers an Emergency Pack => No
2018-09-20 20:25markmm82Statusnew => scheduled
2018-09-20 20:34markmm82Note Added: 0106910
2018-09-24 15:17hgbotCheckin
2018-09-24 15:17hgbotNote Added: 0106968
2018-09-24 15:17hgbotStatusscheduled => resolved
2018-09-24 15:17hgbotResolutionopen => fixed
2018-09-24 15:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/18826c3cd89bfe4507950816219163e4d48613f2 [^]
2018-09-24 15:18SandrahuguetReview Assigned To => Sandrahuguet
2018-09-24 15:18SandrahuguetNote Added: 0106969
2018-09-24 15:18SandrahuguetStatusresolved => closed
2018-09-25 14:16hudsonbotCheckin
2018-09-25 14:16hudsonbotNote Added: 0107017

Notes
(0106910)
markmm82   
2018-09-20 20:34   
Test Plan:
As Group Admin:
  Create a new sales order with an order date before than today, for example
  18/09/2018 if today is 20/09/2018.
  Add a new line to it with any product.
  Be sure it is a basic discount applying to the order.
  Book the order and set it is as immediately invoiced.
  Notice that a new line is created related to the discount.

  Create a new sales invoice for the same bp than the created order.
  Execute the Create Lines From Order process.
  Notice that the two lines related to the created order are there.
  The line related to the product is showing as the Order date the same than it order (for example 18/09/2018)
  The line related to the discount is showing as the Order date the same than it order (for example 18/09/2018)
(0106968)
hgbot   
2018-09-24 15:17   
Repository: erp/devel/pi
Changeset: 18826c3cd89bfe4507950816219163e4d48613f2
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Sep 20 14:31:38 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/18826c3cd89bfe4507950816219163e4d48613f2 [^]

Fixed issue 39333: Use the order date instead of system date when order lines
related to discounts are created.

When an order line related to a discount was created it was using the system date
as it ordered date instead of the header's ordered date. Now it is set the ordered
date of the header as it ordered date.

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0106969)
Sandrahuguet   
2018-09-24 15:18   
Code review + testing OK
(0107017)
hudsonbot   
2018-09-25 14:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c4e1d4ba022d [^]
Maturity status: Test