Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039305Openbravo ERP02. Master data managementpublic2018-09-17 16:332018-10-01 11:36
ReporterJONHM 
Assigned ToAtulOpenbravo 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket4643
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039305: Performance issue in c_bpartner_trg on environment with lots of data
DescriptionThere is a performance issue in c_bpartner_trg on environment with lots of data when changing a BP's price list.
Steps To ReproduceAsk environment to Support:

- Open Business Partner window and select 'CLIENTE MOSTRADOR' BP
- Change it's price list on the selector and save the record

it takes 15517.787 ms to save the record.
Proposed SolutionMost of the time is spent on the following query:

SELECT MAX(p.c_currency_id)
INTO v_currency_credit
FROM fin_payment p
WHERE p.c_bpartner_id = new.C_BPartner_ID
AND p.generated_credit <> 0
AND p.generated_credit-COALESCE(p.used_credit, 0) <> 0;
Additional Information
TagsPerformance
Relationships
depends on backport 00393783.0PR18Q3.2 closed AtulOpenbravo Performance issue in c_bpartner_trg on environment with lots of data 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-17 16:33JONHMNew Issue
2018-09-17 16:33JONHMAssigned To => Triage Finance
2018-09-17 16:33JONHMOBNetwork customer => Yes
2018-09-17 16:33JONHMModules => Core
2018-09-17 16:33JONHMSupport ticket => 4643
2018-09-17 16:33JONHMResolution time => 1538949600
2018-09-17 16:33JONHMTriggers an Emergency Pack => No
2018-09-17 17:27SandrahuguetTag Attached: Performance
2018-09-17 17:47SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-09-26 12:29AtulOpenbravoStatusnew => scheduled
2018-09-28 10:16hgbotCheckin
2018-09-28 10:16hgbotNote Added: 0107062
2018-09-28 10:16hgbotStatusscheduled => resolved
2018-09-28 10:16hgbotResolutionopen => fixed
2018-09-28 10:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/463468c986a3dd39e77c69f159477422f311ebe1 [^]
2018-09-28 10:20SandrahuguetReview Assigned To => Sandrahuguet
2018-09-28 10:20SandrahuguetNote Added: 0107063
2018-09-28 10:20SandrahuguetStatusresolved => closed
2018-09-28 10:20SandrahuguetFixed in Version => 3.0PR18Q4
2018-09-28 12:58SandrahuguetStatusclosed => new
2018-09-28 12:58SandrahuguetResolutionfixed => open
2018-09-28 12:58SandrahuguetFixed in Version3.0PR18Q4 =>
2018-09-28 12:58SandrahuguetStatusnew => scheduled
2018-09-28 12:58SandrahuguetStatusscheduled => resolved
2018-09-28 12:58SandrahuguetResolutionopen => fixed
2018-09-28 12:58SandrahuguetStatusresolved => closed
2018-10-01 11:36hudsonbotCheckin
2018-10-01 11:36hudsonbotNote Added: 0107085

Notes
(0107062)
hgbot   
2018-09-28 10:16   
Repository: erp/devel/pi
Changeset: 463468c986a3dd39e77c69f159477422f311ebe1
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Sep 27 00:00:16 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/463468c986a3dd39e77c69f159477422f311ebe1 [^]

Fixes Issue 39305:Performance issue in c_bpartner_trg on environment
with lots of data

** Made use of fin_payment_bpartner_credit index in query
to fetch curreny of the generated credit not yet consumed
in c_bpartner_trg.

---
M src-db/database/model/triggers/C_BPARTNER_TRG.xml
---
(0107063)
Sandrahuguet   
2018-09-28 10:20   
Code review + testing OK
(0107085)
hudsonbot   
2018-10-01 11:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c83c34c74ee4 [^]
Maturity status: Test