Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039302Retail ModulesWeb POSpublic2018-09-13 12:182018-09-19 10:47
Reporterumartirena 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q3.1Fixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket4654
Regression level
Regression date
Regression introduced in releaseRR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e73d22ce9ce0622108a2352f416522690a6cc85 [^]
Triggers an Emergency PackNo
Summary0039302: callback property coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden
Descriptioncallback coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden.
Steps To ReproduceImplement 'OBPOS_preAddPayment' hook and set a function in args.callback property. Check that the callback function is not called in this instruction:

if (args.callback instanceof Function) {
    args.callback(order);
}
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039282 closed ranjith_qualiantech_com callback property coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-17 15:44jorge-garciaTypedefect => backport
2018-09-17 15:44jorge-garciaTarget Version => RR18Q3.1
2018-09-19 07:50hgbotCheckin
2018-09-19 07:50hgbotNote Added: 0106849
2018-09-19 07:50hgbotStatusscheduled => resolved
2018-09-19 07:50hgbotResolutionopen => fixed
2018-09-19 07:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/753d77119c8c597ebd9aa26b15e24325eeba1407 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.1/org.openbravo.retail.posterminal/rev/3d480c9bf180fea9f1d8e1131dcaec3ab5052612 [^]
2018-09-19 10:47marvintmReview Assigned To => marvintm
2018-09-19 10:47marvintmStatusresolved => closed
2018-09-19 10:47marvintmFixed in Version => RR18Q4

Notes
(0106849)
hgbot   
2018-09-19 07:50   
Repository: retail/backports/3.0RR18Q3.1/org.openbravo.retail.posterminal
Changeset: 3d480c9bf180fea9f1d8e1131dcaec3ab5052612
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 19 11:19:54 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.1/org.openbravo.retail.posterminal/rev/3d480c9bf180fea9f1d8e1131dcaec3ab5052612 [^]

Fixed issue 39302 : Removed callback argument in PrePayment hook and postPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---