Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039290Openbravo ERP09. Financial managementpublic2018-09-13 20:272018-11-07 08:55
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-04-03
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f7078a85289e6c61918f567b28d2df3fe17ddb47 [^]
Triggers an Emergency PackNo
Summary0039290: Business Partner current balance is wrongly updated when using Reconciliation
DescriptionBusiness Partner current balance is wrongly updated when using Reconciliation
Steps To ReproduceTest Plan

   - Login as F&B International Group admin role
   - Create a new Business Partner in F&B International Group
   - Create a Payment In for F&B España, S.A. and that business partner
   - Add an amount 100 and do not select any document to be paid. Leave the amount as credit
   - Check the payment has been deposited in a financial account.
   - Check that business partner current balance is set as -100.
   
  - Go to Financial Account where the payment was deposited.
  - Either leave the Matching Algorithm empty or keep it as Standard
  - Click on Reconcile or Match Statement button
  - Select the previously created payment or match the previous payment with similar record in bank statement.
  - Again check the current balance of business partner now it is set as -200.

This is not correct.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039126 closed Sandrahuguet Reconciliation without lines is created if the role does not have access to business partner's organization of the payment 
depends on backport 00393413.0PR18Q3.2 closed AtulOpenbravo Business Partner current balance is wrongly updated when using Reconciliation 
depends on backport 00393423.0PR18Q2.3 closed AtulOpenbravo Business Partner current balance is wrongly updated when using Reconciliation 
caused by feature request 0025696 closed Sandrahuguet Add invoice paid status control funcionality 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-13 20:27AtulOpenbravoNew Issue
2018-09-13 20:27AtulOpenbravoAssigned To => Triage Finance
2018-09-13 20:27AtulOpenbravoModules => Core
2018-09-13 20:27AtulOpenbravoTriggers an Emergency Pack => No
2018-09-13 20:28AtulOpenbravoRelationship addedrelated to 0039126
2018-09-19 10:39AtulOpenbravoRegression level => Production - Confirmed Stable
2018-09-19 10:39AtulOpenbravoRegression date => 2014-04-03
2018-09-19 10:39AtulOpenbravoRegression introduced in release => 3.0PR14Q2
2018-09-19 10:39AtulOpenbravoRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f7078a85289e6c61918f567b28d2df3fe17ddb47 [^]
2018-09-19 10:40AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2018-09-24 11:58AtulOpenbravoStatusnew => scheduled
2018-09-25 05:59AtulOpenbravoNote Added: 0106977
2018-09-25 06:08AtulOpenbravoNote Added: 0106980
2018-09-25 06:21AtulOpenbravoNote Edited: 0106980bug_revision_view_page.php?bugnote_id=0106980#r17669
2018-09-25 06:29AtulOpenbravoNote Added: 0106983
2018-09-25 06:37AtulOpenbravoNote Added: 0106984
2018-09-25 06:44AtulOpenbravoNote Added: 0106985
2018-09-25 06:59AtulOpenbravoNote Edited: 0106983bug_revision_view_page.php?bugnote_id=0106983#r17675
2018-09-25 06:59AtulOpenbravoNote Edited: 0106983bug_revision_view_page.php?bugnote_id=0106983#r17676
2018-09-25 06:59AtulOpenbravoNote Edited: 0106984bug_revision_view_page.php?bugnote_id=0106984#r17678
2018-09-25 06:59AtulOpenbravoNote Edited: 0106985bug_revision_view_page.php?bugnote_id=0106985#r17680
2018-09-25 10:53dmitry_mezentsevRelationship addedcaused by 0025696
2018-09-26 15:40hgbotCheckin
2018-09-26 15:40hgbotNote Added: 0107038
2018-09-26 15:40hgbotStatusscheduled => resolved
2018-09-26 15:40hgbotResolutionopen => fixed
2018-09-26 15:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/831c2aadbee3da84b3d1ba3b34ef5c906efe9978 [^]
2018-09-26 15:42SandrahuguetReview Assigned To => Sandrahuguet
2018-09-26 15:42SandrahuguetNote Added: 0107039
2018-09-26 15:42SandrahuguetStatusresolved => closed
2018-09-26 15:42SandrahuguetFixed in Version => 3.0PR18Q4
2018-09-26 19:47hudsonbotCheckin
2018-09-26 19:47hudsonbotNote Added: 0107043
2018-11-07 08:55SandrahuguetNote Added: 0107774

Notes
(0106977)
AtulOpenbravo   
2018-09-25 05:59   
Test Plan

   - Login as F&B International Group admin role
   - Create a new Business Partner in F&B International Group
   - Create a Payment In for F&B España, S.A. and that business partner
   - Add an amount 100 and do not select any document to be paid. Leave the amount as credit
   - Check the payment has been deposited in a financial account.
   - Check that business partner current balance is set as -100.
   
  - Go to Financial Account where the payment was deposited.
  - Either leave the Matching Algorithm empty or keep it as Standard
  - Click on Reconcile or Match Statement button
  - Select the previously created payment or match the previous payment with similar record in bank statement.
  - Again check the current balance of business partner it is as it is -100.
(0106980)
AtulOpenbravo   
2018-09-25 06:08   
(edited on: 2018-09-25 06:21)
Test Plan

- Login as F&B International Group Admin
- Go to Financial Account and select Bank - Account 1
- Navigate to Payment Method: Wire Transfer
  Uncheck Automatic Deposit and Automatic Withdrawn Go to Sales Invoice
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10
   Product: Orange Juice bio, Quantity: 5
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is Yes.
- Check business partner balance is set as 0.
(0106983)
AtulOpenbravo   
2018-09-25 06:29   
(edited on: 2018-09-25 06:59)
Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Payment Received,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Payment Made
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10
   Product: Orange Juice bio, Quantity: 5
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is Yes.
- Check business partner balance is set as 0.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 0.

Similar test plan executed for purchase flow.
(0106984)
AtulOpenbravo   
2018-09-25 06:37   
(edited on: 2018-09-25 06:59)
Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Deposited Not Cleared,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Withdrawan Not Cleared
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10, Tax = Exempt
   Product: Orange Juice bio, Quantity: 5, Tax: Exempt
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is set as No.
- Check business partner balance is set as 15.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- Check Payment Complete in previous Sales Invoice header is set as Yes.
- Reactivate previous financial Account Transaction.
- Check business partner balance is set as 15.
- Check Payment Complete in previous Sales Invoice header is set as No.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- Check Payment Complete in previous Sales Invoice header is set as Yes.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 0.

Similar test plan executed for purchase flow.
(0106985)
AtulOpenbravo   
2018-09-25 06:44   
(edited on: 2018-09-25 06:59)
Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Payment Cleared,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Payment Cleared
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10, Tax = Exempt
   Product: Orange Juice bio, Quantity: 5, Tax: Exempt
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is set as No.
- Check business partner balance is set as 15.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 15.
- Check Payment Complete in previous Sales Invoice header is set as No.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Check that Payment Complete flag in previous Sales Invoice is set as Yes.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 15.
- Check that Payment Complete flag in previous Sales Invoice is set as No.

Similar test plan executed for purchase flow.
(0107038)
hgbot   
2018-09-26 15:40   
Repository: erp/devel/pi
Changeset: 831c2aadbee3da84b3d1ba3b34ef5c906efe9978
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Sep 25 00:35:58 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/831c2aadbee3da84b3d1ba3b34ef5c906efe9978 [^]

Fixes Issue 39290: Business Partner current balance is wrongly
updated when using Reconciliation

** In case of prepayment invoice paid should be kept as false
in PaidStatusEventHandler.

---
M src/org/openbravo/event/PaidStatusEventHandler.java
---
(0107039)
Sandrahuguet   
2018-09-26 15:42   
code review + testing OK
(0107043)
hudsonbot   
2018-09-26 19:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/95141753a1f0 [^]
Maturity status: Test
(0107774)
Sandrahuguet   
2018-11-07 08:55   
Test case created in testlink https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-11013 [^]