Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039282Retail ModulesWeb POSpublic2018-09-13 12:182018-09-21 17:58
Reporterumartirena 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e73d22ce9ce0622108a2352f416522690a6cc85 [^]
Triggers an Emergency PackNo
Summary0039282: callback property coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden
Descriptioncallback coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden.
Steps To ReproduceImplement 'OBPOS_preAddPayment' hook and set a function in args.callback property. Check that the callback function is not called in this instruction:

if (args.callback instanceof Function) {
    args.callback(order);
}
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0039302RR18Q3.1 closed ranjith_qualiantech_com callback property coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden 
depends on backport 0039310RR18Q2.3 closed ranjith_qualiantech_com callback property coming in args from OBPOS_preAddPayment hook is not any more executed because it is overriden 
caused by feature request 0037888 closed jorgewederago Add a hook to be executed after adding a payment to the order 
Attached Filespatch issue 39282 source posterminal.patch (3,253) 2018-09-18 12:17
https://issues.openbravo.com/file_download.php?file_id=12150&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-09-13 12:18umartirenaNew Issue
2018-09-13 12:18umartirenaAssigned To => Retail
2018-09-13 12:18umartirenaRegression introduced in release => RR18Q2
2018-09-13 12:18umartirenaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e73d22ce9ce0622108a2352f416522690a6cc85 [^]
2018-09-13 12:18umartirenaTriggers an Emergency Pack => No
2018-09-13 13:13martinsdanIssue Monitored: martinsdan
2018-09-13 14:51ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-09-13 14:51ranjith_qualiantech_comStatusnew => scheduled
2018-09-14 09:52egoitzResolution time => 1537221600
2018-09-14 09:53egoitzPriorityurgent => immediate
2018-09-14 10:41ngarciaIssue Monitored: ngarcia
2018-09-17 08:12hgbotCheckin
2018-09-17 08:12hgbotNote Added: 0106791
2018-09-17 08:12hgbotStatusscheduled => resolved
2018-09-17 08:12hgbotResolutionopen => fixed
2018-09-17 08:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/753d77119c8c597ebd9aa26b15e24325eeba1407 [^]
2018-09-17 15:44jorge-garciaNote Added: 0106807
2018-09-17 15:44jorge-garciaStatusresolved => new
2018-09-17 15:44jorge-garciaResolutionfixed => open
2018-09-17 15:44jorge-garciaStatusnew => scheduled
2018-09-17 15:44jorge-garciaStatusscheduled => resolved
2018-09-17 15:44jorge-garciaResolutionopen => fixed
2018-09-18 09:03hgbotCheckin
2018-09-18 09:03hgbotNote Added: 0106821
2018-09-18 09:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/753d77119c8c597ebd9aa26b15e24325eeba1407 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/512091b08f7e4c18cf1785d5d7386d64dd797bb4 [^]
2018-09-18 09:52marvintmStatusresolved => new
2018-09-18 09:52marvintmResolutionfixed => open
2018-09-18 09:52marvintmStatusnew => scheduled
2018-09-18 09:52marvintmStatusscheduled => resolved
2018-09-18 09:52marvintmFixed in Version => RR18Q4
2018-09-18 09:52marvintmResolutionopen => fixed
2018-09-18 12:17ranjith_qualiantech_comFile Added: issue 39282 source posterminal.patch
2018-09-18 15:40hgbotCheckin
2018-09-18 15:40hgbotNote Added: 0106839
2018-09-18 15:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/512091b08f7e4c18cf1785d5d7386d64dd797bb4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c1432b08317a239fe457834bf9353b1ae4fb5aa2 [^]
2018-09-19 10:47marvintmReview Assigned To => marvintm
2018-09-19 10:47marvintmStatusresolved => closed
2018-09-20 18:35dmitry_mezentsevRelationship addedcaused by 0037888
2018-09-21 17:58dmitry_mezentsevRegression level => Production - Confirmed Stable

Notes
(0106791)
hgbot   
2018-09-17 08:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 753d77119c8c597ebd9aa26b15e24325eeba1407
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Sep 17 11:42:07 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/753d77119c8c597ebd9aa26b15e24325eeba1407 [^]

Fixed issue 39282 : Removed callback property of PrePayment hook in PostAddPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0106807)
jorge-garcia   
2018-09-17 15:44   
Reopened to create backport
(0106821)
hgbot   
2018-09-18 09:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 512091b08f7e4c18cf1785d5d7386d64dd797bb4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Sep 18 12:32:58 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/512091b08f7e4c18cf1785d5d7386d64dd797bb4 [^]

Fixed issue 39282 : Removed callback property of PrePayment hook in PostAddPayment hook

* Removed callback property in MultiOrder addPayment function

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0106839)
hgbot   
2018-09-18 15:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c1432b08317a239fe457834bf9353b1ae4fb5aa2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Sep 18 18:55:04 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c1432b08317a239fe457834bf9353b1ae4fb5aa2 [^]

Fixed issue 39282 : Removed callback argument in PrePayment hook and postPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---