Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039265Retail ModulesWeb POSpublic2018-09-11 16:152018-12-19 17:53
Reportercaristu 
Assigned TojavierRodriguez 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039265: Add a method in ExternalOrderLoader to transform and process orders in a synchronous way
DescriptionIt would be nice to have a method in the ExternalOrderLoader to process orders in a synchronous way. Ideally this method would perform the following tasks:

1- Transform a JSONObject received as parameter, adding/completing the required information.
2- Creates/Process the order
3- Returns information with the result of the process, including error information in case there were errors during the process.
Steps To ReproduceIn description
Proposed SolutionSee:

https://code.openbravo.com/erp/pmods/org.openbravo.service.integration.magento.mappings/file/tip/src/org/openbravo/service/integration/magento/mappings/inbound/orders/MagentoExternalOrderLoader.java [^]

Note that the idea is to replace this class once this issue is fixed.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-11 16:15caristuNew Issue
2018-09-11 16:15caristuAssigned To => Retail
2018-09-11 16:15caristuTriggers an Emergency Pack => No
2018-11-07 17:38aferrazNote Added: 0107782
2018-11-13 14:03caristuProposed Solution updated
2018-11-30 09:22hgbotCheckin
2018-11-30 09:22hgbotNote Added: 0108172
2018-11-30 09:22hgbotStatusnew => resolved
2018-11-30 09:22hgbotResolutionopen => fixed
2018-11-30 09:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96b159bdd3a4c8196e3136bc60d92dc83942855b [^]
2018-12-04 11:14hgbotCheckin
2018-12-04 11:14hgbotNote Added: 0108245
2018-12-04 11:18hgbotCheckin
2018-12-04 11:18hgbotNote Added: 0108246
2018-12-05 23:41hgbotCheckin
2018-12-05 23:41hgbotNote Added: 0108308
2018-12-13 11:55marvintmAssigned ToRetail => javierRodriguez
2018-12-13 15:01marvintmReview Assigned To => marvintm
2018-12-13 15:01marvintmStatusresolved => closed
2018-12-13 15:01marvintmFixed in Version => RR19Q1
2018-12-19 11:03aferrazStatusclosed => new
2018-12-19 11:03aferrazResolutionfixed => open
2018-12-19 11:03aferrazFixed in VersionRR19Q1 =>
2018-12-19 11:04aferrazStatusnew => scheduled
2018-12-19 11:05aferrazStatusscheduled => resolved
2018-12-19 11:05aferrazResolutionopen => fixed
2018-12-19 11:05hgbotCheckin
2018-12-19 11:05hgbotNote Added: 0108670
2018-12-19 17:53marvintmStatusresolved => closed
2018-12-19 17:53marvintmFixed in Version => RR19Q1

Notes
(0107782)
aferraz   
2018-11-07 17:38   
Check also ExternalOrderLoader.isSynchronizedRequest() method. Right now it is raising a NPE because RequestContext.get().getRequest() is null.
(0108172)
hgbot   
2018-11-30 09:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 96b159bdd3a4c8196e3136bc60d92dc83942855b
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Mon Nov 26 16:46:32 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96b159bdd3a4c8196e3136bc60d92dc83942855b [^]

Fixed issue 39265: Add a method in ExternalOrderLoader to transform and process orders in a synchronous way

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0108245)
hgbot   
2018-12-04 11:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 55a01f329e642e4c08be103525eba6603fcffe24
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Dec 04 11:11:11 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/55a01f329e642e4c08be103525eba6603fcffe24 [^]

Related to issue 39265: fixed db consistency

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0108246)
hgbot   
2018-12-04 11:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cf84f1535b309010f25052182e9aba972b485d02
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Dec 04 11:17:51 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf84f1535b309010f25052182e9aba972b485d02 [^]

Related to issue 39265

---
M src/org/openbravo/retail/posterminal/PaidReceiptsFilter.java
---
(0108308)
hgbot   
2018-12-05 23:41   
Repository: erp/pmods/org.openbravo.service.integration.magento.mappings
Changeset: d554bb1089c075af309d9ae63f0d84a6b8531e5c
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Dec 05 14:31:21 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.magento.mappings/rev/d554bb1089c075af309d9ae63f0d84a6b8531e5c [^]

Related to issue 39265:Removed temporary class MagentoExternalOrderLoader

The MagentoExternalOrderLoader was removed and the code was updated with
ExternalOrderLoader

---
M src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderImporter.java
R src/org/openbravo/service/integration/magento/mappings/inbound/orders/MagentoExternalOrderLoader.java
---
(0108670)
hgbot   
2018-12-19 11:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d8e90343f30e041dfb350b8045fdde79006b1589
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 19 11:04:31 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d8e90343f30e041dfb350b8045fdde79006b1589 [^]

Related to issue 39265: Avoid NPE in ExternalOrderLoader.successMessage() when processedOrders.get() is null

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---