Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039261Openbravo ERPA. Platformpublic2018-09-11 09:442018-09-25 20:57
ReporterJONHM 
Assigned Tojarmendariz 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039261: connection leak when printing image on subreports using the Utility.showImageLogo method
DescriptionIf you create a report that prints an image on the subreport using the method org.openbravo.erpCommon.utility.Utility.showImageLogo the connections are not closed. It is kept with 'idle in transaction' status.
Steps To ReproduceThe problem is the same as in issue 36697. The method could be overloaded using the 'doCommit' boolean, as in the other changeset.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036697 closed caristu connection leak when printing a image on a jasper subreport using the Utility.showImage method 
related to design defect 0030182 closed Triage Platform Base jasper subreports using DAL do leak connection + transactions 
causes defect 0048465 closed caristu Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 
Attached Filespatch issue-39261.patch (5,821) 2018-09-12 19:13
https://issues.openbravo.com/file_download.php?file_id=12130&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-09-11 09:44JONHMNew Issue
2018-09-11 09:44JONHMAssigned To => platform
2018-09-11 09:44JONHMModules => Core
2018-09-11 09:44JONHMResolution time => 1538431200
2018-09-11 09:44JONHMTriggers an Emergency Pack => No
2018-09-11 09:44JONHMRelationship addedrelated to 0036697
2018-09-11 10:09jfrancesIssue Monitored: jfrances
2018-09-12 14:07jarmendarizAssigned Toplatform => jarmendariz
2018-09-12 18:35jarmendarizStatusnew => scheduled
2018-09-12 19:13jarmendarizFile Added: issue-39261.patch
2018-09-21 09:24jarmendarizReview Assigned To => caristu
2018-09-21 09:28hgbotCheckin
2018-09-21 09:28hgbotNote Added: 0106919
2018-09-21 09:28hgbotStatusscheduled => resolved
2018-09-21 09:28hgbotResolutionopen => fixed
2018-09-21 09:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ae5338494af6f4ae10bae4dcbc941ea4f9bceb32 [^]
2018-09-24 19:06caristuDescription Updatedbug_revision_view_page.php?rev_id=17666#r17666
2018-09-24 19:07caristuSummaryconnection leak when printing image on subreports => connection leak when printing image on subreports using the Utility.showImageLogo
2018-09-24 19:07caristuSummaryconnection leak when printing image on subreports using the Utility.showImageLogo => connection leak when printing image on subreports using the Utility.showImageLogo method
2018-09-24 19:18caristuNote Added: 0106975
2018-09-24 19:18caristuStatusresolved => new
2018-09-24 19:18caristuResolutionfixed => open
2018-09-25 10:00hgbotCheckin
2018-09-25 10:00hgbotNote Added: 0106986
2018-09-25 10:09jarmendarizStatusnew => scheduled
2018-09-25 10:13caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17684#r17684
2018-09-25 10:13caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17685#r17685
2018-09-25 10:15caristuRelationship addedrelated to 0030182
2018-09-25 10:27hgbotCheckin
2018-09-25 10:27hgbotNote Added: 0106992
2018-09-25 10:28caristuStatusscheduled => resolved
2018-09-25 10:28caristuResolutionopen => fixed
2018-09-25 10:28caristuNote Added: 0106993
2018-09-25 10:28caristuStatusresolved => closed
2018-09-25 10:28caristuFixed in Version => 3.0PR18Q4
2018-09-25 14:16hudsonbotCheckin
2018-09-25 14:16hudsonbotNote Added: 0107012
2018-09-25 14:16hudsonbotCheckin
2018-09-25 14:16hudsonbotNote Added: 0107018
2018-09-25 20:57hudsonbotCheckin
2018-09-25 20:57hudsonbotNote Added: 0107029
2022-01-31 13:34AugustoMauchRelationship addedcauses 0048465

Notes
(0106919)
hgbot   
2018-09-21 09:28   
Repository: erp/devel/pi
Changeset: ae5338494af6f4ae10bae4dcbc941ea4f9bceb32
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Sep 12 19:08:49 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ae5338494af6f4ae10bae4dcbc941ea4f9bceb32 [^]

Fixed issue 39261: Connection leak when printing image on subreports.

Adding a boolean flag to getImageLogoObject to add the possibility to commit
and close the connection once a logo image is retrieved.

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0106975)
caristu   
2018-09-24 19:18   
Not working fine.

See: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0106986)
hgbot   
2018-09-25 10:00   
Repository: erp/devel/pi
Changeset: 8a73e458127f7a40f4db9fc8583db06798e0856e
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Sep 25 09:59:27 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8a73e458127f7a40f4db9fc8583db06798e0856e [^]

Related to issue 39261: Connection leak when printing image on subreports.

Moved connection close to getImageLogo to avoid errors trying to fetch image
binary data from a closed connection.

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0106992)
hgbot   
2018-09-25 10:27   
Repository: erp/devel/pi
Changeset: 8432ac92f307a502b47d4fb32aa670792f6d90f0
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Sep 25 10:27:13 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8432ac92f307a502b47d4fb32aa670792f6d90f0 [^]

related to issue 39261: update javadoc information

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0106993)
caristu   
2018-09-25 10:28   
Code reviewed + tested OK.
(0107012)
hudsonbot   
2018-09-25 14:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c4e1d4ba022d [^]
Maturity status: Test
(0107018)
hudsonbot   
2018-09-25 14:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c4e1d4ba022d [^]
Maturity status: Test
(0107029)
hudsonbot   
2018-09-25 20:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b69e30e117b8 [^]
Maturity status: Test