Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039230Openbravo ERPA. Platformpublic2018-09-05 17:422018-09-12 21:33
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2018-06-01
Regression introduced in release3.0PR18Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/7a4554ef6d4aec661601cddaac3b4212ab8e8371 [^]
Triggers an Emergency PackNo
Summary0039230: Cannot install a module by adding the OBX in Module Management window
DescriptionCannot install a module by adding the OBX in Module Management window.

The problem seems to be in the following line of ImportModule class:

   String tier = (String) dynModule.get("COMMERCIAL_TIER");
Steps To ReproduceDownload the OBX of 1.4.2001 version of Analytics from Openbravo Forge

As System Admin role:
   Go to Module Management window
   Select Browse File System
   Click on Choose File
   Select the previously downloaded OBX
   Continue

   Check the following error message is shown:
      java.lang.IllegalArgumentException: Invalid property name 'COMMERCIAL_TIER'

   If you Continue java.lang.NullPointerException is shown


   The log shows

ERROR org.openbravo.erpCommon.ad_forms.ModuleManagement - Invalid property name 'COMMERCIAL_TIER'
java.lang.IllegalArgumentException: Invalid property name 'COMMERCIAL_TIER'
    at org.apache.commons.beanutils.BasicDynaBean.getDynaProperty(BasicDynaBean.java:400)
    at org.apache.commons.beanutils.BasicDynaBean.get(BasicDynaBean.java:151)
    at org.openbravo.erpCommon.modules.ImportModule.dyanaBeanToModules(ImportModule.java:1107)
    at org.openbravo.erpCommon.modules.ImportModule.checkDependenciesFile(ImportModule.java:241)
    at org.openbravo.erpCommon.ad_forms.ModuleManagement.printPageInstall1(ModuleManagement.java:1226)
    at org.openbravo.erpCommon.ad_forms.ModuleManagement.printPageInstallFile(ModuleManagement.java:751)
    at org.openbravo.erpCommon.ad_forms.ModuleManagement.doPost(ModuleManagement.java:180)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00392313.0PR18Q3.1 closed AugustoMauch Cannot install a module by adding the OBX in Module Management window 
caused by feature request 0038679 closed alostale remove obsolete License features 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-05 17:42ngarciaNew Issue
2018-09-05 17:42ngarciaAssigned To => platform
2018-09-05 17:42ngarciaModules => Core
2018-09-05 17:42ngarciaResolution time => 1537912800
2018-09-05 17:42ngarciaTriggers an Emergency Pack => No
2018-09-05 17:42ngarciaRelationship addedcaused by 0038679
2018-09-05 17:55PracticsIssue Monitored: Practics
2018-09-05 18:00ngarciaIssue Monitored: networkb
2018-09-05 18:01ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17607#r17607
2018-09-05 18:18AugustoMauchRegression level => Production - QA Approved
2018-09-05 18:18AugustoMauchRegression date => 2018-06-01
2018-09-05 18:18AugustoMauchRegression introduced in release => 3.0PR18Q3
2018-09-05 18:18AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/7a4554ef6d4aec661601cddaac3b4212ab8e8371 [^]
2018-09-05 18:18AugustoMauchAssigned Toplatform => AugustoMauch
2018-09-06 09:31AugustoMauchStatusnew => scheduled
2018-09-06 10:28hgbotCheckin
2018-09-06 10:28hgbotNote Added: 0106615
2018-09-06 10:28hgbotStatusscheduled => resolved
2018-09-06 10:28hgbotResolutionopen => fixed
2018-09-06 10:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bc3da89075bbd208a35512e30f04bbe8347a1a2a [^]
2018-09-06 10:28AugustoMauchReview Assigned To => alostale
2018-09-06 12:55martinsdanIssue Monitored: martinsdan
2018-09-07 08:50alostaleNote Added: 0106636
2018-09-07 08:51alostaleStatusresolved => closed
2018-09-07 08:51alostaleFixed in Version => 3.0PR18Q4
2018-09-12 21:33hudsonbotCheckin
2018-09-12 21:33hudsonbotNote Added: 0106724

Notes
(0106615)
hgbot   
2018-09-06 10:28   
Repository: erp/devel/pi
Changeset: bc3da89075bbd208a35512e30f04bbe8347a1a2a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 05 18:19:38 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bc3da89075bbd208a35512e30f04bbe8347a1a2a [^]

Fixes issue 39230: Removes unneeded reference to COMMERCIAL_TIER column

The column was removed in this changeset [1], but some code referencing it programatically was
left unremoved.

This code was putting the tier info in a map, there is no problem removing it because it was no
longer being checked.

[1] https://code.openbravo.com/erp/devel/pi/rev/7a4554ef6d4aec661601cddaac3b4212ab8e8371 [^]

---
M src/org/openbravo/erpCommon/modules/ImportModule.java
---
(0106636)
alostale   
2018-09-07 08:50   
reviewed + tested
(0106724)
hudsonbot   
2018-09-12 21:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad75d3cb1744 [^]
Maturity status: Test