0039228: Receipt object is global and therefore can be modified after the user has confirmed that the ticket should be processed

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0039228

Retail Modules

Web POS

public

2018-09-05 12:20

2018-10-18 16:38

Reporter

marvintm

Assigned To

migueldejuana

Priority

urgent

Severity

major

Reproducibility

random

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0039228: Receipt object is global and therefore can be modified after the user has confirmed that the ticket should be processed

Description

Currently the receipt object is global, accessible by different asynchronous processes, and therefore as the process to complete the receipt is asynchronous, it is possible that modifications happen after the user has confirmed that the ticket should be processed.

It is not possible to avoid the execution of parallel asynchronous processes. However, it is possible to avoid that the execution of these processes changes the information of the current receipt, by cloning the information of the ticket synchronously when the ticket completion process starts, so that from that point on, the cloned ticket is used to execute the completion process.

Steps To Reproduce

Due to the nature of the issue, the main problems it causes are only visible randomly in different ways. An example of an issue caused indirectly by this problem is the following:

https://issues.openbravo.com/view.php?id=39219 [^]

Proposed Solution

- Ticket should be cloned in a synchronized way at the start of the ticket completion process.
- The clone of the ticket should be used by the remaining actions in the ticket completion process.
- Even though the WebSQL database could in theory be a problem as it is another global point shared by all processes, so another process could save, and therefore overwrite the ticket with incorrect or outdated information in theory, in practice this should no longer be possible due to the implementation of the "hasbeenmodified" check while saving the record, which should prevent this problem from happening.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0039219		closed	migueldejuana	Order is imported without lines if Supr is pressed more than once after Done is launched
depends on	backport	0039393	RR18Q3.2	closed	migueldejuana	Receipt object is global and therefore can be modified after the user has confirmed that the ticket should be processed
depends on	backport	0039484	RR18Q2.4	closed	migueldejuana	Receipt object is global and therefore can be modified after the user has confirmed that the ticket should be processed
related to	defect	0038862		closed	migueldejuana	Ticket completion should be executed fully inside the same database transaction
related to	defect	0041067		closed	migueldejuana	Cash management object is global and therefore can be modified after the user has confirmed that the ticket should be processed