Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039224Retail ModulesDiscounts by Payment Methodpublic2018-09-04 14:182018-09-06 15:08
Reporterumartirena 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusscheduledResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039224: Discount calculation amount issue in Discount by Payment Method
DescriptionPayment method discount amount is not properly calculated under certain circumstances.
Steps To ReproduceGo to https://livebuilds.openbravo.com/retail_modules_pgsql_pi/ [^]
Open Discounts and Promotions window and create a new record:
 * Discount/Promotion type: "Payment Method Discount"
 * Name: "2.3% Discount on Cash Payment Method"
 * Starting date: Something earlier than Today
 * Percentage from Total: 2.3%
 * Add a record in Payment Method tab:
   - Payment Method: Wire transfer
Login into https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
 * Add an item
 * Change price to 15.00
 * Go to payment method
 * Click on Exact Payment
 * Realize that the payment added is of amount 14.65, but the discount included is of amount -0.34, so there is pending 0.01€ to be paid, which is wrong.
Proposed SolutionDon't recalculate the discount again, reuse the information calculated to add the payment
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037856 closed ranjith_qualiantech_com Issues in Payment Method discount calculation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-04 14:18umartirenaNew Issue
2018-09-04 14:18umartirenaAssigned To => Retail
2018-09-04 14:18umartirenaTriggers an Emergency Pack => No
2018-09-04 14:18umartirenaRelationship addedrelated to 0037856
2018-09-04 14:27ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-09-04 14:27ranjith_qualiantech_comStatusnew => scheduled
2018-09-04 16:21jfrancesIssue Monitored: jfrances
2018-09-05 07:44rafarodaIssue Monitored: rafaroda
2018-09-05 13:15umartirenaAssigned Toranjith_qualiantech_com => umartirena
2018-09-06 12:02hgbotCheckin
2018-09-06 12:02hgbotNote Added: 0106617
2018-09-06 15:08hgbotCheckin
2018-09-06 15:08hgbotNote Added: 0106625

Notes
(0106617)
hgbot   
2018-09-06 12:02   
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: 602c9e6db91c6fe40f3b9743f79dc9f6afbea422
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 06 15:32:34 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/602c9e6db91c6fe40f3b9743f79dc9f6afbea422 [^]

Related to issue 39224 : Modified Discount calculation to avoid roundoff problems

---
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0106625)
hgbot   
2018-09-06 15:08   
Repository: tools/automation/pi-mobile
Changeset: 9f86c472363732157eb3a560650d5a0345b5ffa8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 06 18:38:22 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9f86c472363732157eb3a560650d5a0345b5ffa8 [^]

Verifies issue 39224 : Modified Test 'I30305_VerifyDiscountByMultiPayment'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bypaymentmethod/I30305_VerifyDiscountByMultiPayment.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bypaymentmethod/I30305_VerifyDiscountByMultiPaymentII.java
---