Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039223Retail ModulesStoreServerpublic2018-09-04 13:072018-09-14 11:43
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039223: Transition to online state not needed when moving from transitiion to offline to online
DescriptionWhen we notice during transition to offline that offline is not needed anymore the logic triggers a transition to online phase first [1]. This is however not needed as the system was already in transitioning mode. We can just switch the status to online.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l124 [^]
Steps To ReproduceSee description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 39223.diff (1,467) 2018-09-13 18:06
https://issues.openbravo.com/file_download.php?file_id=12138&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-09-04 13:07mtaalNew Issue
2018-09-04 13:07mtaalAssigned To => mtaal
2018-09-04 13:07mtaalTriggers an Emergency Pack => No
2018-09-11 19:25mtaalNote Added: 0106691
2018-09-13 18:06mtaalFile Added: 39223.diff
2018-09-14 08:16hgbotCheckin
2018-09-14 08:16hgbotNote Added: 0106762
2018-09-14 08:16hgbotStatusnew => resolved
2018-09-14 08:16hgbotResolutionopen => fixed
2018-09-14 08:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/96142d43ff5482643e6b9a7f64105a8f7480bccf [^]
2018-09-14 08:17mtaalReview Assigned To => AugustoMauch
2018-09-14 11:43AugustoMauchNote Added: 0106768
2018-09-14 11:43AugustoMauchStatusresolved => closed

Notes
(0106691)
mtaal   
2018-09-11 19:25   
To test:
- start multi-server
- put a breakpoint here [1]
- stop cs
- force webpos to do a call to ss and cs
- it forces transition offline
- breakpoint is hit
- start cs
- after cs started continue from breakpoint, see that offline is not needed anymore and check that it goes online directly

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l98 [^]
(0106762)
hgbot   
2018-09-14 08:16   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 96142d43ff5482643e6b9a7f64105a8f7480bccf
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 14 08:16:32 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/96142d43ff5482643e6b9a7f64105a8f7480bccf [^]

Fixes issue 39223: Transition to online state not needed when moving from transitiion to offline to online
Go back online if transition to offline is not needed anymore

---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
---
(0106768)
AugustoMauch   
2018-09-14 11:43   
Code reviewed and verified