Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039219Retail ModulesWeb POSpublic2018-09-04 10:582018-09-28 08:37
Reporterngarcia 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket3961
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039219: Order is imported without lines if Supr is pressed more than once after Done is launched
DescriptionOrder is imported without lines if Supr is pressed more than once after Done is launched
Steps To ReproduceIn the backend:
   Go to POS Terminal Type and select Use External Input option

In the POS:
   Create a new receipt, add a product and payment to it
   Click on Done and once the screen is blocked press Supr key of the keyboard more than once

In the backend:
   Check the sales order has been imported without lines but payments
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0039228 closed migueldejuana Receipt object is global and therefore can be modified after the user has confirmed that the ticket should be processed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-04 10:58ngarciaNew Issue
2018-09-04 10:58ngarciaAssigned To => Retail
2018-09-04 10:58ngarciaOBNetwork customer => Yes
2018-09-04 10:58ngarciaSupport ticket => 3961
2018-09-04 10:58ngarciaResolution time => 1537826400
2018-09-04 10:58ngarciaTriggers an Emergency Pack => No
2018-09-04 10:59ngarciaIssue Monitored: networkb
2018-09-05 13:46rafarodaRelationship addedrelated to 0039228
2018-09-05 15:05alekosmp86Assigned ToRetail => alekosmp86
2018-09-05 15:05alekosmp86Statusnew => scheduled
2018-09-07 20:48hgbotCheckin
2018-09-07 20:48hgbotNote Added: 0106644
2018-09-07 20:48hgbotStatusscheduled => resolved
2018-09-07 20:48hgbotResolutionopen => fixed
2018-09-07 20:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6395f1de81f66d26db2fe75d9ef0602125c558d [^]
2018-09-10 15:24hgbotCheckin
2018-09-10 15:24hgbotNote Added: 0106674
2018-09-11 18:37hgbotCheckin
2018-09-11 18:37hgbotNote Added: 0106687
2018-09-11 18:38hgbotCheckin
2018-09-11 18:38hgbotNote Added: 0106688
2018-09-11 18:39marvintmAssigned Toalekosmp86 => migueldejuana
2018-09-11 18:39marvintmStatusresolved => new
2018-09-11 18:39marvintmResolutionfixed => open
2018-09-11 18:40marvintmStatusnew => scheduled
2018-09-25 16:46migueldejuanaNote Added: 0107022
2018-09-25 16:46migueldejuanaStatusscheduled => resolved
2018-09-25 16:46migueldejuanaResolutionopen => fixed
2018-09-28 08:36marvintmStatusresolved => new
2018-09-28 08:36marvintmResolutionfixed => open
2018-09-28 08:37marvintmReview Assigned To => marvintm
2018-09-28 08:37marvintmNote Added: 0107060
2018-09-28 08:37marvintmStatusnew => closed
2018-09-28 08:37marvintmResolutionopen => no change required
2018-09-28 08:37marvintmFixed in Version => RR18Q4

Notes
(0106644)
hgbot   
2018-09-07 20:48   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e6395f1de81f66d26db2fe75d9ef0602125c558d
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Sep 04 15:02:09 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6395f1de81f66d26db2fe75d9ef0602125c558d [^]

Fixes issue 39219: Order is imported without lines if Supr is pressed more than
once after Done is launched.

* After Done is launched if the external inputs are active, they are disabled, and
re-enabled once the process has finished.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0106674)
hgbot   
2018-09-10 15:24   
Repository: tools/automation/pi-mobile
Changeset: 919d26422850d5cdb112b81ec812737e365261cc
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Sep 05 14:19:26 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/919d26422850d5cdb112b81ec812737e365261cc [^]

Related to issue 39219: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I39219_VerifyOrderLinesWhenSuprPressedAfterPay.java
---
(0106687)
hgbot   
2018-09-11 18:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 43311eceff9e04359333a5ee3a4eddf4a2b700b1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 11 18:36:56 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/43311eceff9e04359333a5ee3a4eddf4a2b700b1 [^]

Backed out issue 39219. This problem will be fixed in a more generic way.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0106688)
hgbot   
2018-09-11 18:38   
Repository: tools/automation/pi-mobile
Changeset: ed13ec7f23983c55511da7aa2b5b6699a709fd86
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 11 18:38:22 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ed13ec7f23983c55511da7aa2b5b6699a709fd86 [^]

Related to issue 39219. Backed out test until we fix the issue properly

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I39219_VerifyOrderLinesWhenSuprPressedAfterPay.java
---
(0107022)
migueldejuana   
2018-09-25 16:46   
Fixed by https://issues.openbravo.com/view.php?id=39228 [^]
(0107060)
marvintm   
2018-09-28 08:37   
It was fixed by fixing issue https://issues.openbravo.com/view.php?id=39228 [^]