Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039212Openbravo ERPA. Platformpublic2018-09-01 12:042020-04-16 07:55
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039212: Small cleanup of build.xml (simplify smartbuild antcalls, remove obsolete db.apply.modules & apply.on.update)
DescriptionSmall simplifications to build.xml files
- in smartbuild:
  - remove setting onlyIfModified property. That was used before inside dbsm.
    But its usage got removed in commit 530adf6659de. So no need setting it.
  - Remove an antcall to avoid overhead (which parses build.xml again from zero)
- in install.source
  - Remove an antcall to avoid overhead
- remove ant target db.apply.modules
  That is never called anywhere in the build system.
  It is not useful to keep for manual use as it just calls another target
  depending on the propery apply.on.update which is also never set in the build
  system automatically.
- in generate.java.doc
  Simplify conditions by stopping to compare against Java 1.7 which is no longer supported. To safeguard task add depends on "init" which is checking for Java>=1.8 already
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038296 acknowledged Triage Platform Base Review & cleanup build.xml 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-01 12:04shuehnerNew Issue
2018-09-01 12:04shuehnerAssigned To => shuehner
2018-09-01 12:04shuehnerModules => Core
2018-09-01 12:04shuehnerTriggers an Emergency Pack => No
2018-09-01 12:05shuehnerRelationship addedblocks 0038296
2018-09-01 12:25shuehnerReview Assigned To => alostale
2020-04-13 18:08shuehnerDescription Updatedbug_revision_view_page.php?rev_id=20748#r20748
2020-04-14 18:56hgbotCheckin
2020-04-14 18:56hgbotNote Added: 0119161
2020-04-14 18:56hgbotCheckin
2020-04-14 18:56hgbotNote Added: 0119162
2020-04-14 18:56hgbotCheckin
2020-04-14 18:56hgbotNote Added: 0119163
2020-04-14 18:56hgbotStatusnew => resolved
2020-04-14 18:56hgbotResolutionopen => fixed
2020-04-14 18:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/794594bbf2b9a45d6cf4701bb72914e492fb0ff5 [^]
2020-04-16 07:55alostaleNote Added: 0119204
2020-04-16 07:55alostaleStatusresolved => closed
2020-04-16 07:55alostaleFixed in Version => 3.0PR20Q3

Notes
(0119161)
hgbot   
2020-04-14 18:56   
Repository: erp/devel/pi
Changeset: 908fd634e36f69c3782726ba2817b91047715da0
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Mon Apr 13 18:18:33 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/908fd634e36f69c3782726ba2817b91047715da0 [^]

related to ISSUE-39212: Simplify build.xml javadoc (java version conditions)

Stop checking for Java 1.7 case as that is no longer supported for
several releases. Add init task as dependency to generate.java.doc to
ensure we run the java version check also for the javadoc case.

---
M build.xml
---
(0119162)
hgbot   
2020-04-14 18:56   
Repository: erp/devel/pi
Changeset: 5539ab6cb39068a841da14b43ebb83f10d63f80a
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Mon Apr 13 18:25:18 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5539ab6cb39068a841da14b43ebb83f10d63f80a [^]

related to ISSUE-39212: Simplify build.xml and remove clutter in output

In smartbuild task:
- Remove setting onlyIfModified (use of it was removed from
  dbsourcemanager in commit 530adf6659de already)
  - Move antcall of core.lib to depends (can be done as core.lib target
    has no conditional (if,unless). + also core.lib does not use the smart.mode
    properpy which was set before the old antcall.
    Result: Avoid overhead of ant parsing main build file again done by antcall.
- in install.source task
  - remove echo "applying modules" no other tasks announces itself that way
    that allows to move 2 antcalls apply.module & import.sample.data

---
M build.xml
---
(0119163)
hgbot   
2020-04-14 18:56   
Repository: erp/devel/pi
Changeset: 794594bbf2b9a45d6cf4701bb72914e492fb0ff5
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Mon Apr 13 18:28:40 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/794594bbf2b9a45d6cf4701bb72914e492fb0ff5 [^]

Fixes ISSUE-39212: Remove obsolete db.apply.modules & apply.on.update

Main build.xml file has some obsolete items which are never used and are
removed here.
Task db.apply.modules is never called anywhere in the build system.
Also it is not useful to keep for potential manual developer usage as
its purpose is just to call another ant target apply.module depending
on if the flag apply.on.update is set.
Removing that task also some small follow up cleanup on the condition
definition in + the properly definition.

---
M build.xml
---
(0119204)
alostale   
2020-04-16 07:55   
MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/58 [^]