Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039201Openbravo ERPA. Platformpublic2018-08-30 11:232018-09-25 20:57
ReporterLeyre 
Assigned Tojarmendariz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket4299
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039201: Menu may be overlapped by a messageBar if receiving a response from a closed window request
DescriptionThe menu items disappear when closing/opening "Accounting Transaction Details".
Steps To Reproduce1. Open "Accounting Transaction Details" window

2. Filter by Business Partner.

3. While loading data, close the window.

4. Open again "Accounting Transaction Details" window.

5. Verify that all the menu items (Quick menu, Search menu, Alerts, Help, ...) have disappeared.

** This happens in an environment that there are many records:
fact_acct > 30.000.000 of records.


This issue can be more repeatable by applying the patch attached to made POST requests fail after a 10s delay:

1. Open "Accounting Transaction Details" window

2. Close the window as soon as the request started

3. Wait 10 seconds

4. An error messageBar with no icon and no close button should appear at the top of the page overlapping the menu.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039293 closed markmm82 Accounting Transaction Details Query Performance 
Attached Filespatch request-fail-after-10s.patch (1,123) 2018-09-12 13:55
https://issues.openbravo.com/file_download.php?file_id=12129&type=bug
patch issue-39201.patch (3,915) 2018-09-12 19:13
https://issues.openbravo.com/file_download.php?file_id=12131&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-08-30 11:23LeyreNew Issue
2018-08-30 11:23LeyreAssigned To => platform
2018-08-30 11:23LeyreOBNetwork customer => Yes
2018-08-30 11:23LeyreModules => Core
2018-08-30 11:23LeyreSupport ticket => 4299
2018-08-30 11:23LeyreResolution time => 1537394400
2018-08-30 11:23LeyreTriggers an Emergency Pack => No
2018-08-30 12:41rafarodaIssue Monitored: rafaroda
2018-08-30 16:03rafarodaTag Attached: Performance
2018-09-12 13:32jarmendarizAssigned Toplatform => jarmendariz
2018-09-12 13:44jarmendarizStatusnew => scheduled
2018-09-12 13:55jarmendarizFile Added: request-fail-after-10s.patch
2018-09-12 13:58jarmendarizSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17625#r17625
2018-09-12 13:58jarmendarizSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17626#r17626
2018-09-12 19:13jarmendarizFile Added: issue-39201.patch
2018-09-17 16:12rafarodaRelationship addedrelated to 0039293
2018-09-20 12:55jarmendarizSummaryPerformance Issue in Accounting Transaction Detail Window. => Menu may be overlapped by a messageBar if receiving a response from a closed window request
2018-09-21 09:31hgbotCheckin
2018-09-21 09:31hgbotNote Added: 0106920
2018-09-21 09:31hgbotStatusscheduled => resolved
2018-09-21 09:31hgbotResolutionopen => fixed
2018-09-21 09:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ebcdd2bf2c5f5b650d3e6c5501049393d98e525 [^]
2018-09-24 16:49caristuReview Assigned To => caristu
2018-09-24 16:50caristuTag Detached: Performance
2018-09-25 10:44hgbotCheckin
2018-09-25 10:44hgbotNote Added: 0106995
2018-09-25 10:54caristuNote Added: 0106996
2018-09-25 10:54caristuStatusresolved => closed
2018-09-25 10:54caristuFixed in Version => 3.0PR18Q4
2018-09-25 14:16hudsonbotCheckin
2018-09-25 14:16hudsonbotNote Added: 0107013
2018-09-25 20:57hudsonbotCheckin
2018-09-25 20:57hudsonbotNote Added: 0107030

Notes
(0106920)
hgbot   
2018-09-21 09:31   
Repository: erp/devel/pi
Changeset: 7ebcdd2bf2c5f5b650d3e6c5501049393d98e525
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Sep 21 09:28:48 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7ebcdd2bf2c5f5b650d3e6c5501049393d98e525 [^]

Fixed issue 39201: Menu overlapped by messageBar if receiving a response from a closed window.

Instead of dissapearing, the menu were overlapped with a error messageBar which
originally belonged to the window that made the request (and were closed before
it finishes). This fix ensures the datasource window is not currently destroyed
to show the error message.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view-datasource.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0106995)
hgbot   
2018-09-25 10:44   
Repository: erp/devel/pi
Changeset: 293ffdd59d3500e3bea924da40c1ecabdbe8e4cf
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Sep 25 10:42:56 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/293ffdd59d3500e3bea924da40c1ecabdbe8e4cf [^]

Related to issue 39201: Updated copyright year

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0106996)
caristu   
2018-09-25 10:54   
Code reviewed + tested OK.
(0107013)
hudsonbot   
2018-09-25 14:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c4e1d4ba022d [^]
Maturity status: Test
(0107030)
hudsonbot   
2018-09-25 20:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b69e30e117b8 [^]
Maturity status: Test