Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039200Retail ModulesWeb POSpublic2018-08-30 10:012018-11-16 08:37
Reporterebecerra 
Assigned Toebecerra 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039200: Allow reimburse Gift Card with different payment methods.
DescriptionExtend current Gift Cards functionality to allow reimburse Gift Card with different payment methods.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff mobile-core.diff (2,195) 2018-11-12 12:00
https://issues.openbravo.com/file_download.php?file_id=12358&type=bug
diff posterminal.diff (36,620) 2018-11-12 12:18
https://issues.openbravo.com/file_download.php?file_id=12359&type=bug
diff pi-mobile.diff (21,395) 2018-11-12 13:24
https://issues.openbravo.com/file_download.php?file_id=12360&type=bug
diff giftcards.diff (91,538) 2018-11-12 14:07
https://issues.openbravo.com/file_download.php?file_id=12361&type=bug
diff test-mobile-sampledata.diff (3,294) 2018-11-12 14:08
https://issues.openbravo.com/file_download.php?file_id=12362&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-08-30 10:01ebecerraNew Issue
2018-08-30 10:01ebecerraAssigned To => Retail
2018-08-30 10:01ebecerraTriggers an Emergency Pack => No
2018-09-10 13:25ebecerraFile Added: posterminal.diff
2018-09-10 13:43ebecerraFile Added: mobile-core.diff
2018-09-12 09:24ebecerraFile Added: test-mobile-sampledata.diff
2018-09-17 10:55ebecerraFile Added: giftcards.diff
2018-09-19 08:50ebecerraFile Deleted: giftcards.diff
2018-09-19 08:50ebecerraFile Added: giftcards.diff
2018-09-19 09:27ebecerraFile Added: test-pi-mobile.diff
2018-09-20 13:02ebecerraFile Deleted: test-pi-mobile.diff
2018-09-20 13:02ebecerraFile Added: test-pi-mobile.diff
2018-09-20 13:21ebecerraFile Deleted: posterminal.diff
2018-09-20 13:21ebecerraFile Added: posterminal.diff
2018-09-26 10:14ebecerraFile Added: posterminal-db.diff
2018-10-18 08:47ebecerraNote Added: 0107381
2018-10-18 09:00ebecerraNote Edited: 0107381bug_revision_view_page.php?bugnote_id=0107381#r17780
2018-10-18 09:18ebecerraNote Edited: 0107381bug_revision_view_page.php?bugnote_id=0107381#r17781
2018-10-18 09:21ebecerraNote Edited: 0107381bug_revision_view_page.php?bugnote_id=0107381#r17782
2018-10-18 09:40ebecerraNote Edited: 0107381bug_revision_view_page.php?bugnote_id=0107381#r17783
2018-10-22 10:30ebecerraNote Edited: 0107381bug_revision_view_page.php?bugnote_id=0107381#r17798
2018-10-25 12:58ebecerraFile Added: test-pi-mobile-partial-reimburse.diff
2018-11-12 11:58hgbotCheckin
2018-11-12 11:58hgbotNote Added: 0107844
2018-11-12 12:00ebecerraFile Deleted: mobile-core.diff
2018-11-12 12:00ebecerraFile Added: mobile-core.diff
2018-11-12 12:18ebecerraFile Deleted: posterminal.diff
2018-11-12 12:18ebecerraFile Deleted: posterminal-db.diff
2018-11-12 12:18ebecerraFile Added: posterminal.diff
2018-11-12 13:23ebecerraFile Deleted: test-pi-mobile.diff
2018-11-12 13:23ebecerraFile Deleted: test-pi-mobile-partial-reimburse.diff
2018-11-12 13:24ebecerraFile Added: pi-mobile.diff
2018-11-12 14:05hgbotCheckin
2018-11-12 14:05hgbotNote Added: 0107852
2018-11-12 14:06hgbotCheckin
2018-11-12 14:06hgbotNote Added: 0107853
2018-11-12 14:07hgbotCheckin
2018-11-12 14:07hgbotNote Added: 0107854
2018-11-12 14:07ebecerraFile Deleted: giftcards.diff
2018-11-12 14:07ebecerraFile Added: giftcards.diff
2018-11-12 14:07ebecerraFile Deleted: test-mobile-sampledata.diff
2018-11-12 14:08ebecerraFile Added: test-mobile-sampledata.diff
2018-11-16 08:36marvintmStatusnew => scheduled
2018-11-16 08:36marvintmAssigned ToRetail => ebecerra
2018-11-16 08:36marvintmStatusscheduled => resolved
2018-11-16 08:36marvintmFixed in Version => RR19Q1
2018-11-16 08:36marvintmResolutionopen => fixed
2018-11-16 08:37marvintmReview Assigned To => migueldejuana
2018-11-16 08:37marvintmStatusresolved => closed

Notes
(0107381)
ebecerra   
2018-10-18 08:47   
(edited on: 2018-10-22 10:30)
Change description:

------------------------------------------------------------
- org.openbravo.mobile.core
------------------------------------------------------------

* source/model/ob-terminal-model.js
    - Add hook: OBPOS_AfterRenderContainerWindow
    - Add a parameter to: OB.MobileApp.model.navigate and add a hook: OBPOS_AfterRenderContainerWindow to be passed a new parameter

------------------------------------------------------------
- org.openbravo.retail.posterminal
------------------------------------------------------------

* js/cashmgmt/model/cashmgmt-model.js
    - When Done a payment, only validate Cash
    - Check pending drop to save have cash management provider

* js/cashmgmt/view/cashmgmt.js
    - Button Done: Show Cash Management Provider dialog
    - Add following event handlers:
        + onPaymentChanged
        + onPaymentChangedCancelled
        + onCashManagementDisableKeyboardButtons
    - Register window: OB.OBPOSCashMgmt.UI.CashManagement

* js/cashmgmt/view/cashmgmtkeyboard.js
    - Add the event handlers: onDisableKeyboardButtons

* js/components/mockpayments.js
    - Check if mock dialog is used from receipt Payment or Cash Management

* js/components/modalpayment.js
    - Add related window: Cash Management

* js/pointofsale/view/modals/modalpayments.js
    - Add business logic when Credit Card Selector is open from CashManagement

* js/pointofsale/view/pointofsale.js
    - Add event: onPaymentChangedCancelled

------------------------------------------------------------
- org.openbravo.retail.giftcards
------------------------------------------------------------

[src/org/openbravo/retail/giftcards]

   * hooks/ProcessCashMgmtHookGiftCard.java
       - Add a new payment when Gift Card transaction do not have one

   * master/CashMgmtEvents.java
       - Add following field to CashMgmtEvents:
          + Payment Method identifier
          + Payment Method Name

   * process/CreditNoteException.java
       - A new class Exception

   * process/GiftCardGLItemUtils.java
       - Refactor code to add a new method: makePayment

   * FindGiftCard.java
       - Allow to load reimburse methods when find a Gitt Card

   * GCNVComponentProvider.java
       - Add new JS files

[web/org.openbravo.retail.giftcards]

   * js/components/GiftCardDetails.js
       - Allow return for gift card types: BasedOnGLItem and BasedOnCreditNote
       - Navigate to Cash Management window when gift card types are BasedOnGLItem or BasedOnCreditNote
       - Refactor "executeOnShow" when is opened from Cash Management Window

   * js/components/GiftCardDialog.js
       - Refactor "executeOnShow" to allow prefilter by GiftCard Identifier

   * js/components/GiftCardReimburseAmount.js
       - A new dialog to enter amount to reimburse

   * js/components/GiftCardReimbursePaymentSelector.js
       - A new dialog to select a payment method used to reimburse

   * js/hooks/AddButtonToCashManagementHook.js
       - Use refactor code (OB.OBGCNE.Utils.openGiftCardSelector)

   * js/hooks/AddPaymentToCashManagementHook.js
       - Register hook: OBPOS_AddPaymentToCashManagement

   * js/hooks/AfterRenderContainerWindowHook.js
       - Register hook: OBPOS_AfterRenderContainerWindow, to open Gift Card selector, when Cash Management is opened from GiftCardDetail dialog (button Return)

   * js/hooks/preSaveCashManagementsHook.js
       - Refactor code

   * js/model/GiftCardUtils.js
       - Add a new utility method: openGiftCardSelector
(0107844)
hgbot   
2018-11-12 11:58   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: bcdf375d222c18e70f50d2df0121ed131dd288fb
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Nov 12 11:58:09 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bcdf375d222c18e70f50d2df0121ed131dd288fb [^]

Related issue 39200: Allow reimburse Gift Card with different payment methods
  - Add event handler "onDisableButton" to component "OB.UI.ToolbarMore"
  - Add a "parameters" argument to OB.Model.Terminal.navigate function
  - Add a new hook: OBPOS_AfterRenderContainerWindow

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0107852)
hgbot   
2018-11-12 14:05   
Repository: tools/automation/pi-mobile
Changeset: 12b5fca97516022ad379dae1b74244890933484d
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Nov 12 13:18:31 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/12b5fca97516022ad379dae1b74244890933484d [^]

Related issue 39200: Allow reimburse Gift Card with different payment methods

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreditNoteReimburse.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I38405_VerifyCashUpWhenGiftCardIsRefunded.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReimburseCard.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/TryReimburseCardNotReimbursable.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I39200_ReimburseInDifferentPaymentMethods.java
---
(0107853)
hgbot   
2018-11-12 14:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3bca8320511c82600fc16c06453b81984a387a2d
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Nov 12 14:05:45 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3bca8320511c82600fc16c06453b81984a387a2d [^]

Related issue 39200: Allow reimburse Gift Card with different payment methods
  - New column/field: "Cash Management Provider" was added to table OBPOS_App_Payment_Type to define an external payment provider who processes this kind of refund types
  - Add a new process definition: cashMngPaymentDone, to define the start and finish of payment done on Cash Management window
  - Add a new "Cash Management Provider". By default use "OB.UI.MockPayment"
  - Add a new event: onPaymentChangedCancelled is trigger when no select any payment method
  - Modify ModalPayment to include "OB.OBPOSCashMgmt.Model.CashManagement" as parameter
  - Modify MockPayment to complete payment process on Cash Management window
  - Modify OB.OBPOSCashMgmt.Model.CashManagement to use process definition: cashMngPaymentDone
  - Add a new hook: OBPOS_AddPaymentToCashManagement to be executed when "Cash Up Management" window load the payment methods
  - Modify "cashmgmtkeyboard.js" to enable/disable button when process "cashMngPaymentDone" is executed

---
M src-db/database/model/tables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmt.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmtkeyboard.js
M web/org.openbravo.retail.posterminal/js/components/mockpayments.js
M web/org.openbravo.retail.posterminal/js/components/modalpayment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0107854)
hgbot   
2018-11-12 14:07   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 3560830d8fab70c56751576772f204de9e3f1991
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Nov 12 14:06:59 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/3560830d8fab70c56751576772f204de9e3f1991 [^]

Related issue 39200: Allow reimburse Gift Card with different payment methods
  - Add message for labels, messages, errors and buttons
  - Change: ProcessCashMgmtHookGiftCard.java to make payment and transactions when reimburse a gift card or credit note
  - Change: CashMgmtEvents.java to return payment method information for events (id and name)
  - Change: FindGiftCard.java to allow return payment methods to reimburse to "Credit Note" and "Gift Card Certificate"
  - Change: ListGiftCard.java to sort gift card by "searckKey"
  - Refactor code of GiftCardUtils.js and AddButtonToCashManagementHook.js to reuse "openGiftCardSelector" functionality
  - Change: preSaveCashManagementsHook.js to consume GiftCard when reimburse
  - Add a new hook implementation: OBPOS_AfterRenderContainerWindow, to open Gift Card Detail dialog if navigate to Cash Management from gift card selector
  - Add a new hook implementation: OBPOS_AddPaymentToCashManagement, to add payments to different payment method in left panel
  - Change: GiftCardDetails.js to allow open reimburse in Cash Management window when push "Return" button
  - Change: GiftCardDialog.js to filter by a gift card identifier
  - Change: GiftCardMessage.js to allow more complex notification messages
  - Add a new dialog "GCNV.UI.ModalReimburseAmount" to select reimburse amount
  - Add a new dialog "GCNV.UI.ModalReimbursePaymentSelector" to select the payment method to reimburse

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/FindGiftCard.java
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M src/org/openbravo/retail/giftcards/ListGiftCard.java
M src/org/openbravo/retail/giftcards/hooks/ProcessCashMgmtHookGiftCard.java
M src/org/openbravo/retail/giftcards/master/CashMgmtEvents.java
M src/org/openbravo/retail/giftcards/process/GiftCardGLItemUtils.java
M web/org.openbravo.retail.giftcards/css/gcnv.css
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
M web/org.openbravo.retail.giftcards/js/components/GiftCardDialog.js
M web/org.openbravo.retail.giftcards/js/components/GiftCardMessage.js
M web/org.openbravo.retail.giftcards/js/hooks/AddButtonToCashManagementHook.js
M web/org.openbravo.retail.giftcards/js/hooks/preSaveCashManagementsHook.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
A src/org/openbravo/retail/giftcards/process/CreditNoteException.java
A web/org.openbravo.retail.giftcards/js/components/GiftCardReimburseAmount.js
A web/org.openbravo.retail.giftcards/js/components/GiftCardReimbursePaymentSelector.js
A web/org.openbravo.retail.giftcards/js/hooks/AddPaymentToCashManagementHook.js
A web/org.openbravo.retail.giftcards/js/hooks/AfterRenderContainerWindowHook.js
---