Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039194Openbravo ERPA. Platformpublic2018-08-28 14:162018-08-30 18:48
Reportercaristu 
Assigned Tocaristu 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039194: Improve parameter name in Utility.getImage(String, boolean) method
DescriptionThe name of the boolean parameter in Utility.getImage(String, boolean) method is not descriptive enough (doCommit).

This method was introduced to avoid connection leaks when printing an image on a jasper subreport using the Utility.showImage method. This method ensures that the connection is closed once the image has been retrieved.

The boolean parameter was intended to decide if the connection should be closed (not just commited). This should be reflected on its name.
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036697 closed caristu connection leak when printing a image on a jasper subreport using the Utility.showImage method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-08-28 14:16caristuNew Issue
2018-08-28 14:16caristuAssigned To => platform
2018-08-28 14:16caristuModules => Core
2018-08-28 14:16caristuTriggers an Emergency Pack => No
2018-08-28 14:16caristuAssigned Toplatform => caristu
2018-08-28 14:16caristuRelationship addedrelated to 0036697
2018-08-28 14:23hgbotCheckin
2018-08-28 14:23hgbotNote Added: 0106507
2018-08-28 14:23hgbotStatusnew => resolved
2018-08-28 14:23hgbotResolutionopen => fixed
2018-08-28 14:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/14005f586f3c8181acf6f6f69785b1e83f970253 [^]
2018-08-28 14:23caristuReview Assigned To => jarmendariz
2018-08-29 09:00jarmendarizNote Added: 0106511
2018-08-29 09:02jarmendarizStatusresolved => closed
2018-08-29 09:02jarmendarizFixed in Version => 3.0PR18Q4
2018-08-30 18:48hudsonbotCheckin
2018-08-30 18:48hudsonbotNote Added: 0106548

Notes
(0106507)
hgbot   
2018-08-28 14:23   
Repository: erp/devel/pi
Changeset: 14005f586f3c8181acf6f6f69785b1e83f970253
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Aug 28 14:19:56 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14005f586f3c8181acf6f6f69785b1e83f970253 [^]

fixes bug 39194: More descriptive param name in getImage(String,boolean) method

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0106511)
jarmendariz   
2018-08-29 09:00   
Reviewed.
(0106548)
hudsonbot   
2018-08-30 18:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f018f6d60a65 [^]
Maturity status: Test