Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039177Retail ModulesWeb POSpublic2017-10-02 16:592018-09-18 18:13
Reportermigueldejuana 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q3.1Fixed in VersionRR18Q3.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-02-06
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4729f5935750dd6a632b63033c2bd3ab21305d46 [^]
Triggers an Emergency PackNo
Summary0039177: We are triggering twice window:ready
DescriptionWe are triggering twice window:ready. We already have a listener which does 2 requests to the backend. We have 2 problems:

- We are doing duplicate requests in the login
- The code inside the window:ready listener could cause errors because it is executed twice(i.e.: Remove current order twice)

The issue which causes the regression has a note which comments the problem of the duplicate trigger but the commit just fixes the causing error, no the root problem.
Steps To ReproduceSee Desc.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036985 closed ranjith_qualiantech_com We are triggering twice window:ready 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-08-23 12:13migueldejuanaTypedefect => backport
2018-08-23 12:13migueldejuanaTarget Version => RR18Q3.1
2018-08-27 07:36hgbotCheckin
2018-08-27 07:36hgbotNote Added: 0106485
2018-08-27 07:36hgbotCheckin
2018-08-27 07:36hgbotNote Added: 0106486
2018-08-27 07:36hgbotStatusscheduled => resolved
2018-08-27 07:36hgbotResolutionopen => fixed
2018-08-27 07:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37856256e643d7ff6ac87e6c955e4dcc0a38129a [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.1/org.openbravo.retail.posterminal/rev/2e18f4ffd6a1180b24a0610ed1d4c02257eb629d [^]
2018-09-18 18:13marvintmReview Assigned To => marvintm
2018-09-18 18:13marvintmStatusresolved => closed
2018-09-18 18:13marvintmFixed in Version => RR18Q3.1

Notes
(0106485)
hgbot   
2018-08-27 07:36   
Repository: retail/backports/3.0RR18Q3.1/org.openbravo.mobile.core
Changeset: 0b82dcc50f9917f97c3795db5278bf572da255c1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Aug 27 11:06:08 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.1/org.openbravo.mobile.core/rev/0b82dcc50f9917f97c3795db5278bf572da255c1 [^]

Related to issue 39177 : Container window should be rendered when window:ready event is triggered

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0106486)
hgbot   
2018-08-27 07:36   
Repository: retail/backports/3.0RR18Q3.1/org.openbravo.retail.posterminal
Changeset: 2e18f4ffd6a1180b24a0610ed1d4c02257eb629d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Aug 27 11:06:15 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.1/org.openbravo.retail.posterminal/rev/2e18f4ffd6a1180b24a0610ed1d4c02257eb629d [^]

Fixed issue 39177 : Removed model trigger window:ready when unpaid receipts are loaded

* 'window:ready' event added when loading unpaid receipts from database.
Unpaid receipts will be added to UI when 'window:ready' is triggered

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---