Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039150Localization Pack: SpainAEAT 340public2018-08-17 12:412018-11-30 10:54
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0039150: 3.6.400 version of this module fails to install with ERP 18Q3 version as accidentally contains changes for Q4
DescriptionFix for issue 39095 accidentally mixes the fix (SQLFunctionRegister) with an api change of hibernate upgrade project from 18Q4.

That makes the this version fail to compile with 18Q3.

    [javac] /opt/OpenbravoERP/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java:14: error: package org.hibernate.query does not exist
    [javac] import org.hibernate.query.Query;
    [javac] ^
    [javac] /opt/OpenbravoERP/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java:86: error: cannot find symbol
    [javac] final Query<PaymentInfoFor340> query_e = session_e.createQuery(sql.toString(),
    [javac] ^
    [javac] symbol: class Query
    [javac] location: class AEAT340Report_2012APRMDao
    [javac] /opt/OpenbravoERP/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java:86: error: method createQuery in interface Session cannot be applied to given types;
    [javac] final Query<PaymentInfoFor340> query_e = session_e.createQuery(sql.toString(),
    [javac] ^
    [javac] required: String
    [javac] found: String,Class<PaymentInfoFor340>
    [javac] reason: actual and formal argument lists differ in length
Steps To ReproduceERP 18Q3 instance
Set MMC to search in QA Approved
Install SPLP module name: "Professional Localization pack Spain (España)"
And rebuild

Proposed Solutionundo commit with mixes fixes.

Commit only intended SqlFunctionRegister fix and publish in QAA with dependency on Q3.

Fix for hibernate api change is also needed in tip with dependency raised to not be compatible with Q3
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0039095 closed collazoandy4 Openbravo ERP Update modules to SQLFunctionRegister 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-08-17 12:41shuehnerNew Issue
2018-08-17 12:41shuehnerAssigned To => Sandrahuguet
2018-08-17 12:42shuehnerRelationship addedcaused by 0039095
2018-08-17 12:47SandrahuguetAssigned ToSandrahuguet => collazoandy4
2018-08-20 09:09hgbotCheckin
2018-08-20 09:09hgbotNote Added: 0106400
2018-08-20 09:09hgbotStatusnew => resolved
2018-08-20 09:09hgbotResolutionopen => fixed
2018-08-20 09:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/5b195178e0ad26ccd052d0446d4f437676ba3d94 [^]
2018-08-20 09:09hgbotCheckin
2018-08-20 09:09hgbotNote Added: 0106401
2018-08-20 09:09hgbotCheckin
2018-08-20 09:09hgbotNote Added: 0106402
2018-08-20 09:57hgbotCheckin
2018-08-20 09:57hgbotNote Added: 0106404
2018-08-20 09:57hgbotCheckin
2018-08-20 09:57hgbotNote Added: 0106406
2018-08-20 09:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/5b195178e0ad26ccd052d0446d4f437676ba3d94 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/b4e12ccaefacf703dc650dc0e1102546bedb237a [^]
2018-08-20 09:57hgbotCheckin
2018-08-20 09:57hgbotNote Added: 0106407
2018-08-20 10:22hgbotCheckin
2018-08-20 10:22hgbotNote Added: 0106408
2018-08-21 09:46SandrahuguetReview Assigned To => Sandrahuguet
2018-08-21 09:46SandrahuguetNote Added: 0106420
2018-08-21 09:46SandrahuguetStatusresolved => closed
2018-11-30 10:16hgbotCheckin
2018-11-30 10:16hgbotNote Added: 0108177
2018-11-30 10:54hgbotCheckin
2018-11-30 10:54hgbotNote Added: 0108178

Notes
(0106400)
hgbot   
2018-08-20 09:09   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 5b195178e0ad26ccd052d0446d4f437676ba3d94
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Aug 17 19:56:35 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/5b195178e0ad26ccd052d0446d4f437676ba3d94 [^]

Fixes issue 39150:Removed changes of 18Q4

The fix for issue 39095 accidentally mixes the fix with an api chan of hibernate
upgrade project from 18Q4

The upgrades changes was removed.

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---
(0106401)
hgbot   
2018-08-20 09:09   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 409efd629837cf35fa10a4036da253371f992795
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 20 09:06:54 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/409efd629837cf35fa10a4036da253371f992795 [^]

related to issue 39150 remove not necessary imports

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---
(0106402)
hgbot   
2018-08-20 09:09   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 4529aa0fad2d516e4873c61be79e86db5f4f9334
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Aug 17 20:07:31 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/4529aa0fad2d516e4873c61be79e86db5f4f9334 [^]

Related to issue 39150: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0106404)
hgbot   
2018-08-20 09:57   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: b3e8cd3d99f5dfe9564c81dbeeabc5522a572bea
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 20 09:56:39 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/b3e8cd3d99f5dfe9564c81dbeeabc5522a572bea [^]

related to issue 39150 Update modules to support latest version of Hibernate

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---
(0106406)
hgbot   
2018-08-20 09:57   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: b4e12ccaefacf703dc650dc0e1102546bedb237a
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Aug 17 20:12:56 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/b4e12ccaefacf703dc650dc0e1102546bedb237a [^]

Fixes issue 39150:Removed changes of 18Q4

The fix for issue 39095 accidentally mixes the fix with an api chan of hibernate
upgrade project from 18Q4

The upgrades changes was removed.

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---
(0106407)
hgbot   
2018-08-20 09:57   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: b3d764e48b3b764068e2cda9da8d10c959a38048
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Aug 17 20:15:41 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/b3d764e48b3b764068e2cda9da8d10c959a38048 [^]

Related to issue 39150: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0106408)
hgbot   
2018-08-20 10:22   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 67ed7b5f35759d68db648aec58f7ca463d1c8eef
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 20 10:18:31 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/67ed7b5f35759d68db648aec58f7ca463d1c8eef [^]

related to issue 39150 Update modules to support latest version of Hibernate

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---
(0106420)
Sandrahuguet   
2018-08-21 09:46   
code review + testing OK
(0108177)
hgbot   
2018-11-30 10:16   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 275dbf67a1738a786f75305a70091bc45b3cec6b
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 20 09:56:39 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/275dbf67a1738a786f75305a70091bc45b3cec6b [^]

related to issue 39150 Update modules to support latest version of Hibernate

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---
(0108178)
hgbot   
2018-11-30 10:54   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 72132ae8dcf7b0053d11ee0001511825b8fb4c80
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 20 10:18:31 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/72132ae8dcf7b0053d11ee0001511825b8fb4c80 [^]

related to issue 39150 Update modules to support latest version of Hibernate

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012APRMDao.java
---