Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0039140Openbravo ERPA. Platformpublic2018-08-15 15:162018-12-11 20:22
shuehner 
alostale 
normalminorhave not tried
closedfixed 
5
 
3.0PR19Q1 
caristu
Core
No
0039140: Remove -Drestart=yes option from smartbuild, as tomcat restart should be always done via OS
ant smartbuild has a optional -Drestart=yes flag which if used uses openbravo MMC code to restart tomcat.

As smartbuild is commandline task there is no need at all to us the ob MMC tomcat restart code instead of the native tomcat packaging restart (i.e. /etc/init.d/tomcat script).

Apart that restart option can only work with tomcat and not with i.e. wildfly.

-
Remove -Drestart=yes option from ant smartbuild
Remove mentioned tomcat.restart + tomcat.restart.do from ant -p output to not advertise them to be used manually.
No tags attached.
blocks design defect 0038296 acknowledged platform Review & cleanup build.xml 
Issue History
2018-08-15 15:16shuehnerNew Issue
2018-08-15 15:16shuehnerAssigned To => shuehner
2018-08-15 15:16shuehnerModules => Core
2018-08-15 15:16shuehnerTriggers an Emergency Pack => No
2018-08-15 15:16shuehnerRelationship addedblocks 0038296
2018-08-15 15:37shuehnerNote Added: 0106354
2018-10-11 10:02alostaleAssigned Toshuehner => alostale
2018-10-11 10:04hgbotCheckin
2018-10-11 10:04hgbotNote Added: 0107242
2018-10-11 10:04hgbotStatusnew => resolved
2018-10-11 10:04hgbotResolutionopen => fixed
2018-10-11 10:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/44a01083360db9eb9b6d49359208ca70407cd622 [^]
2018-10-11 10:05alostaleReview Assigned To => caristu
2018-10-11 11:23caristuNote Added: 0107248
2018-10-11 11:23caristuStatusresolved => closed
2018-10-11 11:23caristuFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108425

Notes
(0106354)
shuehner   
2018-08-15 15:37   
wiki documentation update:
http://wiki.openbravo.com/w/index.php?title=Development_Build_Tasks&action=historysubmit&diff=227412&oldid=217900 [^]
(0107242)
hgbot   
2018-10-11 10:04   
Repository: erp/devel/pi
Changeset: 44a01083360db9eb9b6d49359208ca70407cd622
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 11 10:01:13 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/44a01083360db9eb9b6d49359208ca70407cd622 [^]

fixed issue 39140: removed restart option from smartbuild

---
M build.xml
---
(0107248)
caristu   
2018-10-11 11:23   
Code reviewed + tested OK.
(0108425)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test