Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039124Retail ModulesWeb POSpublic2018-08-13 11:372018-08-23 11:23
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039124: Edit button shows an empty view if there is not a product line in the ticket
DescriptionAt the beginning, if the receipt is empty ant you try to edit a line, the edit view is shown empty.
Steps To Reproduce-login
-with an empty receipt, tao edit button
-edit view is shown empty
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0043650 closed prakashmurugesan88 WebPOS Disable Edit Tab preference is not working after adding a product to the ticket 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-08-13 11:37javierRodriguezNew Issue
2018-08-13 11:37javierRodriguezAssigned To => javierRodriguez
2018-08-13 11:37javierRodriguezTriggers an Emergency Pack => No
2018-08-16 08:52hgbotCheckin
2018-08-16 08:52hgbotNote Added: 0106357
2018-08-16 08:52hgbotStatusnew => resolved
2018-08-16 08:52hgbotResolutionopen => fixed
2018-08-16 08:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c662e3c5aeb81d524521ea947907f20a3857002 [^]
2018-08-16 08:53hgbotCheckin
2018-08-16 08:53hgbotNote Added: 0106358
2018-08-17 13:40marvintmNote Added: 0106387
2018-08-17 13:40marvintmStatusresolved => new
2018-08-17 13:40marvintmResolutionfixed => open
2018-08-23 08:23hgbotCheckin
2018-08-23 08:23hgbotNote Added: 0106452
2018-08-23 08:23hgbotStatusnew => resolved
2018-08-23 08:23hgbotResolutionopen => fixed
2018-08-23 08:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c662e3c5aeb81d524521ea947907f20a3857002 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/716482b9a59c1898039fce7e644f41954254945f [^]
2018-08-23 08:23hgbotCheckin
2018-08-23 08:23hgbotNote Added: 0106453
2018-08-23 11:23marvintmReview Assigned To => marvintm
2018-08-23 11:23marvintmStatusresolved => closed
2018-08-23 11:23marvintmFixed in Version => RR18Q4
2020-04-02 16:01ngarciaRelationship addedcauses 0043650

Notes
(0106357)
hgbot   
2018-08-16 08:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3c662e3c5aeb81d524521ea947907f20a3857002
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Mon Aug 13 11:41:35 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c662e3c5aeb81d524521ea947907f20a3857002 [^]

Fixed issue 39124: Edit button shows an empty view if there is not a product line in the ticket

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0106358)
hgbot   
2018-08-16 08:53   
Repository: tools/automation/pi-mobile
Changeset: f77f4d69a4d4e5051b87753d4a7f402f68e049eb
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Aug 14 09:50:33 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f77f4d69a4d4e5051b87753d4a7f402f68e049eb [^]

Related to issue 39124: Edit button shows an empty view if there is not a product line in the ticket

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/VerifyTabChange.java
---
(0106387)
marvintm   
2018-08-17 13:40   
The fix works in the sense that you cannot access the edit panel anymore if there is no line selected, but it's a bit weird because the button doesn't look like it's disabled, and the user can click it.

Most probably we are missing the css class which makes it look disabled.
(0106452)
hgbot   
2018-08-23 08:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 716482b9a59c1898039fce7e644f41954254945f
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Aug 21 14:48:42 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/716482b9a59c1898039fce7e644f41954254945f [^]

Fixed issue 39124: Edit button shows an empty view if there is not a product line in the ticket

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0106453)
hgbot   
2018-08-23 08:23   
Repository: tools/automation/pi-mobile
Changeset: 0112b4c20d2d9470def6c8d555dc5c0e360c3ddc
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Wed Aug 22 14:40:40 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0112b4c20d2d9470def6c8d555dc5c0e360c3ddc [^]

Related to issue 39124: Edit button shows an empty view if there is not a product line in the ticket

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33480_ValidateEditTabInfoOnTicketDelete.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33557_ValidateEditTabInfo.java
---