Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0039091 | Retail Modules | Copy Retail Store | public | 2018-08-03 14:47 | 2018-08-31 13:39 |
|
| Reporter | joniturralde93 | |
| Assigned To | rqueralta | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | RR18Q4 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0039091: 'Copy Retail Store' copied names for some windows can be problematic |
| Description | When a Store is copied, Management Events, Document Sequences and POS Terminal Type records are copied by adding the new Store search key to their names.
This happens for other windows (please check which ones).
This can be confusing if the original names had the old store name or prefix included.
E.g: POS Terminal Type 'Store1POSType' would be copied to the new store as 'Store1POSType - Store2'.
|
| Steps To Reproduce | 1. Fill and complete Copy Retail Store (make a copy of Vall Blanca Store in live builds) with new search key 'TestCopy'.
2. Go to Document Sequence window.
3. New copied records are named 'VBS AR Invoice - TestCopy' etc even though the Store is not 'VBS' anymore.
4. It happens in other windows, too. Please check that this is fixed for every window that can have this problem.
|
| Proposed Solution | Check if previous names contain the original store name or prefix and replace it with the new one if necessary.
If the original name doesn't contain the store name, just add the new search key to the previous name like it is done now.
|
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0041270 | | closed | rqueralta | Copy Store Process are copying the same POS Terminal Type Name as the Original Store copied. | | causes | defect | 0040328 | | closed | Retail | Error while executing the copy store process using a XLS file in 19Q1 |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-08-03 14:47 | joniturralde93 | New Issue | |
| 2018-08-03 14:47 | joniturralde93 | Assigned To | => Retail |
| 2018-08-03 14:47 | joniturralde93 | Resolution time | => 1535061600 |
| 2018-08-03 14:47 | joniturralde93 | Triggers an Emergency Pack | => No |
| 2018-08-03 18:14 | rqueralta | Assigned To | Retail => rqueralta |
| 2018-08-03 18:14 | rqueralta | Status | new => scheduled |
| 2018-08-06 08:17 | joniturralde93 | Note Added: 0106162 | |
| 2018-08-06 08:17 | joniturralde93 | Description Updated | bug_revision_view_page.php?rev_id=17493#r17493 |
| 2018-08-06 08:17 | joniturralde93 | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=17495#r17495 |
| 2018-08-06 08:17 | joniturralde93 | Proposed Solution updated | |
| 2018-08-13 16:04 | hgbot | Checkin | |
| 2018-08-13 16:04 | hgbot | Note Added: 0106326 | |
| 2018-08-13 16:04 | hgbot | Status | scheduled => resolved |
| 2018-08-13 16:04 | hgbot | Resolution | open => fixed |
| 2018-08-13 16:04 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/a3bc37e5e273363040b5acc53233642baaec2cf3 [^] |
| 2018-08-23 11:10 | marvintm | Note Added: 0106461 | |
| 2018-08-23 11:10 | marvintm | Status | resolved => new |
| 2018-08-23 11:10 | marvintm | Resolution | fixed => open |
| 2018-08-24 17:33 | hgbot | Checkin | |
| 2018-08-24 17:33 | hgbot | Note Added: 0106479 | |
| 2018-08-28 17:27 | hgbot | Checkin | |
| 2018-08-28 17:27 | hgbot | Note Added: 0106509 | |
| 2018-08-28 17:28 | rqueralta | Status | new => scheduled |
| 2018-08-28 17:29 | rqueralta | Status | scheduled => resolved |
| 2018-08-28 17:29 | rqueralta | Resolution | open => fixed |
| 2018-08-31 13:39 | marvintm | Review Assigned To | => marvintm |
| 2018-08-31 13:39 | marvintm | Status | resolved => closed |
| 2018-08-31 13:39 | marvintm | Fixed in Version | => RR18Q4 |
| 2019-03-07 09:40 | dmitry_mezentsev | Relationship added | causes 0040328 |
| 2019-07-12 10:48 | samuel_nicuesa | Relationship added | related to 0041270 |
|
Notes |
|
|
|
|
Updated for every copied window. |
|
|
|
(0106326)
|
|
hgbot
|
|
2018-08-13 16:04
|
|
|
|
|
|
Two small improvements could be done to the fix:
- Currently the name of the original store is modified and the blank spaces are removed. However, this means that if the name of the store is used literally, including its spaces, in the names of the objects, then it is not correctly removed. Either we should use a regular expression to detect both cases, or if too complex, then the blank spaces should not be removed from the original name.
- Currently the transformation of the name only occurs for the search key, or if it doesn't exist, for the name of the store, or if it doesn't exist, for the terminal name, ... It would be better if it happened for every one of them, so that if the name of the store, and the search key, appear both in the name for some reason (like it happens in some records in Valblanca store in our sampledata for example), then both are replaced. |
|
|
|
(0106479)
|
|
hgbot
|
|
2018-08-24 17:33
|
|
|
|
|
(0106509)
|
|
hgbot
|
|
2018-08-28 17:27
|
|
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 81bf973b98d47841a02daf0ba7cde3934281a1ca
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Aug 27 00:11:21 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/81bf973b98d47841a02daf0ba7cde3934281a1ca [^]
Related to issue 39091: 'Copy Retail Store' copied names for some windows can be
problematic
- Changed financial account name
---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
|
|