Openbravo Issue Tracking System - Modules
When the PUBON is exported the payments are not included.
The getPaymentMethodLines() method is considering only 1 of the payment plans. In case it takes the one with the outstanding amount the payments are not included. See proposed solution.
How to generate an invoice with several payment plans:
- Assign a split payment terms to Arturo Montoro.
- Enable the "Pay on Credit" and assign a credit limit to Arturo Montoro.
- Refresh the POS and create a ticket partially paid leaving the remaining amoutn on credit.
- Do the cashup to generate the invoice and check that it has 2 payment plans.
- Alternatively it is possible use the generate the invoice on ticket completion with the same result.
protected List<SynchronizableBusinessObject> getPaymentMethodLines(Invoice invoice) {
List<SynchronizableBusinessObject> sbos = new ArrayList<>();
List<FIN_PaymentSchedule> invoicePaymentsSchedule = invoice.getFINPaymentScheduleList();
if (!invoicePaymentsSchedule.isEmpty()) {
for (FIN_PaymentScheduleDetail paymentDetails : invoicePaymentsSchedule.get(0)
.getFINPaymentScheduleDetailInvoicePaymentScheduleList()) {
if (paymentDetails.getAPRMPaymentMethod() != null
&& paymentDetails.getAPRMFinancialAccount() != null) {
SynchronizableBusinessObject sbo = getPaymentMethodLines(paymentDetails);
processPaymentDetail(sbo, paymentDetails);
sbos.add(sbo);
}
}
}
return sbos;
}
Attached a diff with a proposal fix.
1. invoicePaymentsSchedule.get(0) -> It is considering invoices with a single payment plan:
This is wrong, it is possible to have split payments so all payment schedules should be iterated.
2. paymentDetails.getAPRMPaymentMethod() and paymentDetails.getAPRMFinancialAccount():
These are computed columns. So it is required to compute them before accessing their values
paymentDetails.get_computedColumns().getAPRMFinancialAccount()
3. The computed columns are not considering payments with total amount 0. Is this the expected behavior in order to include the payment amount in the pubon?
The Payment Method and Financial account are mandatory fields of the Payment entity. The code could be simplified to check if the paymentDetails is related to a "FIN_PaymetnDetail"
if (paymentDetails.getPaymentDetails() != null)
and to get the method and account:
paymentDetails.getPaymentDetails().getFinPayment().getPaymentMethod()
paymentDetails.getPaymentDetails().getFinPayment().getAccount()
paymentsMissingInPUBON.diff (4,141) 2018-07-30 12:45https://issues.openbravo.com/file_download.php?file_id=12016&type=bug
issue-39064.patch (4,715) 2018-08-17 21:48https://issues.openbravo.com/file_download.php?file_id=12057&type=bug