Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039010Retail ModulesWeb POSpublic2018-07-20 12:552018-12-03 15:58
Reporteregoitz 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039010: Delete cache deletion revision
DescriptionThe cache deletion should be executed with the following condition:
-Never should remove data pending to be sync
-It should require user confirmation (and approval feature to add restrictions)

The deletion should be reviewed to try to do it only when needed.
REview also that there is not asynchrony that can cause problems.
.
Steps To Reproducen/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039009 closed migueldejuana Do not set terminalName with empty value 
related to defect 0039508 new Retail Save log when localStorage is cleared 
related to defect 0039509 new Retail Review automated test and ensure that clearLocalStorage() is properly used 
Attached Filesdiff mobileCore18Q3.diff (199,301) 2018-12-03 15:58
https://issues.openbravo.com/file_download.php?file_id=12408&type=bug
diff posterminal18Q3.diff (9,155) 2018-12-03 15:58
https://issues.openbravo.com/file_download.php?file_id=12409&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-07-20 12:55egoitzNew Issue
2018-07-20 12:55egoitzAssigned To => Retail
2018-07-20 12:55egoitzResolution time => 1534456800
2018-07-20 12:55egoitzTriggers an Emergency Pack => No
2018-07-20 14:08egoitzRelationship addedrelated to 0039009
2018-08-16 08:27marvintmResolution time1534456800 => 1535320800
2018-08-23 10:23marvintmResolution time1535320800 => 1536530400
2018-09-06 15:57marvintmResolution time1536530400 => 1537135200
2018-09-13 15:10marvintmResolution time1537135200 => 1537394400
2018-09-21 08:23marvintmResolution time1537394400 => 1538085600
2018-10-03 10:32jorge-garciaAssigned ToRetail => migueldejuana
2018-10-03 10:32jorge-garciaStatusnew => scheduled
2018-10-05 13:24marvintmResolution time1538085600 => 1539036000
2018-10-11 17:58marvintmResolution time1539036000 => 1540332000
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107517
2018-10-23 11:47hgbotStatusscheduled => resolved
2018-10-23 11:47hgbotResolutionopen => fixed
2018-10-23 11:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0cae1cd7d545309ef3a89e68e79159aa328cb8b [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107518
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0cae1cd7d545309ef3a89e68e79159aa328cb8b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9736e7239ee084871e2a0b12197c426ccbab33d0 [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107519
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9736e7239ee084871e2a0b12197c426ccbab33d0 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/c6f89bd8c915f52b0c54692c72059311248162fb [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107520
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/c6f89bd8c915f52b0c54692c72059311248162fb [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/12bce858178136faf1f3a3b899c7a115ac4deaa3 [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107521
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/12bce858178136faf1f3a3b899c7a115ac4deaa3 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/379f34f1533970bdf1662a1bb384db4fc57e1306 [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107522
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/379f34f1533970bdf1662a1bb384db4fc57e1306 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/24b2d9929f40328c31b70b49cf28dd70e10abb33 [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107523
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/24b2d9929f40328c31b70b49cf28dd70e10abb33 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/fa5b77ca7d678979a3a2ce0c20e5fb9ea111a366 [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107524
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/fa5b77ca7d678979a3a2ce0c20e5fb9ea111a366 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/aac2e8a27e2ef069159731de9625339206434c1c [^]
2018-10-23 11:47hgbotCheckin
2018-10-23 11:47hgbotNote Added: 0107525
2018-10-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/aac2e8a27e2ef069159731de9625339206434c1c [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/5b13158f6752932f1d24403d82cff0693f4849cd [^]
2018-10-23 11:55migueldejuanaRelationship addedrelated to 0039508
2018-10-23 11:57migueldejuanaRelationship addedrelated to 0039509
2018-10-26 09:36hgbotCheckin
2018-10-26 09:36hgbotNote Added: 0107611
2018-10-26 09:36marvintmReview Assigned To => marvintm
2018-10-26 09:36marvintmStatusresolved => closed
2018-10-26 09:36marvintmFixed in Version => RR19Q1
2018-12-03 15:58migueldejuanaFile Added: mobileCore18Q3.diff
2018-12-03 15:58migueldejuanaFile Added: posterminal18Q3.diff

Notes
(0107517)
hgbot   
2018-10-23 11:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d0cae1cd7d545309ef3a89e68e79159aa328cb8b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 02 12:15:52 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0cae1cd7d545309ef3a89e68e79159aa328cb8b [^]

Fixed issue 0039010: Delete cache deletion revision

- Check if we have non processed chasups when unlinking a terminal. Warn the user and ask if continue or not.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
A src/org/openbravo/retail/posterminal/process/ValidationUnlinkDeviceActionHandler.java
A web/org.openbravo.retail.posterminal/js/utils/unlinkDeviceValidation.js
---
(0107518)
hgbot   
2018-10-23 11:47   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9736e7239ee084871e2a0b12197c426ccbab33d0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 02 12:17:09 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9736e7239ee084871e2a0b12197c426ccbab33d0 [^]

Fixed issue 0039010: Delete cache deletion revision

- Show a popup to warn the user that the terminal has changed and the caché will be cleared

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/ob-login.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-localStorage.js
---
(0107519)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: c6f89bd8c915f52b0c54692c72059311248162fb
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 05 11:25:42 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c6f89bd8c915f52b0c54692c72059311248162fb [^]

Fixed issue 0039010: Delete cache deletion revision

- Add new modal when changing terminal
- Remove localStorace.clear() from DocumentnoSynchronizationContentInReceipt

---
M src-test/org/openbravo/test/mobile/retail/mobilecore/selenium/terminals/MobileCoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/DocumentnoSynchronizationContentInReceipt.java
---
(0107520)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: 12bce858178136faf1f3a3b899c7a115ac4deaa3
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Oct 08 16:13:19 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/12bce858178136faf1f3a3b899c7a115ac4deaa3 [^]

Fixed issue 0039010: Delete cache deletion revision

- Adapt tests to new popup

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/CheckInitialCountInSeller.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/CloseSellerSession.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayFullyLayawayInSeller.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayOpenTicketInSeller.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayPartiallyLayawayInSeller.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/selenium/terminals/MobileCoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/terminals/WebPOSSPMTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I29055_TerminalChange.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/CreateLayawayPayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicket.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicketLines.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32135_NavigatingFailsToLoadTerminal.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/VerifyCrossStoreOnlyDefined.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I31591_VerifySharePaymentsCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I28393_IncrementalRefreshProductLoad.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32714_HookPreCustomerAddrSaveCancelling.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I34586_CashupErrorLoginRestricted.java
---
(0107521)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: 379f34f1533970bdf1662a1bb384db4fc57e1306
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 09 16:48:43 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/379f34f1533970bdf1662a1bb384db4fc57e1306 [^]

Fixed issue 0039010: Delete cache deletion revision

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/CheckInitialCountInSeller.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/CloseSellerSession.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayFullyLayawayInSeller.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/PayPartiallyLayawayInSeller.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I29055_TerminalChange.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34396_VerifyLoginNotExitsTerminal.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicket.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicketLines.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32135_NavigatingFailsToLoadTerminal.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I31591_VerifySharePaymentsCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMMulticurrencyPayInEURUSD.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMNeedToCloseMaster.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMQuotationSharedPayments.java
---
(0107522)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: 24b2d9929f40328c31b70b49cf28dd70e10abb33
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Thu Oct 11 16:20:59 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/24b2d9929f40328c31b70b49cf28dd70e10abb33 [^]

Fixed issue 0039010: Delete cache deletion revision

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31196_ReassignNewCustomer.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32135_NavigatingFailsToLoadTerminal.java
---
(0107523)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: fa5b77ca7d678979a3a2ce0c20e5fb9ea111a366
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Oct 15 13:51:47 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fa5b77ca7d678979a3a2ce0c20e5fb9ea111a366 [^]

Fixed issue 0039010: Delete cache deletion revision

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I36010_PayCertificateTicketOtherTerminal.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I33019_VerifyPacksInNaturalTreeOrganization.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/TerminalChangeAllowed.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32135_NavigatingFailsToLoadTerminal.java
---
(0107524)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: aac2e8a27e2ef069159731de9625339206434c1c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 16 07:43:49 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/aac2e8a27e2ef069159731de9625339206434c1c [^]

Fixed issue 0039010: Delete cache deletion revision

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I36010_PayCertificateTicketOtherTerminal.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/TerminalChangeAllowed.java
---
(0107525)
hgbot   
2018-10-23 11:47   
Repository: tools/automation/pi-mobile
Changeset: 5b13158f6752932f1d24403d82cff0693f4849cd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Oct 22 16:58:04 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5b13158f6752932f1d24403d82cff0693f4849cd [^]

Fixed issue 0039010: Delete cache deletion revision

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/certification_france/OBCFRTestBase.java
---
(0107611)
hgbot   
2018-10-26 09:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 98ae9454dcc9c4351dcd79a6a31425e89f4f72e9
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Oct 26 09:35:40 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98ae9454dcc9c4351dcd79a6a31425e89f4f72e9 [^]

Related to issue 39010. Add limit to improve query performance

---
M src/org/openbravo/retail/posterminal/process/ValidationUnlinkDeviceActionHandler.java
---